From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B8A1C4167B for ; Fri, 1 Dec 2023 15:02:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379295AbjLAPC1 (ORCPT ); Fri, 1 Dec 2023 10:02:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379270AbjLAPCY (ORCPT ); Fri, 1 Dec 2023 10:02:24 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DCB410F9 for ; Fri, 1 Dec 2023 07:02:31 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40DD3C433C9; Fri, 1 Dec 2023 15:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701442950; bh=HCKgkvZM3p9a1PhMU+0ZdI63NNj7rU/pKhx/Px4fVKY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZnzIEJkgcQPJ9EhwbA+QMxmLvo7Vb5mFoKAoNXH6yHgW+nms/wyXGXewhlB2+aaMv ggRc0WCfAnmF4J1gGXJNsVm00we+Ush4nAHaDY6/aboqP1YpJAeXkD97yaQm8LF8DA kcLJiTetD9+tqyUXfvHMuhZjY2ZJFxqDcxvpvNstZflcgXy8ZgkfwU667pQAlZks+n JLx/dRpoe81S7cz16xFnm3ay1eGU674lCQdb1zXCGrUTHqAKRJwjbY6ZS9z8d7fK1o 4iwBWtKKzMnCl2rC99z3RVqUB/XbA4ZBM/7CWSyEJ5gV7SbzjnjMTZ4SljJxZUkoLX rN/ROb0OGkmhg== Message-ID: <5a660c0f-d3ed-47a2-b9be-098a224b8a12@kernel.org> Date: Fri, 1 Dec 2023 16:02:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH bpf-next v2 2/3] net: stmmac: Add txtime support to XDP ZC Content-Language: en-US To: Song Yoong Siang , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Stanislav Fomichev , Lorenzo Bianconi , Tariq Toukan , Willem de Bruijn , Maxime Coquelin , Andrii Nakryiko , Mykola Lysenko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Shuah Khan , Alexandre Torgue , Jose Abreu Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, bpf@vger.kernel.org, xdp-hints@xdp-project.net, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org References: <20231201062421.1074768-1-yoong.siang.song@intel.com> <20231201062421.1074768-3-yoong.siang.song@intel.com> From: Jesper Dangaard Brouer In-Reply-To: <20231201062421.1074768-3-yoong.siang.song@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/1/23 07:24, Song Yoong Siang wrote: > This patch enables txtime support to XDP zero copy via XDP Tx > metadata framework. > > Signed-off-by: Song Yoong Siang > --- > drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 13 +++++++++++++ > 2 files changed, 15 insertions(+) I think we need to see other drivers using this new feature to evaluate if API is sane. I suggest implementing this for igc driver (chip i225) and also for igb (i210 chip) that both support this kind of LaunchTime feature in HW. The API and stmmac driver takes a u64 as time. I'm wondering how this applies to i210 that[1] have 25-bit for LaunchTime (with 32 nanosec granularity) limiting LaunchTime max 0.5 second into the future. And i225 that [1] have 30-bit max 1 second into the future. [1] https://github.com/xdp-project/xdp-project/blob/master/areas/tsn/code01_follow_qdisc_TSN_offload.org