From: Armin Wolf <W_Armin@gmx.de>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ACPI: OSL: Poweroff when encountering a fatal ACPI error
Date: Sun, 1 Mar 2026 18:59:55 +0100 [thread overview]
Message-ID: <5a6bbac6-e60a-426d-a6fe-d478e74b8532@gmx.de> (raw)
In-Reply-To: <CAJZ5v0jwE_CYDAxT3OYx4+i4nk1v2TTuyFHbzCKXVD0j5mBuiw@mail.gmail.com>
Am 27.02.26 um 21:39 schrieb Rafael J. Wysocki:
> On Fri, Feb 27, 2026 at 8:55 PM Armin Wolf <W_Armin@gmx.de> wrote:
>> Am 27.02.26 um 20:50 schrieb Armin Wolf:
>>
>>> Am 26.02.26 um 19:46 schrieb Rafael J. Wysocki:
>>>
>>>> On Thu, Feb 26, 2026 at 7:35 AM Armin Wolf <W_Armin@gmx.de> wrote:
>>>>> Am 25.02.26 um 22:28 schrieb Rafael J. Wysocki:
>>>>>
>>>>>> On Wed, Feb 25, 2026 at 12:06 AM Armin Wolf <W_Armin@gmx.de> wrote:
>>>>>>> Am 04.02.26 um 22:29 schrieb Armin Wolf:
>>>>>>>
>>>>>>>> The ACPI spec states that the operating system should respond
>>>>>>>> to a fatal ACPI error by "performing a controlled OS shutdown in
>>>>>>>> a timely fashion". Comply with the ACPI specification by powering
>>>>>>>> off the system when ACPICA signals a fatal ACPI error. Users can
>>>>>>>> still disable this behavior by using the acpi.poweroff_on_fatal
>>>>>>>> kernel option to work around firmware bugs.
>>>>>>> Any updates on this?
>>>>>> I was about to apply it, but then I thought that I was not sure about
>>>>>> the Kconfig option.
>>>>>>
>>>>>> I don't see much value in it TBH. If you agree, I'll just apply
>>>>>> the
>>>>>> patch without that part.
>>>>>>
>>>>>> Thanks!
>>>>> You can drop the Kconfig option if you want.
>>>> OK, applied as 7.1 material.
>>>>
>>>> Please double check
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=6f09a7009a1d7a132ddce3a8dd0c46aac66ad8e2
>>>>
>>> Looks good to me, except that the include of kconfig.h should be
>>> dropped now.
>>>
>>> Thanks,
>>> Armin Wolf
>>>
>> I also just noticed that we still need to include panic.h for add_taint().
> It complied regardless, likely because kernel.h was included, but yes.
>
>> Should i send a new revision?
> No need, I've just updated it by hand and pushed it out.
Thank you very much :)
Armin Wolf
prev parent reply other threads:[~2026-03-01 18:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 21:29 Armin Wolf
2026-02-24 23:05 ` Armin Wolf
2026-02-25 21:28 ` Rafael J. Wysocki
2026-02-26 6:35 ` Armin Wolf
2026-02-26 18:46 ` Rafael J. Wysocki
2026-02-27 19:50 ` Armin Wolf
2026-02-27 19:55 ` Armin Wolf
2026-02-27 20:39 ` Rafael J. Wysocki
2026-03-01 17:59 ` Armin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a6bbac6-e60a-426d-a6fe-d478e74b8532@gmx.de \
--to=w_armin@gmx.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®