From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2EDB32E723 for ; Fri, 30 Jan 2026 09:54:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769766881; cv=none; b=uEV7e45KIAxwp8zkQcjfWtNOdd8UP45F6h/Mo3UqmuaFobmOR9JYxGlhYBpHhMqmlQeDxlvD+ycTkBgkxkVg4Vi5lEkDgabCO/IuUZcPyKmdaxEcuQDC+XZBbTVgNDnBmBh9ccFhWWkJh6FxTEKuPna6YNxFjvgyiBES6AWdUfY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769766881; c=relaxed/simple; bh=ZJA9kN03DvD07TYAjfnZgouJ+W+OT0ZEDNFcgiOBCLQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QDZtJPeS2YdCQ/NgUMLTJMTECWXjNYxUa0inttnLx6i1oIjHOPVLj1GuQLXKIAtbpWPjpIaNIclNLFqLNSlThqriO4N3nzCMa3yVWM/bsxocdB3RI9nZQUn63QJXEefGHojeMpQ7riiqLIf0yJ6nI/4D0YwnP/kAcfOplRT2aJ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FLZ51zPu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Xdhy3R17; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FLZ51zPu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Xdhy3R17" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60U3VnM81488328 for ; Fri, 30 Jan 2026 09:54:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= H9+DAV+c/CZgBH4DD2jfZcDSjLwf6jHYApWbhBRrbJ0=; b=FLZ51zPuR2jby4lo tSc/czS0eCZMucXmZkjXl5qnsv6WmbE16cUZ52mpGa/Sxugkrc5PaaX/2RXQrHuw u8Tc6iX13mX8/HzCRPT04lmZmIcZLU/Pz/buKEQ2ob/CDqO2fHsNZ3rxdtS2nxSG 9+VGQwtAEljGwZoJB0furVt/tZvLzrb6n9cmUHdS5v8FonBYU/m/tQDCUQCBQJ/N 9CP7wgwSu3VYumGEkIw73KXSFn5ymPLypP9fire8+a/inRKIeziUf0ZOxi55g8iC 6b8cIcTijbYjrw1x8NTlh5s8Cp9vVYad71hF5yrLfzUrn9pKtd/i+pOVJogW3z70 KM+ZzA== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c0bp3tqkc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 30 Jan 2026 09:54:37 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-88fd7ddba3fso1761426d6.1 for ; Fri, 30 Jan 2026 01:54:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769766877; x=1770371677; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=H9+DAV+c/CZgBH4DD2jfZcDSjLwf6jHYApWbhBRrbJ0=; b=Xdhy3R17Ehz8DG5qBx9X7lb05PUudEsMylAcDq93FYhZYZXLidiDGgjRHA7LfohcUm f6AIv95mOjJrlYBxMAH7c8Aw5pM1qv9TnzlsfBM4PxDmpb5MpriKy83uErx3ESqwqzpC 1yrs7Q1Ik/QA/jRoaRoj1XCg5VhepJ9RLnqvqDQAj37qPgtgrYp2w4xiPRxQPfYIAWnP uUmSrCyxoQ5OlG0MLLXUDX48PkOmEy+DIJP1Nl40cPMZfTzu4LQoUYq+TS1J/dGvzFnV 1zefmoXgilfMcQnm5vTKSOertl8RESUij448G5rGLWnhzLMbFBHssLFV+3dDLTNY6eaC dz/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769766877; x=1770371677; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=H9+DAV+c/CZgBH4DD2jfZcDSjLwf6jHYApWbhBRrbJ0=; b=HUvCzC2mysGHxfgoC5OYJtcZHIDAnVyQPIVYNoRB4DvKDfQSPZqqD5Fq+MWzfhbQGj etBWVH4eKfQeQe53qEx2ca0dKlzH9TcSaviQgajbcHvaYS6O3s/m2fzc3yDdNmXkTYNb S7joV+MldllZIeNocbayl0FfBRJvMKhxGzh9col8QGB3qxlWXfSro9yQ2sv7hNGZAqPC RUQxkpb2BIQ9UCwiWPt+Pjxp7sYQxUTvzrfYuaFH85vmaV4FwUW+wjXixYKSU/3PJc/7 tlEv+i7dT76xLCfbdDC3ffVmaXkYA/6w682tVfaSns2xkZik2sAhOCMZHYwzEFQrcipL SUGA== X-Forwarded-Encrypted: i=1; AJvYcCVyzZUPJmw8bg92rgxqodUWzkGLlSyzG8uwk9Jr3iDdmdBYtI5Je7ZKJ7qrkKpp2SZDX8oGNAmyx0bKy9A=@vger.kernel.org X-Gm-Message-State: AOJu0YwixIBnKKaSQSX5I9YtJlo5c0SiWwGGdeCvpWbtPsyCCWLXZzq1 IzK/TBJtXtBuDK11QbGaL9iiXU/quRt6NKtO6LpcPv/MJNuY82AlvuqT9J7EkKDiPGv17Jy+39C yDrnnOefsNi+vqpigl7EZkc+t4NuBCNBiB+6QBh0Ka8Fp0yH+VzhbNARextDUhDeBx2g= X-Gm-Gg: AZuq6aLDA7cNg+jEAkcjPOqEAgCLRAQk3PWcalfge7BvdyQow+Dt4bXtprVOxk7TOKR 7GvVBemnrpTfN8y86zmsyp3IBRYeequKnR5TbHNvwMkJdu4YNEqP7a1MSXgiLPGDmIc0mee40Uh Fg9hVuTcVTJENDp8loVsZJRxb67Ck/V1IiHQ4ijkkm2WarSV1yk68bqHxpv+gHiTq4rL9gH68ut 1ois89pmnRs/VxwicaLOWc2KeEP8xhp3XbS04ZA6gJZkzobjt+1acyJumDTe/edOqz3yhL7LsxR N/Ob90Kj7WD1ppIeBx9rjmsIoxR5WkF9Kigw4iLDIG04M5Oj0cqq8bqSwTRWEXbyIfCf9+PU1Nc cc8GvwjnzhTWXVGBrC5QC+PGBfDSsP5s+sMdct80eT/LBFtDGbaOTStw18CG5u6ln7RA= X-Received: by 2002:a05:620a:4009:b0:8c7:9e6:3a4e with SMTP id af79cd13be357-8c9eb10f0a2mr239892685a.0.1769766877027; Fri, 30 Jan 2026 01:54:37 -0800 (PST) X-Received: by 2002:a05:620a:4009:b0:8c7:9e6:3a4e with SMTP id af79cd13be357-8c9eb10f0a2mr239890885a.0.1769766876599; Fri, 30 Jan 2026 01:54:36 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbef86deesm399356666b.3.2026.01.30.01.54.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jan 2026 01:54:35 -0800 (PST) Message-ID: <5a70d411-e0fc-45a5-829a-c20fa02317cb@oss.qualcomm.com> Date: Fri, 30 Jan 2026 10:54:32 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 4/5] arm64: dts: qcom: glymur: Add ADSP and CDSP for Glymur SoC To: Sibi Sankar , robh@kernel.org, srini@kernel.org, amahesh@qti.qualcomm.com, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org Cc: mathieu.poirier@linaro.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org References: <20260129001358.770053-1-sibi.sankar@oss.qualcomm.com> <20260129001358.770053-5-sibi.sankar@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260129001358.770053-5-sibi.sankar@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: J2rsFkydgU5XG80DpOLWTh-dznbPXBeg X-Proofpoint-ORIG-GUID: J2rsFkydgU5XG80DpOLWTh-dznbPXBeg X-Authority-Analysis: v=2.4 cv=d6T4CBjE c=1 sm=1 tr=0 ts=697c7fde cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=WPoQd7O3gY_o9P5QeXMA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTMwMDA3NiBTYWx0ZWRfX0PzFc3VTzQF+ WmciYDv6u9hC7Dg8FpuRDPlpG+0KYHUK8asETm5EU8KRXBeZ2GsNUgIHfNCnWLkZpn/EaP9al0H OINfA34Xg3iBv/SvQlHHOjB8Hn+6dBEmMCZJ+S9BNr3SC6RSFDf9MAZd/lxtFC9iSbrVJ8cIbJ/ 1uYEZHprA2P2FqtVH8ZSgOP0lSZS9M/7JGXGe6sDDSxT9ELUIQCWqCeUUuMx19PiGqSxdCoiOjc uxEGEnFt4aV+Eqm7iOG6qxAsSxDHaTUmWTnKs2lfDIPA2nKKfXAZesIrWQEkLhI+3qixzizM/lg orK5GdSPN2lRVNn5gfn2S2Fi0p+ofN6E6EsEGfpKuCS0etzJamp5gP7jNYXZ5WBVnZvrSG0orI0 FSGP2ru4KrIW65PrEIGN2ZLHsJAhXDkP/pc36TsT+o48Tv47TlUjPNxY2II4MUnWakvJ9333Rt7 5T862kGgJ94RIKcy0aw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-30_01,2026-01-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 malwarescore=0 clxscore=1015 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601300076 On 1/29/26 1:13 AM, Sibi Sankar wrote: > Add remoteproc PAS loader for ADSP and CDSP with its fastrpc nodes. > > Signed-off-by: Sibi Sankar > --- [...] > + fastrpc { > + compatible = "qcom,glymur-fastrpc", "qcom,kaanapali-fastrpc"; > + qcom,glink-channels = "fastrpcglink-apps-dsp"; > + label = "adsp"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + compute-cb@3 { > + compatible = "qcom,fastrpc-compute-cb"; > + reg = <3>; > + > + iommus = <&apps_smmu 0x1003 0x80>, > + <&apps_smmu 0x1043 0x20>; 0x104x -> 0x106x for all children here, the result is the same but let's match docs so that no one has questions down the line [...] > @@ -4692,6 +4808,176 @@ nsp_noc: interconnect@320c0000 { > #interconnect-cells = <2>; > }; > > + remoteproc_cdsp: remoteproc@32300000 { > + compatible = "qcom,glymur-cdsp-pas", "qcom,sm8550-cdsp-pas"; > + reg = <0x0 0x32300000 0x0 0x10000>; > + > + iommus = <&apps_smmu 0x2000 0x400>; 0x2400 (same reasoning) [...] > + fastrpc { > + compatible = "qcom,glymur-fastrpc", "qcom,kaanapali-fastrpc"; > + qcom,glink-channels = "fastrpcglink-apps-dsp"; > + label = "cdsp"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + compute-cb@1 { > + compatible = "qcom,fastrpc-compute-cb"; > + reg = <1>; > + > + iommus = <&apps_smmu 0x2001 0x440>, 0x200x -> 0x240x (again) Otherwise lgtm Reviewed-by: Konrad Dybcio Konrad