From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751557AbdJ1SdV (ORCPT ); Sat, 28 Oct 2017 14:33:21 -0400 Received: from mout.web.de ([212.227.17.11]:65214 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751324AbdJ1SdT (ORCPT ); Sat, 28 Oct 2017 14:33:19 -0400 Subject: Re: can: Use common error handling code in vxcan_newlink() To: Oliver Hartkopp , linux-can@vger.kernel.org, netdev@vger.kernel.org Cc: Marc Kleine-Budde , Wolfgang Grandegger , LKML , kernel-janitors@vger.kernel.org References: <2e600d9a-faec-dd39-08f0-5a7fb260d7ca@users.sourceforge.net> <2ab5d794-7a5c-9036-835c-67cfcc541795@hartkopp.net> <264b3c2b-8354-5769-639c-ac8d2fcbe630@hartkopp.net> From: SF Markus Elfring Message-ID: <5a76bb36-4ae0-eca2-ae34-69c2bfddb634@users.sourceforge.net> Date: Sat, 28 Oct 2017 20:33:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <264b3c2b-8354-5769-639c-ac8d2fcbe630@hartkopp.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:lO+IbgbJZkDUSCha7MlMi4oSMBCH5W+H7KAnUBdcDM+rnfOlC93 qrMJGQ4eYG/sU1OUXiS9gZGZe5crsmVhBPASleqkQ9dTF9mIX40na2dTkb6w5KYlRi5I3oW w99FjF0lHKo5sLjwGcis65v5BdZGmQpDaTQqIFPQ6TDTavYFAevAj2OmEL9xEB+mAPaVHnZ fKXw3u2GFYvkIXJgoiNJQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:LGXaBgbxJz4=:Z+IPQdPbBffwBLeJIfMvo+ WAXfB44Z5nlL8Z8UhJeFN6WvYpZ2tg6JqMy5j1dHEceO35B4+AT76gEVlAes8lE7b+M9BXO42 eVrvZzkVuz0wSVBrjNdKN2dAcS+v6tgQZhZW/zKm9cxYLVs4yTnX5G1w6mM86Z9BmV6PhivqU XR/GrGWsYCWde3gqBc76pPljceUwQP/b2eaZ+0ORmIWaS3xStOFprJ8dbApgI1xq89Noph2Pm 7aDxp1vXVSQK9A+ukcRqqeEnoFOrupwAwuwgg1PDZjDtDZRqd7vIZv3EU/N+TPvtZuPWJyM41 2YakwRIV726/d81Axlsdt69PiXvhVJWQZWOrv1FIqOqXqoP5j9gmcTo9o17eeeJpWxW7tHiGU lo2uxdH9AcKonsVD2Ibkb0pSvjikCu5Z///MgOMpRL9B/xB3jlm3YhAybwsYaV0+xbUV8IGjw 5zx0Rn1PhFmsISyhvzkXoOG7oZ20PTVKFYqv0bLLcgvMTorB+ScDkdwvd0ywYb58+sU5aan0m WWRS91d0UZuma1SS5aR0BQMSUITu6xh+7Rx+kpgDExXhG+oJdadBhu0yvlw8xkOQZyUOfwxDz RmW9RlMHmsz8bGaG/4lICn3VN7VYynUR+IkFcWY8HujtsAzyPV32VjiaJXjrOuCX5VMeK4NIF Bd96jjVKlIgQV+U2APL7SZKYEgEr/HGdjJn1p/QUJlA7e3zMkEq7FArP31cAsdfcPRlSSBbDa Hl23jb5m4KGpcKKWXZhJ/ezhseVdGNA9flsMV1LaRpgD+4dDW7QTLwCA02qOcahzUkXBa14sk 9+Qwieana1gc/hmq7jYsyHZhkfbp9jocM6vZO8CEeY0GhB60Lc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > So if you would like to change the if-statement: It will need a small adjustment for the shown transformation. I was also unsure if the proposal will work in a single update step. > 1. Send a patch for vxcan.c to improve the error handling flow I am going to send a second approach for this update variant. > 2. Send a separate patch for all rtnl_configure_link() callers to unify the result check > > Step 2 is optional ... and prepare yourself for more feedback ;-) I am curious on how software development aspects will evolve around desired error predicates. Which scope did you have in mind? Regards, Markus