From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A29A34B40A for ; Wed, 28 Jan 2026 09:53:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769594022; cv=none; b=hR9e5YMyMA0YumdJ/dyDsCnzxEbq62/5+XX2UdKYTJbmgYxwgsEmuvnHcNpIURSvlISuTiPWy1+vVlDkT6CPqDsYWI4WIPNp94JEkkB3s3YHIOpPwCWsXdoi1Vm6UnUoLWz2bA2gMYlry15+u8TwAZPG6wiT3O5aqPq2Z6TzC08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769594022; c=relaxed/simple; bh=m7VZ+3BHYVPIauZhjdMaB/99DtQmeJlc2TEVCSnnrHU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uh42CeUe3qJxCyyOHt97YyyRm3/FuSAyBGJB4G5qtcfa9LI5XU2PRUO5wW6mte62nDHMa2d9dhVqRDxfZjRlFumbAArQkP7+IFPMjjaFYdf76j4lnJn8jO45GY7f5zySmBA0lqlRFhoPrj2RcnUbDSuu5Y5/6pnYIHI/gHwl7rM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YVQzXd3q; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WAcs8nSP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YVQzXd3q"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WAcs8nSP" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60S91umU3879263 for ; Wed, 28 Jan 2026 09:53:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nb0VkEE35ZrWPoIyd63vuEpjD+c+2xcVOdZj3nN5YtM=; b=YVQzXd3qU+m5Rs3O 71+fMMAnVCAqlHXLH8ZtCHVjEwQYyGHWtx6umRm3XzP7fsDt8WpSwEVgrN+SZEgl YgeTJ7XAUsSTqdr3KM5Q9MBRaShyBqXjJC1fTNZ6w7dj9P+V8T5E7/Z876RAGely g5wPl5R/W5PY0K7hvsWuTr+32VqStE7/3Tb9PZP1nmimqWefYTlwOHWQ9NMkjVS3 OM850i7ee8NUDhdyA5UYrAL3G6oEulgZ6aWbuEsg9LBjPrzXtv+WKWtIXm9Hu69Y lvssS08XJYw8o86yxr/RVZz4IHf40IzJEY3rhD3N+Clg6WunMKwj3zCSwMMgoeeH 7n8zcA== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bybyv0wq4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 28 Jan 2026 09:53:39 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8946ebb51a0so2274546d6.0 for ; Wed, 28 Jan 2026 01:53:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769594019; x=1770198819; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nb0VkEE35ZrWPoIyd63vuEpjD+c+2xcVOdZj3nN5YtM=; b=WAcs8nSPXXAumFrEtX9TFfhxL/M2piY2/x2fYqTkcVVWC7gfGfFjnn1xkAQmtZohkf XqkVCBdayvawTMrTAe/85a1/8YECxAGO4oMKvl17fWnN/kR45jpBCJVLpSuk1JWX1AMx qOT636QBVARHUUnfJ/EAU5Hz6hGyRE8UuoDF98SMl7ZqQDpx/rI07BatSP9ILUY6Bt/E H1FBpMMbY4CZS8j34f3VK0Tkrnks4lB725FEcpmTlgFjh50lKOzhb23zB53EP9VrXEMr IUasPStldZ384OYrbykSV+dK9/Q1Z1lvzua51ProXdhkh8k/Z8FEtFVdJj5P/xL2Ydh6 bf8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769594019; x=1770198819; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nb0VkEE35ZrWPoIyd63vuEpjD+c+2xcVOdZj3nN5YtM=; b=gJEbfiMTOF6n5UnIOlq4aJME27OQ0176mJ4ckkElAlGay4W+jzt2fp+e22nL1e0sng EJy6hPYvW/dsq9rHJ1rEX522g05RVzRgqesaV+SaUZj85VXVX7fUMvR46I55khwAh1GC SxreIcvuIA3vlSHolaPxPVCLbgY5xmTyvPjKS+4qz6AIUkOr8yroUbOVqjNPc0XWemgN TiT04Tq2j88I2SCIxu7ZZHF2G7sNA6/w3sWroB4tvoDytf/AF7TKE6oGgJxRcUp+4Zid iGQVtBjauLFUYu+d1ZqQR9+SD8BG+CjqReuaDx8ylaOQ9A4al5j41qln4aZQPkryZd/Z 8ANg== X-Forwarded-Encrypted: i=1; AJvYcCWTjsYMSNowTW+R9G1+5eTYzhuTzlC2f+ttyDi9NDZIkOz4UN2fUN2i8gPq9/9eI1uXTsYNyY4Dz8wjLug=@vger.kernel.org X-Gm-Message-State: AOJu0Yzk0xbaU76Qs4I78pKUCvXTGvNzbxMoEq+u2EQyX9toJq0IRZcE 8u8OyUuy9XgCwKNtlGTb7fRdJpSyRQr98/gcD2UCIhgDdAJEvItljHClXkh8jAnRPx6tfSCBpzN u8KC6UR53Tb8AHf3zegCusB1WH4wDfZlnas5BrYGQG2fvBfv2RjXdrDurrEXQLjgmPoE= X-Gm-Gg: AZuq6aIolLeCtIlPvgNB/TU+sPOi0hCQFya0jaEVZ6zgrM639GttibdqTZXfV/fNYXX kk9xuMGxoZXOB121PWZoVOR9sG8NnlryS9MR2Ysa4fqF1fX3iFF6GsXSX+yeoF9TuRnt9WVpHAe o4J/ymPTq/fO1q7xLrScuTJ4Udt7giGgSujtcFUYCgHe9xsga9MBwwqtCQqDOFZfVLGHHxzdYi/ XM+wEjW2W8iPJ7EUQIDaz4vBL03fVsE7lYSCyzrAqsQ+BZ3oSng79DRBaMya14CcorcQave3bf5 O3nQDklzt9cXFaMYyisIPQdZeYFxNVlz8Xu6ls1h5fXUHeeVWEDHo+QF6nyj1sGBhIrLKCl1XLO 3bpFM9v4E56khXkGdQxxMcqjUnvD+D9Zc+2WgZvA6WViEgwlMwo8uy/J6tIfJo1bW1bM= X-Received: by 2002:a05:6214:4c43:b0:894:a22f:6882 with SMTP id 6a1803df08f44-894d7858c31mr10159416d6.3.1769594018787; Wed, 28 Jan 2026 01:53:38 -0800 (PST) X-Received: by 2002:a05:6214:4c43:b0:894:a22f:6882 with SMTP id 6a1803df08f44-894d7858c31mr10159286d6.3.1769594018378; Wed, 28 Jan 2026 01:53:38 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-658b4256a35sm1361015a12.1.2026.01.28.01.53.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jan 2026 01:53:37 -0800 (PST) Message-ID: <5a773b89-f3f8-486b-af01-3387c99e53e5@oss.qualcomm.com> Date: Wed, 28 Jan 2026 10:53:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFT 2/3] arm64: dts: qcom: glymur: Add USB related nodes To: Wesley Cheng , Abel Vesa Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Wesley Cheng , Pankaj Patil , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <20260113-dts-qcom-glymur-add-usb-support-v1-0-98d6d387df01@oss.qualcomm.com> <20260113-dts-qcom-glymur-add-usb-support-v1-2-98d6d387df01@oss.qualcomm.com> <01de4054-eebf-4ef3-ad74-c806b208a848@oss.qualcomm.com> <6lieos5uudkgynizozrmzrj5ov57frzzl65b2fpanwbhbmehot@z5uhyv4ipyet> <4632ad3a-c893-449a-b0d1-48d9c93da7e9@oss.qualcomm.com> <86dade1c-3ac4-4352-8dc8-e7acaaf21321@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <86dade1c-3ac4-4352-8dc8-e7acaaf21321@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 1Pr6IasmqrYZFqt1lJL34MHEUG-8hlE9 X-Authority-Analysis: v=2.4 cv=ZZ4Q98VA c=1 sm=1 tr=0 ts=6979dca3 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=R5tFhpBbpkMMLyjFO7oA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI4MDA4MCBTYWx0ZWRfX2PmCkMjjoX+P jU70KmC0ocyHXHOZH0vfBdZQpkMvZWvbv5CkiIodCUp6Bxka/lSRlF7FUUtAFLpZAqS7dy48EVP 5CVxe+FWkFf6y1jux9Np/0OtCkUgSe6BIDwrlQpqff+9TVyTKJQ7Q7/BRA7SHebg0FfWrBb9/Ep FQ/v3ybeOLD7VycydOVqFt2SuVRu3ZOsyahdp1omQPOx5vIFWskOPtPb7ybA72DkiD4wczoT7qY TvlyFMzvkBqyFzj6QLtq0ca8S3nj+eIIVP7I4ZO4Mofv8OtmwRR5lx31/0wxgFmc8fYCwutN/HJ CnX2NSwgomnXFYUMSLQAHD4lMFmzrOn0H17Ytu6OXt/9xgeNdYIZGi32ODwlBCIgj9+WMJ/e4Z1 mmoKpmytB8nzdgC3QjMm09g5Gs2Yu/GlhUnhaV4aItRdeFkC15TRoZlAbEPfNXYDaZw8cZue3bg kccEMqTsRbzZSMcnBVw== X-Proofpoint-ORIG-GUID: 1Pr6IasmqrYZFqt1lJL34MHEUG-8hlE9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-28_02,2026-01-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 impostorscore=0 suspectscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601280080 On 1/27/26 11:26 PM, Wesley Cheng wrote: > > > On 1/27/2026 3:46 AM, Konrad Dybcio wrote: >> On 1/27/26 12:41 PM, Abel Vesa wrote: >>> On 26-01-13 14:13:32, Konrad Dybcio wrote: >>>> On 1/13/26 1:33 PM, Abel Vesa wrote: >>>>> From: Wesley Cheng >>>>> >>>>> The Glymur USB system contains 3 USB type C ports, 1 USB multiport >>>>> controller and a USB 2.0 only controller. This encompasses 5 SS USB QMP >>>>> PHYs (3 combo and 2 uni) and 6 M31 eUSB2 PHYs. All controllers are SNPS >>>>> DWC3 based, so describe them as flattened DWC3 QCOM nodes. >>>>> >>>>> Signed-off-by: Wesley Cheng >>>>> Co-developed-by: Abel Vesa >>>>> Signed-off-by: Abel Vesa >>>>> --- >>>> >>>> [...] >>>> >>>>> +            snps,dis_u2_susphy_quirk; >>>>> +            snps,dis_enblslpm_quirk; >>>>> +            snps,dis_u3_susphy_quirk; >>>>> +            snps,usb2-lpm-disable; >>>> >>>> Other SoCs have a list that's much longer, please consult Wesley if >>>> this list is enough >>> >>> Checked with Wesley. He confirmed that this trimmed list is fine. >>> He said he dropped the rest since they are related to the power saving >>> features like USB2/3 LPM (l1 or u1/u2) and we don't seem need those. >> >> Is that to say that those erratas were fixed in this hardware? >> >> Low-power states of the link are no less than desired is possible.. >> > > I think it was misunderstood.  We should keep the same quirks as our previous targets to enable USB LPM support in certain cases. > > snps,hird-threshold = /bits/ 8 <0x0>; > snps,usb2-gadget-lpm-disable; > snps,dis-u1-entry-quirk; > snps,dis-u2-entry-quirk; > snps,is-utmi-l1-suspend; > snps,usb3_lpm_capable; > snps,has-lpm-erratum; > tx-fifo-resize; > snps,dis_u2_susphy_quirk; > snps,dis_enblslpm_quirk; > snps,usb2-lpm-disable; > > There are some questionable ones that I'm on the fence though, which we should consider removing: > snps,usb2-lpm-disable > snps,usb2-gadget-lpm-disable > > USB L1 support is routinely being verified on our devices (in host and device modes), so if its power over performance, we should consider removing the properties to disable USB L1. Does the fact that we allow L1 entry impact performance itself, or is there some room for improvement in the drivers? (esp since we're defining the HIRD threshold as well...) Wouldn't HIRD threshold be related to *U*1(/2) though? I see in the list above you decalred snps,dis-u1-entry-quirk snps,dis-u2-entry-quirk which forbid them and the threshold is set to 0, so IIUC that means entry is only allowed for devices that don't ""really"" suspend Konrad