From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B39C4C49ED7 for ; Fri, 13 Sep 2019 13:02:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 89A05206BB for ; Fri, 13 Sep 2019 13:02:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388120AbfIMNCc (ORCPT ); Fri, 13 Sep 2019 09:02:32 -0400 Received: from mx2.suse.de ([195.135.220.15]:49806 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387896AbfIMNCc (ORCPT ); Fri, 13 Sep 2019 09:02:32 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9BC84AF16; Fri, 13 Sep 2019 13:02:29 +0000 (UTC) Subject: Re: [PATCH 5/8] drm/ttm: add drm_gem_ttm_mmap() To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter , open list References: <20190913122908.784-1-kraxel@redhat.com> <20190913122908.784-6-kraxel@redhat.com> From: Thomas Zimmermann Openpgp: preference=signencrypt Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNKFRob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmNvbT7CwJQEEwEIAD4W IQRyF/usjOnPY0ShaOVoDcEdUwt6IwUCWznTtgIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgID AQIeAQIXgAAKCRBoDcEdUwt6I7D7CACBK42XW+7mCiK8ioXMEy1NzGbXC51RzGea8N83oEJS 1KVUtQxrkDxgrW/WLSl/TfqHFsJpdEFOv1XubWbleun3uKPy0e5vZCd5UjZPkeNjnqfCYTDy hVVsdOuFbtWDppJyJrThLqr9AgSFmoCNNUt1SVpYEEOLNE6C32BhlnSq21VLC+YXTgO/ZHTa YXkq54hHj63jwrcjkBSCkXLh37kHeqnl++GHpN+3R+o3w2OpwHAlvVjdKPT27v1tVkiydsFG 65Vd0n3m/ft+IOrGgxQM1C20uqKvsZGB4r3OGR50ekAybO7sjEJJ1Obl4ge/6RRqcvKz4LMb tGs85D6tPIeFzsBNBFs50uABCADGJj+DP1fk+UWOWrf4O61HTbC4Vr9QD2K4fUUHnzg2B6zU R1BPXqLGG0+lzK8kfYU/F5RjmEcClsIkAaFkg4kzKP14tvY1J5+AV3yNqcdg018HNtiyrSwI E0Yz/qm1Ot2NMZ0DdvVBg22IMsiudQ1tx9CH9mtyTbIXgACvl3PW2o9CxiHPE/bohFhwZwh/ kXYYAE51lhinQ3oFEeQZA3w4OTvxSEspiQR8dg8qJJb+YOAc5IKk6sJmmM7JfFMWSr22satM 23oQ3WvJb4RV6HTRTAIEyyZS7g2DhiytgMG60t0qdABG5KXSQW+OKlZRpuWwKWaLh3if/p/u 69dvpanbABEBAAHCwHwEGAEIACYWIQRyF/usjOnPY0ShaOVoDcEdUwt6IwUCWznS4AIbDAUJ A8JnAAAKCRBoDcEdUwt6I6X3CACJ8D+TpXBCqJE5xwog08+Dp8uBpx0T9n1wE0GQisZruACW NofYn8PTX9k4wmegDLwt7YQDdKxQ4+eTfZeLNQqWg6OCftH5Kx7sjWnJ09tOgniVdROzWJ7c VJ/i0okazncsJ+nq48UYvRGE1Swh3A4QRIyphWX4OADOBmTFl9ZYNPnh23eaC9WrNvFr7yP7 iGjMlfEW8l6Lda//EC5VpXVNza0xeae0zFNst2R9pn+bLkihwDLWxOIyifGRxTqNxoS4I1aw VhxPSVztPMSpIA/sOr/N/p6JrBLn+gui2K6mP7bGb8hF+szfArYqz3T1rv1VzUWAJf5Wre5U iNx9uqqx Message-ID: <5a79a05f-5763-201a-86e8-bb298d4fe856@suse.de> Date: Fri, 13 Sep 2019 15:02:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190913122908.784-6-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="r7A6mzK88xHtMrD6GleUoiZYdW0TXdMbH" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --r7A6mzK88xHtMrD6GleUoiZYdW0TXdMbH Content-Type: multipart/mixed; boundary="zxSGjltxhKEdh4LB9qpYhjbXfM4CinhIk"; protected-headers="v1" From: Thomas Zimmermann To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter , open list Message-ID: <5a79a05f-5763-201a-86e8-bb298d4fe856@suse.de> Subject: Re: [PATCH 5/8] drm/ttm: add drm_gem_ttm_mmap() References: <20190913122908.784-1-kraxel@redhat.com> <20190913122908.784-6-kraxel@redhat.com> In-Reply-To: <20190913122908.784-6-kraxel@redhat.com> --zxSGjltxhKEdh4LB9qpYhjbXfM4CinhIk Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 13.09.19 um 14:29 schrieb Gerd Hoffmann: > Add helper function to mmap ttm bo's using &drm_gem_object_funcs.mmap()= =2E >=20 > Note that with this code path access verification is done by > drm_gem_mmap() (which calls drm_vma_node_is_allowed(()). > The &ttm_bo_driver.verify_access() callback is is not used. >=20 > Signed-off-by: Gerd Hoffmann > --- > include/drm/drm_gem_ttm_helper.h | 2 ++ > drivers/gpu/drm/drm_gem_ttm_helper.c | 19 +++++++++++++++++++ > 2 files changed, 21 insertions(+) >=20 > diff --git a/include/drm/drm_gem_ttm_helper.h b/include/drm/drm_gem_ttm= _helper.h > index 6268f89c5a48..118cef76f84f 100644 > --- a/include/drm/drm_gem_ttm_helper.h > +++ b/include/drm/drm_gem_ttm_helper.h > @@ -15,5 +15,7 @@ > =20 > void drm_gem_ttm_print_info(struct drm_printer *p, unsigned int indent= , > const struct drm_gem_object *gem); > +int drm_gem_ttm_mmap(struct drm_gem_object *gem, > + struct vm_area_struct *vma); > =20 > #endif > diff --git a/drivers/gpu/drm/drm_gem_ttm_helper.c b/drivers/gpu/drm/drm= _gem_ttm_helper.c > index 9a4bafcf20df..34ce6cf78b35 100644 > --- a/drivers/gpu/drm/drm_gem_ttm_helper.c > +++ b/drivers/gpu/drm/drm_gem_ttm_helper.c > @@ -52,5 +52,24 @@ void drm_gem_ttm_print_info(struct drm_printer *p, u= nsigned int indent, > } > EXPORT_SYMBOL(drm_gem_ttm_print_info); > =20 > +/** > + * drm_gem_ttm_mmap() - mmap &ttm_buffer_object > + * @gem: GEM object. > + * @vma: vm area. > + * > + * This function can be used as &drm_gem_object_funcs.mmap > + * callback. > + */ > +int drm_gem_ttm_mmap(struct drm_gem_object *gem, > + struct vm_area_struct *vma) > +{ > + struct ttm_buffer_object *bo =3D drm_gem_ttm_of_gem(gem); > + > + ttm_bo_get(bo); > + ttm_bo_mmap_vma_setup(bo, vma); > + return 0; > +} This function looks like ttm_fbdev_mmap(). Can you use that instead? Best regards Thomas > +EXPORT_SYMBOL(drm_gem_ttm_mmap); > + > MODULE_DESCRIPTION("DRM gem ttm helpers"); > MODULE_LICENSE("GPL"); >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany GF: Felix Imend=C3=B6rffer, Mary Higgins, Sri Rasiah HRB 21284 (AG N=C3=BCrnberg) --zxSGjltxhKEdh4LB9qpYhjbXfM4CinhIk-- --r7A6mzK88xHtMrD6GleUoiZYdW0TXdMbH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAl17k2EACgkQaA3BHVML eiMm6wf/bhqpBDkcEtT0pJM60Ozya8mBpHEpStnL2vPMCYWX8gqkygxhiaT0bjy1 EHb3axf107liHAyP/Lu7CSkejUuLbsMndfSUINvHPyj39GkeKKExjK3I4+Blsank 6UbPsWZqY9DSj6FVVrD+0bFweu7xSAJjxzLivfU5s0AfGi7cAssw+BC1TIljAkXM czMlf5EI2gz01r9tk8Ih2BJdh/CzvExIq+tGWbl9K73ggFPd3LeDy0lA5JmmhnJp iRhSwmD1qyChng+zF3cLV1vQXqeEQsBFktpNOw6SRPqWJJzna00znhDM4b34r9tc kMEU+Vu3Tn6Yhx+PP8o7YKuXPk40EQ== =F607 -----END PGP SIGNATURE----- --r7A6mzK88xHtMrD6GleUoiZYdW0TXdMbH--