From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A7A430AACB for ; Fri, 27 Mar 2026 16:06:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.19 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774627621; cv=fail; b=soWMKkXv1XfMyUqE716ZQANAXuugqCTo+snsIKP9v9jjlMus4ckuRP0H80m1R/DK5QZ7Lgeiget4275bBOmzbqoIPxUX32C6sAJt2/TDz1VXEX52FSQSsdCfHqO8eCE9k5xUFzzvEPh57S5Xy5MrIMCQ4+Ti+l+6TakUJy8gdGA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774627621; c=relaxed/simple; bh=97dHFZlfzFoIpvRkQo1OZocHcJ1rYtDa7Gpmh1YNi1o=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=lQlY7Qo/C1R5qcIkGAdfRnvwc65ZVl/JqcEjqYQwrUTmrWv9INnwQtGtYY+oeYAfwVqrxQDUjZ4Cd0r80HUJNTaKJGCujsAho05xQnoZZ/N0qSo6IQSw4uQSwRa1/uDKV4JeRVhfgG04PfuQ2YjDQvrOee1qkHszGrjtgoh05rI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=P3wgPAko; arc=fail smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="P3wgPAko" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774627620; x=1806163620; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=97dHFZlfzFoIpvRkQo1OZocHcJ1rYtDa7Gpmh1YNi1o=; b=P3wgPAkoaBNbTcDeo3YXwlS1FhEiWg0oI3YK3ao+5QABXgevc0Uvl14S M18WRNw9++E5JB8gJ9TLMr0X9aPKkv0V/h9AtYE5KZFLTevkq+H0bx+cg 30WZuWCOYCxiMWub56gMw0zXhIpH77LdqFXPfeLQk6bbglnKg5OSPwq/x s70WlESBRvlxvSZYMa6Bv5ixWOgO5SXK7BYNN2z2TZOvPlek730Z9eATf nYg1FNavoRGr/Wf9Uohn2xpWZRvXFIswLaIbTwMBMRqhPjZ1R/zswOWB4 VIRZ3RF5Ym3n0YO3hfE3rj0bHy26EiPu92ILbvHTGS6yAeWxOwKUaz5gf Q==; X-CSE-ConnectionGUID: CEcYpUUjQwGP2csEdumhfQ== X-CSE-MsgGUID: OSTOBtTiTAaleEDo46ejtQ== X-IronPort-AV: E=McAfee;i="6800,10657,11741"; a="74734503" X-IronPort-AV: E=Sophos;i="6.23,144,1770624000"; d="scan'208";a="74734503" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2026 09:06:52 -0700 X-CSE-ConnectionGUID: 6OdpYaFgQDKn9RXqYpLY/g== X-CSE-MsgGUID: ac7C+RQXS0uq58vWUS/hEQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,144,1770624000"; d="scan'208";a="222481274" Received: from orsmsx902.amr.corp.intel.com ([10.22.229.24]) by fmviesa008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2026 09:06:51 -0700 Received: from ORSMSX903.amr.corp.intel.com (10.22.229.25) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 27 Mar 2026 09:06:50 -0700 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Fri, 27 Mar 2026 09:06:50 -0700 Received: from PH0PR06CU001.outbound.protection.outlook.com (40.107.208.53) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 27 Mar 2026 09:06:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WmylQt1U9ItXLE195ROXdZV6nPqXG3NznjlXPePUdUbkYTdK/m9PrwVKa3cvATubLvyN96xKzwy+LmUS5FpjvFzHxtVod1L4GveLLiVutpHpBjlmJ0yEQvQpeJY8GT8CDrYy+Cdat2siPDoqJt/u7yWyiQh4XuBAtE4jbTFbeLFk6XwaClMLVOOkJoMfRB1rLlyH7cQmjue4B1vZfqQJN4HotZDgR9R2foKizN9FNJxKTRlLp0/29Tp5wR0Hv1lihS7+o4hnDaWXqd4cRJPaUI+T8/gzmrgD6sps5wf/fvycxMqkoSZUGI9zejGrhBWuktlzP0LF0la90c54qISuKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HnHP/+XU/PLP2vO0yj/LYt2nXThWjPEDgzEo/ZN1uqs=; b=HKOaoGQ74h3SfVd2rpRzQgUf7YCRWs+3nuTMN0bNmdz8Zh5b5fCcp7qNv5xiE33wQHSLGlNysOmINiMXG4cEnv3/BtyuddUyu5b4QltZAxXsDPyf1jlZpezRfsVrOxf7RZ3N4nJ5DMszCiJm0olOXqIhrIXEZEAAxGTj5HyHbMfTK0G/1kTPlfDzr3AOq/1XJCa3JmlEqBFjOy1W+ffvbQQGlPWpVYL19ynJis/bLXYacs6A6d6erx1Dufcy5B/UBDIadtT9VjFPGeSyxivhcl3Zhzrm3qEw0XjVc+eCZX+mVOJHy8eRt/i/zEK0mI1BKR1HRgO02GsIwxvmNs3ong== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ2PR11MB7573.namprd11.prod.outlook.com (2603:10b6:a03:4d2::10) by SJ5PPF09F392AFF.namprd11.prod.outlook.com (2603:10b6:a0f:fc02::808) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.7; Fri, 27 Mar 2026 16:06:46 +0000 Received: from SJ2PR11MB7573.namprd11.prod.outlook.com ([fe80::bfe:4ce1:556:4a9d]) by SJ2PR11MB7573.namprd11.prod.outlook.com ([fe80::bfe:4ce1:556:4a9d%5]) with mapi id 15.20.9769.006; Fri, 27 Mar 2026 16:06:42 +0000 Message-ID: <5a7db7ad-17d1-45b5-97de-14433a30c0b2@intel.com> Date: Fri, 27 Mar 2026 09:06:07 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/7] fs/resctrl: Tidy up the error path in resctrl_mkdir_event_configs() To: Ben Horgan , CC: , , , , , , , , , , , References: <20260326172551.1553871-1-ben.horgan@arm.com> <20260326172551.1553871-2-ben.horgan@arm.com> From: Reinette Chatre Content-Language: en-US In-Reply-To: <20260326172551.1553871-2-ben.horgan@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR04CA0379.namprd04.prod.outlook.com (2603:10b6:303:81::24) To SJ2PR11MB7573.namprd11.prod.outlook.com (2603:10b6:a03:4d2::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR11MB7573:EE_|SJ5PPF09F392AFF:EE_ X-MS-Office365-Filtering-Correlation-Id: 1d793376-cb12-4d53-8911-08de8c1ad634 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: XfXyqQHQKuVLkGUjyRc06NRVS7UK7Gxr7gPc+rRk0a/rqbeEc8fEmk6kP0pOcH6qjFkUK1osw7FENce+5T8vM9R/psDTO/kTkrOXxyVjCurFOQc0Z3Bcx/lHCPiga28O1i17DIETpMCtnKkThktdjKeI2aLO52j2MFdWIvQ/jjhJklqnHhx/flLhqh+3At29uKLQRotj1KGbaIRXXYOb037UUi5U5vrcx7zIrMo3Ryw1z/aYH7qSfg8XYcXj0UeM4LuDCSqMIO65VnM0u0wAEInAVGgBWnZ541ZrftU7ZaqpyE4pcRJJKMy8NCvW1U/4KLIA55HsfgnSQ5Cz7RhGWISKegDmla9KI+TaLQfXJONlynNq+9qFsAK8b6TbJG39blfNU1blqmYpibXa3SZughg9bobAet6IwqreHMvAlTNvOUkGYwuB8Lvagx6vlqNpTFWJ2Bfram8QLuoGKekFrK2SOXs5URImfp14Wso/q2mEXEDTxjNKSL0+S+U1Km9v5hhGVEIsefCYFunyts3TKyoaiXAsaLe8QyF2aCo7JelQvgYSqsoF/BlO6hUE+1wW3zGaOXeeGWuSv4LMQODBgdJs5AuY8GbcNN2rIL94rgd+czFyWVsiwLAX6YI6J1yLdzM8U1WXJrmDVpy0ffKjPhzKsP8jF1RrScBmoEpoKRh60/gywayONrqValjO3kP5QcO5dnJA8GqNlKgYBuYAkZYeOP9usq68vP/OEl9b6Ng= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB7573.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVpnZkxhbkI5WEs4TkhhMVk1QXE4TEc3cHBVNFZhQldzVlVNK3R1Qjk5VWx5?= =?utf-8?B?Z3NsYVZCMGR1d1ducTVmZkpwL3hjSFErMG15Zm1xNURLd2w4dERaYy9VZkRh?= =?utf-8?B?aXZKbFNOVTBiMzRYcVpUUjI1V0c2cFYrZm8yUGhGRVU3NTFDYTVrZ1dQT1Ra?= =?utf-8?B?dlVPTjArZGNHQ3JxMExhYVVmOVhHajRzLzhhMXVhd1VDaFI2dEFNd1BxYkZj?= =?utf-8?B?WEdMK1F5TEw0VFU1SWJBQUdOVklMSWdPdzFabnFqWGRmWU1ObjBpS1FaMzVU?= =?utf-8?B?bUtiWUxRQVVUNTFLWjMzTTFlOXZkc0h3NjVjU0N4WGQrU3FxbUk5eFQrTjBy?= =?utf-8?B?MXRJekdWQi9XYUduYnFMSnlLY2hOejdyZnpVcmRVWEY3VUdOcENzYWtXVUNu?= =?utf-8?B?dkNOWGFHTkcvTW5GZS9TZjdiUVYvbnc1bGxrT3lSelhzbTBZOG1aaVBtTEEv?= =?utf-8?B?a3MwSlZJb2x5ZHhFQkU1SDNCRzcyODVIcVpOVmVTSHA4KzlaM2NheGs1dno3?= =?utf-8?B?UzVoVEdUSlpGbTIvZlhuQ0pCTkhZUEUrd1lmOTJXTTN1R2ZBVDRoSFJkbUVM?= =?utf-8?B?dVFqT09oYlUzeHRENHpWeU92dUl2QWpWcmxpWWRkY3NoUFRLOWkxRlZQbEU2?= =?utf-8?B?WGdtUTB1Y3hDRFJCanI1WHdRWUhXbkZremY5TlIzdDBhOEV6ajI4a2p2bDVS?= =?utf-8?B?dWFrTFpXbllBTnBKVGVNM09yZEFYQ2x2Q3JaKzM0Ri82bGFLbUt6bHk4cnJu?= =?utf-8?B?cWlVYS9IY0FSRVM0eEVyV3VTSWRzRm5KMHV1Sml1MUdSS0N3eSt1bzZQZkxo?= =?utf-8?B?a2liRnp2cnZ2UmpXd0tldHJ0eGtjM0pCNGpFWjduNS9IdmJtbVMwZDhmQU5w?= =?utf-8?B?aW1hWWwrQXYxUzRJcUNNS3h4a1pYMU85OW40SVZuVVZoUEp1Qkc5RXRBKzZa?= =?utf-8?B?NmVvMjNMRk03RXVNbUoyYzEvOC9VZC9aVW1zMm9raExJUnhOS29VMHgrRTlC?= =?utf-8?B?Qm5SZnlRdDFXTGozemd5MWI4ci9ZeW0yb05TZVVkTlQ5V1hVRmhiOHVhb2Rz?= =?utf-8?B?YWYwbGVjME9YcVFXcmtvNFhGT2s3Q0xmbHh2N2d0WDY0L0xhbE5HZG1VeHVG?= =?utf-8?B?N0J3N2djNytiUG5WOTlhU3VjNzc4Z1pyRmVBck55WG5UcU0yT2ZlNEtubEtE?= =?utf-8?B?QkRIZWE5MkJQWmlXeVJhSy83VXMwUi9HVkoxM0I2Q1ZwbHRlUmNZcmVaRlVH?= =?utf-8?B?bTlKWUx5aVhubmxhbGZ0NmdHNCszaFlmZHRhd0tNQ1JUY0RZK25kVUxOZnpW?= =?utf-8?B?R1p6enBpY1REeDB2dU40bDBwWkN0YmVJaTNqUFpBdzl1NjhIUmNJMG1lckF3?= =?utf-8?B?dXhQOXdaVGJJUFBEWmdRWnUxek1NNGFuQ2ZwTVNzRzVKSGZoNGM0RitLTk5s?= =?utf-8?B?UmYvM0ZBcXJ5WUc3Tmd1Mm9vWDJpall3ZWJ5cFZKdWVDQmxXazRON2NmcTh4?= =?utf-8?B?dkR6VmtjcmFFOEsxN2tVR1pTcmExZUlxWjhKTmNRNHl5TUloUkRvTmNIdGlo?= =?utf-8?B?ckxoM2UzVzA2Wm9vRURZbXF6S085NEIwd2VTMU1IRmtad0lBemhLck5EREZz?= =?utf-8?B?U0UwY0h2SmUvUE9BWTRwbzZtSVl6RTNUczZsUnlQYXRHc0lRbkhXVHhabmFQ?= =?utf-8?B?YmhzQjJZT0NIOERJTUhOc3BEQ0JSbDdkTFQvb1o0Y0MzYnE3d09EQ09NVmR0?= =?utf-8?B?bTF4MmtNZW9SSWJ3TG01bTAzUjBiTTJ5cFFyTTdvTnEvcXZleTJseVpldXJL?= =?utf-8?B?OWVscnFLTElZSU01SzVRbzhadm1iN0FzVTdYcUNqZnZWNWFBS0Q2azlIeXJ0?= =?utf-8?B?Q3dpWXZrTVhxTWdnbUdDRi9raGJueGFIekhvbGdmbzIxbnZWM09YNDlveC9F?= =?utf-8?B?TnRCYWdtaHdwcmVDaDlNWW85b2pHRG1CdFZFTXducWdydENvYXRBNW16Si9Q?= =?utf-8?B?K1ZmVTdxVElYbEh2c0pWQk55NkFwQzZLaEYwVUN4d0VLSDRCR0pkTDZNc00w?= =?utf-8?B?NndvYmhxVTVNemVXKzZTOE43UjFlUURnSExZcU92cUhRdlZRcllyc0E3UFdO?= =?utf-8?B?c2lWcnNEclFzbGRZSmRaTmVETHFrSEVLbTBQeDVHWWExODRTRk9mSndJN1Jn?= =?utf-8?B?TjJNeGxLSmdOVWFCWHZBNEMxZVB0bENhUFFabEx0Z1crWEdTd1haemxycUto?= =?utf-8?B?QkJxWElIQXBzSXVPMG50eUVYZ3JDK0hjUk4rS3hXUDlDdlZDYzd6UHF4WDN1?= =?utf-8?B?NDhncEREOXExVEQwNnBzR1plVVBxZlQrd2JyKzhLVGw0dU1reFJNTWVuclFv?= =?utf-8?Q?9unADd4IL2pYMZDs=3D?= X-Exchange-RoutingPolicyChecked: AsOqxo2vioZzeE9IszvB2lxhAmakORX0Z7bLwX+DwwTnKeSp7tDUKon7Y3qAiALRfZebjXd+v2Dkac5yq2/+abP9dHMFbdNZkfR0WfEnUykxMVm/vkH7yNc5sFbKNg4P3cuoTGsWUX3AMR8J2K9O66fCqlZke65kO7n1p29WTdmwLTqp8ezOob0iaH9JmfBIAniat+5028+D8sKKdBsOw8rOa9kkRt8SEf7gygq6PuJqRGRq89PZYCjab9LpyRRlBLBGQxrgAbp4OIajovOKu05lsgoipWf5wkLkK0KidGNOAWS2eGxber7Tad4ycBSlvrXHXF6sPUdsp4ZNd9AUVA== X-MS-Exchange-CrossTenant-Network-Message-Id: 1d793376-cb12-4d53-8911-08de8c1ad634 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2026 16:06:42.6735 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5a+fiVIXaQ4kADuKxOh/c8Xy+5sU6vM4lYkzXxynG9cT99ZKSk+zR6Vwj4+rdNi5fQwc+l0rm8GCAp+PA4LJp4r+pZpWc8IxzBbyVghZ2RA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ5PPF09F392AFF X-OriginatorOrg: intel.com Hi Ben, On 3/26/26 10:25 AM, Ben Horgan wrote: > The error path in resctrl_mkdir_event_configs() is unnecessarily > complicated. Simplify it to just return directly on error. > > Signed-off-by: Ben Horgan > --- Reviewed-by: Reinette Chatre Reinette