From: David Hildenbrand <david@redhat.com>
To: winterver <295107659@qq.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Remove 'return;' at the end of void cma_activate_area()
Date: Tue, 19 Nov 2024 13:59:25 +0100 [thread overview]
Message-ID: <5a83683b-9e7e-4583-bc47-2a008b9d3c87@redhat.com> (raw)
In-Reply-To: <tencent_E213136E4B8D60D984B3095D9C2E2F0FD107@qq.com>
On 19.11.24 12:59, winterver wrote:
> From: Jiale Yang <295107659@qq.com>
>
> Remove 'return;' at the end of void cma_activate_area(). It's a void
> function, so an ending return statement is unnecessary.
>
> Signed-off-by: Jiale Yang <295107659@qq.com>
> ---
> mm/cma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/cma.c b/mm/cma.c
> index 2d9fae939..070399bce 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -135,7 +135,6 @@ static void __init cma_activate_area(struct cma *cma)
> totalcma_pages -= cma->count;
> cma->count = 0;
> pr_err("CMA area %s could not be activated\n", cma->name);
> - return;
> }
>
> static int __init cma_init_reserved_areas(void)
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-11-19 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 11:59 winterver
2024-11-19 12:59 ` David Hildenbrand [this message]
2024-11-19 19:13 ` SeongJae Park
2024-11-20 4:39 ` Pintu Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a83683b-9e7e-4583-bc47-2a008b9d3c87@redhat.com \
--to=david@redhat.com \
--cc=295107659@qq.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®