From: SF Markus Elfring <elfring@users.sourceforge.net>
To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Colin Ian King" <colin.king@canonical.com>,
"David Airlie" <airlied@linux.ie>,
"Eric Huang" <JinHuiEric.Huang@amd.com>,
"Evan Quan" <evan.quan@amd.com>,
"Hawking Zhang" <Hawking.Zhang@amd.com>,
"Himanshu Jha" <himanshujha199640@gmail.com>,
"Junwei Zhang" <Jerry.Zhang@amd.com>, "Rex Zhu" <Rex.Zhu@amd.com>,
"Tom St Denis" <tom.stdenis@amd.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 3/3] drm/amd/powerplay/hwmgr: Delete an unnecessary return statement in three functions
Date: Thu, 8 Feb 2018 21:46:40 +0100 [thread overview]
Message-ID: <5a8388c9-7d55-0e15-5d36-c3057c4b2945@users.sourceforge.net> (raw)
In-Reply-To: <1e5850db-c07f-add1-919a-be29be9c553d@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 8 Feb 2018 21:10:58 +0100
The script "checkpatch.pl" pointed information out like the following.
WARNING: void function return statements are not generally useful
Thus remove such a statement in the affected functions.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 3 ---
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 1 -
2 files changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
index 2681c9317d25..e07b32491092 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
@@ -653,8 +653,6 @@ void phm_trim_voltage_table_to_fit_state_table(uint32_t max_vol_steps,
vol_table->entries[i] = vol_table->entries[i + diff];
vol_table->count = max_vol_steps;
-
- return;
}
int phm_reset_single_dpm_table(void *table,
@@ -906,7 +904,6 @@ void hwmgr_init_default_caps(struct pp_hwmgr *hwmgr)
phm_cap_set(hwmgr->platform_descriptor.platformCaps,
PHM_PlatformCaps_FanSpeedInTableIsRPM);
- return;
}
int hwmgr_set_user_specify_caps(struct pp_hwmgr *hwmgr)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
index 2d55dabc77d4..fcdb3563d860 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
@@ -3618,7 +3618,6 @@ static uint32_t vega10_find_highest_dpm_level(
static void vega10_apply_dal_minimum_voltage_request(
struct pp_hwmgr *hwmgr)
{
- return;
}
static int vega10_get_soc_index_for_max_uclk(struct pp_hwmgr *hwmgr)
--
2.16.1
prev parent reply other threads:[~2018-02-08 20:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 20:42 [PATCH 0/3] drm/amd/powerplay/hwmgr: Adjustments for eight function implementations SF Markus Elfring
2018-02-08 20:43 ` [PATCH 1/3] drm/amd/powerplay/hwmgr: Delete an error message for a failed memory allocation in three functions SF Markus Elfring
2018-02-08 20:45 ` [PATCH 2/3] drm/amd/powerplay/hwmgr: Adjust layout for source code from five if statements SF Markus Elfring
2018-02-08 20:46 ` SF Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a8388c9-7d55-0e15-5d36-c3057c4b2945@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=Hawking.Zhang@amd.com \
--cc=Jerry.Zhang@amd.com \
--cc=JinHuiEric.Huang@amd.com \
--cc=Rex.Zhu@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=colin.king@canonical.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=evan.quan@amd.com \
--cc=himanshujha199640@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.stdenis@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®