From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08DC93537E9 for ; Sun, 3 May 2026 02:23:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777775025; cv=none; b=m9WeVv+dRzvYs4rbiY011fr/atx5XCKkAlSCZLkwhMYSOurPQxJrqBVB+0ajwwQ52vtyG0PIhHuVdgNdt1sbF47erY2DYLKGdlgEe/MwW9WzeYgx4FhcXfZkOiN24BgVm2OOPceiy4XjXn0eta7qvZ9pDerAa2spUURc8Y/kVQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777775025; c=relaxed/simple; bh=Lg5HT63X6f+bfQfEb0j4Ta/UIv9kP8NkdsygInHEr8Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=J/nadkK7t/beR5K3jUbtkHf+9c+iGm8XJdKtmE8gXccG61U60zz31+Rm8mU8D1euopoKQF32DXZ2GMNfqJm85w/pn9rYghYWL4ajVQLx2WrviSnPUOL2h0by7Vf/6kSf7zsDWcvgXuOvybQLNrHcJuqngIM0Ps+bPJ+O6WvNQWw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=ji7vaJUN; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="ji7vaJUN" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-8ef0ba61d46so344698385a.2 for ; Sat, 02 May 2026 19:23:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1777775021; x=1778379821; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6zleKM47mpduavdnaP2aBKf2rkXt6X2UG0Frna4ddag=; b=ji7vaJUNx8YA6RVhs3aqpTb63SpMMMPLRla8X/V3s+XeLyYphjnM0adNDT4UxthXTp MkUCfvMy5fLLgih1UjEJIxq76rmjCuA9grdaqcDs7TQjRziaGIwlXlw9S3NYoW1JbYUN WboMLBGy2zgG//HYSPoxzK/g8ZtbiegETnLHiaSFBKmCoCV4coD+n1ZD90NmRy2m9YSD P3v4YAd9CLAK5Yh9Cev86ckiGQSc0Rih+vHaZADNpEFMBlVDNchsh9KUPTW9iXbY3ujy yUVjoFhENNpwjeUUvmdSbj2Pu/R5ZQYlR2PZCx61FNTyX2sydH+RkzppPyF01a4eWOmO F68Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777775021; x=1778379821; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6zleKM47mpduavdnaP2aBKf2rkXt6X2UG0Frna4ddag=; b=Dos0QnqDtKfkZS+RoDgEz3kzgSI6JTSD58ig72Q7xm1pIGALTsURfz43nlxnOODZzE pnRuWj1BMdg31LO/G0Eu+HbgvKXQG0OLky/JseO71ObM+IIP6OhRw+ub1qxQAmGJHNPs /WTGQVBrWNpqG9ZzR7WmvWKafz4k5+kwhrjrLDWb4tdjUbpkQtAIbhuVuJt2ITYUaTDn /8Jm2kZjJnfr3oEyH3QuPAMuAK3vMVwsBg7IBAuOP+Qaz7nGzwv1+++AwshgRv1p7ws/ IzZbKq80Wi6dfUHcGByU2uXj0NP9oFgp9RSYAS4Qb7QfcQImC2ejpuNODzwzoTDboCCf lJ/w== X-Forwarded-Encrypted: i=1; AFNElJ/jI2veNpH09FxPVMzP4ajrZYKuDeHDNS31q/2DFbkPyYl+JyyEnu1jeUCPsCqgFX92nmSJ6mHsQraJPPU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+cCnBbTrES4dtyhJDWMKxJCrGTdQ+3Z5SnY90si1Oi8Oonhb5 2rcrkbouadzfEJVGdykDF5+ExZyKR71VdwSlTUqF1AITRFj1ugFyl89Ofm1H6M0yqYY= X-Gm-Gg: AeBDies6eQC/FLbsKue0LdLr3lgS/hCN3edKe6sWlPDhJ/MTuugr3/501YXei0F4NaG XBBV/RPOz++5+XCt1PDJ997q/5cs3NJB0faX3qfL2eDk+RC0nxaEiIW0ADlB2uouHie1E/BOuwq lwkHqMjmfHAbA3Q6RK7wORMTob6Xr/vo2H86/f116s50WVDp9AItkm06U4iQZrC4IhHmEWv0bnM bWk7VlSNgvPIBZq7Nk8goY19oto+SYi13yGzDs7rzENqsCA55yU44pm9xkhD1BmaJQkbIEOgXX7 w+d3NZYGIKUM7jSDmUK0NEYRR+L4H6CwMefkls+1eIdp7jPCROgRQ1V85M/OFRbYXWHUTHZeZz6 DF26OdpMFR0pcRLAaFeYC+OkA1lxK2omnX97hhregFkOO4mUI47MwnjKTzSvcNa3gkr0i/RLMPi DNOauCI1erudblYE9qFznRHnYrtgkP8SBtcThJ53uG+8HaOifNKbxB2a6IfcwDAywOJEqzbqG1q Q== X-Received: by 2002:a05:620a:2a0f:b0:8cf:e946:bb56 with SMTP id af79cd13be357-8fd1833a52fmr796002985a.44.1777775021562; Sat, 02 May 2026 19:23:41 -0700 (PDT) Received: from [172.22.22.28] (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8fc2c349572sm652634685a.28.2026.05.02.19.23.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 May 2026 19:23:41 -0700 (PDT) Message-ID: <5a8cde2d-2871-4f9a-be16-66c38005fd9e@riscstar.com> Date: Sat, 2 May 2026 21:23:37 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 11/12] misc: tc956x_pci: add TC956x/QPS615 support To: Jakub Kicinski Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, maxime.chevallier@bootlin.com, rmk+kernel@armlinux.org.uk, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, daniel@riscstar.com, mohd.anwar@oss.qualcomm.com, a0987203069@gmail.com, alexandre.torgue@foss.st.com, ast@kernel.org, boon.khai.ng@altera.com, chenchuangyu@xiaomi.com, chenhuacai@kernel.org, daniel@iogearbox.net, hawk@kernel.org, hkallweit1@gmail.com, inochiama@gmail.com, john.fastabend@gmail.com, julianbraha@gmail.com, livelycarpet87@gmail.com, matthew.gerlach@altera.com, mcoquelin.stm32@gmail.com, me@ziyao.cc, prabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com, rohan.g.thomas@altera.com, sdf@fomichev.me, siyanteng@cqsoftware.com.cn, weishangjuan@eswincomputing.com, wens@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260501155421.3329862-1-elder@riscstar.com> <20260501155421.3329862-12-elder@riscstar.com> <20260502094559.15c3f479@kernel.org> <649428a4-9505-4a1a-bbbe-bd90be9b8155@riscstar.com> <20260502191427.34048082@kernel.org> Content-Language: en-US From: Alex Elder In-Reply-To: <20260502191427.34048082@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/2/26 9:14 PM, Jakub Kicinski wrote: > On Sat, 2 May 2026 21:06:33 -0500 Alex Elder wrote: >>> drivers/misc/tc956x_pci.c:541:17: error: call to undeclared function 'u32_get_bits'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] >>> 541 | chip->rev_id = u32_get_bits(val, NCID_REV_ID_MASK); >>> | ^ >> >> Yeah I think I noticed an error like that shows up with 32-bit builds? >> In any case we didn't see it during development, and we'll make sure >> gets included. > > on x86 it hits on all configs, I suspected you're building for ARM? Yes. I'll spend a little more time trying to build on other architectures. I normally like to add COMPILE_TEST. -Alex