From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F30488634C for ; Tue, 30 Dec 2025 12:46:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767098774; cv=none; b=RUpcBNluN4qaH/ZOY2injSDe4NU+ppaofZEjwTFFCLAQivMoBX4IWFJ8raWYMXw79LR4kEUycwaKcf86x/ZAb/9lHuY5UWY2edSA9gUZnmmctnbjrjp9POzNZYrNVDLG0eSwMLS5ZhbmUSDWtgZz1tbhEcUDvlrHJar/MxqLvK0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767098774; c=relaxed/simple; bh=QMzuX3iH/0w2GKT6Or3AhabnbhPjAvfRoLIsCGLS8qU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t4u96CGHu4b06itk0byPhbEOMWvzBU4to0vHt+027jiWsraQ/+EC3R3JtN8RUaAkDlOz5w8QL7hgxP9lO32zvKgb5iLgzWKhS525Z0fH4Yo27qQhOFGUm9fFVLLiRtPsRUMJp4z4TB/6Q9WDRjFdjlvFhn1voJOExpUFBLlXK6k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mkiOg2kz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Jo/9aDuJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mkiOg2kz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Jo/9aDuJ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BUAoMwi956302 for ; Tue, 30 Dec 2025 12:46:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Z4DLs7ni7DP5kDXUGhlfKo0VbVTw1jbGtRlgCaFmH3k=; b=mkiOg2kzl/+36J+3 cpo6f70zfyrbkJLeTzl8GjOA/2xe7QnYWdI17LimeqAw9VOzGJO8GLiRRW5AB7DI 5a+xXZyuY1UwYHIqf0cdJcN1aK0OKeHW06Fonem/eA9ADQrvrZKeSm80lymW1a5E kXJu07zA4xtpKGRPn8X6EQfMhlU3Oku0FbgGyCIDx3QC/LFONBYQihZdg75PXr+W IicLEkPg6TELLNjOlGpQLORouUspZm0bRO78cVdoUyw1ufKcW7MD0auwiY/nBDF7 mc5BPMO0qswv0KszNxsOACTHvnfqHiDGrrjx/UZrXJqsQXnaJGbnKWGA2tuUv7ek 3P/NWQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bbqk1b5k0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Dec 2025 12:46:12 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-7d481452732so18864104b3a.1 for ; Tue, 30 Dec 2025 04:46:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767098772; x=1767703572; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Z4DLs7ni7DP5kDXUGhlfKo0VbVTw1jbGtRlgCaFmH3k=; b=Jo/9aDuJ9FlSBUpwRJntE4zJ/9LEWcoqQ9rnvipD2WXbC7Yfh05rL5Tw/dOl2sFbdw Jw/3zlMHUZEpPftWW62eZFzs4z1WkkI4K1y9D/ycVihftPNiC/fJ31SdjjHXWQqRRgv6 KB/H3A6tVkobvh6A5tvj8aJntQrJT2l+EPya0tgv8IIuGWJmM7cqxBBTBnzI3W38rH2J oBvgMl6fYBCkMdBFkWpasXk9rIBvXST6is42sh+QlUE9sknfVFehN/5f5sROB9T+IyUk w3G2Fb+a1PB7nNaAtmcuDtBorA7nyUQ1szIucNl9h8jx71BxfgIC0Efa5CThFvxNG8dQ 7OoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767098772; x=1767703572; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z4DLs7ni7DP5kDXUGhlfKo0VbVTw1jbGtRlgCaFmH3k=; b=dr2sMt+dDG97Qc8WZbDA2mrTG85q7BZ711HbJnPvfZqB1w1zmDNlAU6yLl4227guLW g9sIP4X+cmWyZmGW59xlm1PVXIgYIVJLfOmFxouv1NZeEULF/+uLPbI7F19ue48dd99j SD4f944JlJVSVieP6EgfrqzcQDrhqrpccD+n90eExn9BGv7OQm0RyFZnX9hwYvvMnUw7 RR3q3VLp+tWPrmNZENIIzK2Xyyq4HFXKNuLkF/2ynXvuxA47Wo+plOoQXohKf/ghgqMv hs3fSx3N7LXWeUCs8QWJIlckmIiH6hvCjlfy9nKaMDC2gJBJ8gOYPnLItfQOpMLEly7Y QHvQ== X-Forwarded-Encrypted: i=1; AJvYcCUGQDC3bgQ5pVQkn48VcjBrzGSkZfk/rNDF1DQdzOSMY6JLTWr6UbTw/55D7e1ZEvR3UxNQ4x3YndRzmgs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3P2dFcjsYOi4UxzYhMcef0SVGRXynceOiSmmMYZtz0ECR+Nrb vdliLw3W9BF2VQtFP79bLxXsPiMqe39f5+ccMlFct154hRtskY/A5VGGAju1jI/8EEiKCMKvMGt imdb4ymIvwVbST8mKN+Lz2jYCpzcoo08Lt/r/y78N7pET9NGsbqlpX61xoy/uH7OTl4U= X-Gm-Gg: AY/fxX6F/MPS7NH+GWh1x/Ivp8z3LjkxE0VKNQ5xd4pxmbwXA1VgH2uDBMneRFrt8vz veeydPy/5iuTIe62ZODVZQNcxJZpspYOuGAUyzmteLDpjbvESZJU8remi0zAqjdtMgUCzMFKvyr IptzqI+7ESoZOftLA5k0BiJ6HCIN7o5bf7m0Ct7NbUR0aJ5pv3XEKzxPMYx7kDbtQQSp3XfuHfO XI0U7J0f2BCzzEzhtURbA0PoercfQvxFCpboghqI6PGaMgUhI4pmGQgGt/qXakEdsyliSUd5+/6 fH6Jf9MfU1o7o+/T697UJnDDlw3QPIIJXt5uyDnDyAIlfxXNAcUFAXrnY0ePI+1AMH/AuJ5960u DfLtkskiL1+UGNeOXXtptkTjiEqvImyNFcA== X-Received: by 2002:aa7:9318:0:b0:7e8:450c:61c5 with SMTP id d2e1a72fcca58-7ff6667cb84mr29469474b3a.53.1767098771440; Tue, 30 Dec 2025 04:46:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IFkI5Q1B5CyAklZSdJCafcyTkU7kBF5FWLKj2Rz076mFPVT+dRDRmX/HBxJLEUJtVpIcJ+aSw== X-Received: by 2002:aa7:9318:0:b0:7e8:450c:61c5 with SMTP id d2e1a72fcca58-7ff6667cb84mr29469450b3a.53.1767098770958; Tue, 30 Dec 2025 04:46:10 -0800 (PST) Received: from [10.204.104.209] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e892926sm32434249b3a.66.2025.12.30.04.46.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Dec 2025 04:46:10 -0800 (PST) Message-ID: <5a8e3805-588b-4e2b-bb84-35bdc71521fa@oss.qualcomm.com> Date: Tue, 30 Dec 2025 18:16:05 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: agatti: Fix IOMMU DT properties To: Dmitry Baryshkov , Sumit Garg Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, robin.clark@oss.qualcomm.com, lumag@kernel.org, linux-kernel@vger.kernel.org, Sumit Garg , Prakash Gupta References: <20251229071258.456254-1-sumit.garg@kernel.org> Content-Language: en-US From: Akhil P Oommen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 7xd0sKflhngoW4ekkFCWth2rbc5UXkqt X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjMwMDExNSBTYWx0ZWRfX+D2lLwCX99cM S+n13jLe1EH9zqk2kzASrpHm/QsUgM35eofxOG47cHkNZlyqqdI+FrWn2ya8yNVtzTt2EtPPn6+ qj+aj2uO+MnOLz2exYFENj/k93dritIVrJmVYS+7HSHD/oxnzRtHayy5tGxdKXt7hK6wq5OClDh 1J9yHsQeX/0oMagF58gQoCGlHdDSucRrIJ0Chcnej8+KMIB2qS/YCX9BelxZBJbapnvR2P/gNAE fw8329uLD0bjVBObSShOsuXql9yNF8pxjcxQRBgq9lkBzLzEAbCZ0NEkFlZA+yOO1Rrstc1MPVd rVCasTC4n0oq+j6ComGbhVK4Xdph79clsLcRbqn2Tsr2sd4bhAEwqEXg+4RXu0MFhxY93mM5G3H 1T0htBYYH9Lhj+HdXOGzl7u3AnfwtsJWvOZpPj6qPaVEu2OGViabw2Ao35p4ZxAhwAheTF8pPtV Y4WK9hw+dgQL8qnFj6w== X-Authority-Analysis: v=2.4 cv=Tf6bdBQh c=1 sm=1 tr=0 ts=6953c994 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=AGhfR3YMigLB4eqwYEMA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: 7xd0sKflhngoW4ekkFCWth2rbc5UXkqt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-30_01,2025-12-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 impostorscore=0 suspectscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512300115 On 12/30/2025 12:35 PM, Dmitry Baryshkov wrote: > On Tue, Dec 30, 2025 at 10:45:38AM +0530, Sumit Garg wrote: >> On Mon, Dec 29, 2025 at 10:00:02PM +0200, Dmitry Baryshkov wrote: >>> On Mon, Dec 29, 2025 at 12:42:57PM +0530, Sumit Garg wrote: >>>> From: Sumit Garg >>>> >>>> Fix IOMMU DT propeties for GPU, display and video peripherals via >>>> dropping SMMU stream IDs which relates to secure context bank. >>>> >>>> This problem only surfaced when the Gunyah based firmware stack is >>>> ported on Agatti replacing the legacy QHEE based firmware stack. Assigning >>>> Linux kernel (HLOS) VMID to secure context bank stream IDs is treated >>>> as a fault by Gunyah hypervisor which were previously ignored by QHEE >>>> hypervisor. >>> >>> We are porting the underlaying layer. Can we make it to behave in a way >>> similar to the _existing_ software? If DT was a part of the firmware, it >>> would have been fine to perform such updates. But as it is not, we >>> really should try not to break the interface boundary between firmware >>> and the kernel. >> >> I support your viewpoint. But in this current case Linux kernel VMID mapping >> for secure context bank stream IDs is incorrect. As Konrad mentioned in the >> other thread that for secure media streaming use-cases, it rather requires >> proper representation via iommu-map such that appropriate VMID can be mapped. > > Yes, I understand this part. I'm basically suggesting that Gunyah should > ignore this SID when programming the actual SMMU (probably like QHEE > did). But the existing DT description for Agatti GPU is buggy. SID 2 is for secure access from GPU and it should not be mixed with non-secure access. We haven't hit any issue so far because the KMD doesn't have support for secure usecase yet. At least for the GPU property, I feel that the right thing to do is to correct the buggy description. -Akhil > >> >>> >>> I'm fine with the change, but I think we should make sure that Gunyah >>> doesn't break existing device trees. >> >> Sure, this change isn't breaking any DT ABI but brings compliance to >> usage of stream IDs. > > Actually, it does, as you can see from Rob's email. You didn't perform > make dtbs_check while submitting this patch. >