From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57DE4C433EF for ; Thu, 30 Jun 2022 02:04:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231297AbiF3CEy (ORCPT ); Wed, 29 Jun 2022 22:04:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbiF3CEw (ORCPT ); Wed, 29 Jun 2022 22:04:52 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2045B3B571 for ; Wed, 29 Jun 2022 19:04:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 79AD7B826A8 for ; Thu, 30 Jun 2022 02:04:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EA3BC34114; Thu, 30 Jun 2022 02:04:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656554688; bh=GtdBoKOokWarrldoZgOzYh8XTSyehxtzazmyNXJqCkQ=; h=In-Reply-To:References:Date:From:To:Cc:Subject:From; b=KhGs07lKCOcrjUU6P9heOO6gYVdTcQ2eI1H5AXZ158zVRUuohGBRYgGKeHL1Ojdm6 GOjswBoP5zyW+rCnlMIlYgRoxoRd/Pk8XsP2sioMgQg4oA3zxXCy4TqwO3r8dMG7ut 3HaYatALZYJ/ve9Mj9Y/laE99036uz7XesrFK8lKL52lryZY55R8hkGKvj4b3AlvyR V33BQXKH0GxZDd/Aie6csR7tfFmr3lNlwQ3c3ytTdSATJ6lg/CEU7p+tVjt62jrAMO QkeEUeV5MD7Lg+RWpTf/GqkkuaCaWDhun2fjvZ8OWocf7FfuK7Iy/qhVhG1rtREnF/ I0YavpE19z20g== Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailauth.nyi.internal (Postfix) with ESMTP id 8161327C0054; Wed, 29 Jun 2022 22:04:46 -0400 (EDT) Received: from imap48 ([10.202.2.98]) by compute2.internal (MEProxy); Wed, 29 Jun 2022 22:04:46 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehtddgheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehn ugihucfnuhhtohhmihhrshhkihdfuceolhhuthhosehkvghrnhgvlhdrohhrgheqnecugg ftrfgrthhtvghrnhepvdfhuedvtdfhudffhfekkefftefghfeltdelgeffteehueegjeff udehgfetiefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homheprghnugihodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdduudeiudek heeifedvqddvieefudeiiedtkedqlhhuthhopeepkhgvrhhnvghlrdhorhhgsehlihhnuh igrdhluhhtohdruhhs X-ME-Proxy: Feedback-ID: ieff94742:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 1EAD331A0062; Wed, 29 Jun 2022 22:04:46 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-713-g1f035dc716-fm-20220617.001-g1f035dc7 Mime-Version: 1.0 Message-Id: <5a92ba37-69ae-477e-9747-315d41d3206e@www.fastmail.com> In-Reply-To: <20220616165413.c35yliaxbxvmwsqw@black.fi.intel.com> References: <20220610143527.22974-1-kirill.shutemov@linux.intel.com> <20220610143527.22974-7-kirill.shutemov@linux.intel.com> <20220610180635.l44opq2votd3gxpl@black.fi.intel.com> <5b56c88e477d879e5a0e3c15627cb05901a812f4.camel@intel.com> <5d3b281f-3d8b-4bbd-9681-b226810c3e8b@www.fastmail.com> <20220616165413.c35yliaxbxvmwsqw@black.fi.intel.com> Date: Wed, 29 Jun 2022 19:04:24 -0700 From: "Andy Lutomirski" To: "Kirill A. Shutemov" , "Peter Zijlstra (Intel)" Cc: "Rick P Edgecombe" , "Linux Kernel Mailing List" , "H.J. Lu" , "linux-mm@kvack.org" , "Dave Hansen" , "andreyknvl@gmail.com" , "kcc@google.com" , "Andi Kleen" , "dvyukov@google.com" , "the arch/x86 maintainers" , "ryabinin.a.a@gmail.com" , "glider@google.com" Subject: Re: [PATCHv3 6/8] x86/mm: Provide ARCH_GET_UNTAG_MASK and ARCH_ENABLE_TAGGED_ADDR Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 16, 2022, at 9:54 AM, Kirill A. Shutemov wrote: > On Thu, Jun 16, 2022 at 11:44:59AM +0200, Peter Zijlstra wrote: >> > get_nr_threads() is the wrong thing. Either look at mm->mm_users or >> > find a way to get rid of this restriction entirely. >> >> mm->mm_users should indeed be sufficient here. > > Hm. kthread_use_mm() doesn't bump mm_users. Do we care? I think the idea is that the kthread in question is expected to hold an mm_users reference. > > -- > Kirill A. Shutemov