From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44EC518DF91 for ; Fri, 25 Oct 2024 18:14:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729880066; cv=none; b=ociLn5BjHZhiH9tx5ruLGbHQGt9/LEG5jYei1uLIZlRXdps7yNtHrfGNAsOXk9l4J0t9pcNVvKuZqqrT+WAerpJllhBw67H38/RHIitY0/LuZdCpH2WSF/NMMHUKAHbfIWblQ7CgdaVGAudpPk7FpB+8Q3oosa1W6Rvgo7hAJzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729880066; c=relaxed/simple; bh=+D8EOBHbCUHNS8MlsDOj9MvEyvLWhiBdxbjFoUH3pOk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ng8p/JuZ9XVbKzsTErgueDOnNl/LfULngLEAtKbc8Poj3wNB9GTafPSkeNsiQ0nelBwtb1too2KmvS2kylxMx+4O0LNSnMBSxFFar5y4PZ3JatQARk+LoHTBUzFlhbZTDwPW8+Akrma/+rHb8kTAMBe2cscBo1PgTckTi1jlZFM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=fail smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=erk4/iaR; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="erk4/iaR" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49PAPuf4029348 for ; Fri, 25 Oct 2024 18:14:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qrmL14AEOznY4BwbvXypNlUpeH4TrifR/CEAuIy6fto=; b=erk4/iaRuHTcy+02 jGCbVFUGsnmWbbgibLC3TSXMeqNMBukwzEGnpGm7SrwSm2Nn8hVkZnPir3Z3uaYN GLTIqEV7rL8C06WcTAQPzqSCopbTjCUE8INWvRt+EtyA46/Z6Mh/1KPhBcjf4ips tzKeOV2fIM9og34eoPsvJ+yBpuYcE2bLqJEuf3i4uPhCrqpH1o+u+jIldDeCCk6w sQGZpa5c3tJKRJrkJF/nO5fI7pNBAZ7/QkSiKJJiFYqEzMLHQqzR8QE4WcvwAcCO FzW7beAUJzunVvfxGGRObKBIrF9XhLnEL25xRnaSQ0jfIwYtJJ6isr+xlBY4P0Xk VkIAIA== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42em3wa2jj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 25 Oct 2024 18:14:23 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6cbe91571easo6926846d6.0 for ; Fri, 25 Oct 2024 11:14:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729880061; x=1730484861; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qrmL14AEOznY4BwbvXypNlUpeH4TrifR/CEAuIy6fto=; b=Dg27TzWpxEb0YIX7YQmZ6qyFEkHSjNHEmXeE+5G9lb4d4kvIbYYTOCwntnwOIe0LOU /bHJKxXr7nXP6tLAR1vSYwWhkref3h/d2YfsL+VqbofmMl1XH56qRx2ndoWkPrZvUuNL uagb2TXHUut3dAa9235ThrGpLTm/px/48TwZmLdd/J1logLW1AlpWIgYwfsnA7W76lyP Fr4EBpKEXUIB8rJqCC3Apw86UpuIz1UUnE+WzkcZy7yOP8bVAHPmBqwGNNB54sJdx+R2 hwoE1KC845NEJPIoJFQCpv9TwUNhMAf+NRomV+FRkwBUlsZx3HuvocuOWLDsUamP7rhU it8w== X-Forwarded-Encrypted: i=1; AJvYcCUd08IduB59NHjkZs+kMS+CadGCoWPY7m/tw7q+MYwsjXkJtdg3KzXFNFbpgvRCFen5ni0PD6ebMhu+ils=@vger.kernel.org X-Gm-Message-State: AOJu0YzVQEvY7++JRe9DFamNTAXOCCbELL1OiJLEv6TsdK2pBXtp3euT 3TcJGU3iPVZvl3t5V/wja5QMNPDJcYnSF9YIFF09J6vNJOR1LHI23JJ3yQJEhUkMCXT+ZV1bn/8 RUNkhXFhnIpnP5KHA8joIjwdTaz3ymVt5shn+sSmc/G2oQcuvvUNmqGyKNRa75v8= X-Received: by 2002:a05:6214:1d0b:b0:6cb:e981:d7dc with SMTP id 6a1803df08f44-6d185862e6emr1909216d6.12.1729880061501; Fri, 25 Oct 2024 11:14:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEXzk3TSC3Xw8NDVKHFxS1ilkakzcOocvD+KuNE8wkBN6jCTi7n2E4Li6yt8CN+Jb53ACok5A== X-Received: by 2002:a05:6214:1d0b:b0:6cb:e981:d7dc with SMTP id 6a1803df08f44-6d185862e6emr1908896d6.12.1729880061187; Fri, 25 Oct 2024 11:14:21 -0700 (PDT) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cbb634737fsm850633a12.82.2024.10.25.11.14.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Oct 2024 11:14:20 -0700 (PDT) Message-ID: <5a98076f-f5ce-4400-b554-6593d51de9f2@oss.qualcomm.com> Date: Fri, 25 Oct 2024 20:14:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 6/8] spi: spi-qpic: add driver for QCOM SPI NAND flash Interface To: kernel test robot , Md Sadre Alam , broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Cc: oe-kbuild-all@lists.linux.dev, quic_srichara@quicinc.com, quic_varada@quicinc.com References: <20241021115620.1616617-7-quic_mdalam@quicinc.com> <202410252355.ZofaMeku-lkp@intel.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <202410252355.ZofaMeku-lkp@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: Clczut2gLO2yIFd3U9HlegJQxx67FwoS X-Proofpoint-GUID: Clczut2gLO2yIFd3U9HlegJQxx67FwoS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=999 priorityscore=1501 impostorscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 spamscore=0 malwarescore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410250139 On 25.10.2024 6:08 PM, kernel test robot wrote: > Hi Md, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on mtd/nand/next] > [also build test WARNING on broonie-spi/for-next robh/for-next linus/master v6.12-rc4 next-20241025] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Md-Sadre-Alam/spi-dt-bindings-Introduce-qcom-spi-qpic-snand/20241021-200849 > base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next > patch link: https://lore.kernel.org/r/20241021115620.1616617-7-quic_mdalam%40quicinc.com > patch subject: [PATCH v12 6/8] spi: spi-qpic: add driver for QCOM SPI NAND flash Interface > config: sparc64-randconfig-r073-20241023 (https://download.01.org/0day-ci/archive/20241025/202410252355.ZofaMeku-lkp@intel.com/config) > compiler: sparc64-linux-gcc (GCC) 14.1.0 > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202410252355.ZofaMeku-lkp@intel.com/ > > smatch warnings: > drivers/spi/spi-qpic-snand.c:1260 qcom_spi_write_page() warn: unsigned 'cmd' is never less than zero. > drivers/spi/spi-qpic-snand.c:1279 qcom_spi_send_cmdaddr() warn: unsigned 'cmd' is never less than zero. > > vim +/cmd +1260 drivers/spi/spi-qpic-snand.c > > 1252 > 1253 static int qcom_spi_write_page(struct qcom_nand_controller *snandc, > 1254 const struct spi_mem_op *op) > 1255 { > 1256 struct qpic_snand_op s_op = {}; > 1257 u32 cmd; > 1258 > 1259 cmd = qcom_spi_cmd_mapping(snandc, op->cmd.opcode); >> 1260 if (cmd < 0) > 1261 return cmd; The robot is right, qcom_spi_cmd_mapping() should return an int, as you return a negative errno upon failure Konrad