From: Marc Zyngier <marc.zyngier@arm.com>
To: Will Deacon <will.deacon@arm.com>,
Anders Roxell <anders.roxell@linaro.org>
Cc: mark.rutland@arm.com, catalin.marinas@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com
Subject: Re: [PATCH 2/3] arm64: arch_timer: mark functions as __always_inline
Date: Wed, 5 Jun 2019 13:23:15 +0100 [thread overview]
Message-ID: <5a9fd23f-1a4e-874a-7583-8760f5786edf@arm.com> (raw)
In-Reply-To: <20190605115644.GF15030@fuggles.cambridge.arm.com>
On 05/06/2019 12:56, Will Deacon wrote:
> On Mon, Jun 03, 2019 at 11:14:02AM +0200, Anders Roxell wrote:
>> If CONFIG_FUNCTION_GRAPH_TRACER is enabled function
>> arch_counter_get_cntvct() is marked as notrace. However, function
>> __arch_counter_get_cntvct is marked as inline. If
>> CONFIG_OPTIMIZE_INLINING is set that will make the two functions
>> tracable which they shouldn't.
>>
>> Rework so that functions __arch_counter_get_* are marked with
>> __always_inline so they will be inlined even if CONFIG_OPTIMIZE_INLINING
>> is turned on.
>>
>> Fixes: 0ea415390cd3 ("clocksource/arm_arch_timer: Use arch_timer_read_counter to access stable counters")
>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>> ---
>> arch/arm64/include/asm/arch_timer.h | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> I can pick this up if Marc is happy with it.
Yup, looks good to me. Please add my
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
prev parent reply other threads:[~2019-06-05 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 9:14 Anders Roxell
2019-06-05 11:56 ` Will Deacon
2019-06-05 12:23 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a9fd23f-1a4e-874a-7583-8760f5786edf@arm.com \
--to=marc.zyngier@arm.com \
--cc=anders.roxell@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®