From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80636C001B2 for ; Thu, 8 Dec 2022 23:42:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230375AbiLHXl4 (ORCPT ); Thu, 8 Dec 2022 18:41:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230333AbiLHXld (ORCPT ); Thu, 8 Dec 2022 18:41:33 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AC1B94190; Thu, 8 Dec 2022 15:39:09 -0800 (PST) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B8NLbDG023958; Thu, 8 Dec 2022 23:38:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=vfVMr5PVP/PyqxS//lgn3F/cfbT5Kuc8CzRnXxY5PS0=; b=TUSZ9voDSZ6NkZOZsEKGJ9bpiCPoTu19KZWePiIZpru2+2twRiGCdmzDF3a/wArkDLOv CcySBYdwCgo5mNRlWSowL3eNz5JHKj3ZDDoSuM9tXR7D4gqj+djrr1zjMbmMBUCMBHJm oJdHAzf5aOu+6E/E4WiK/itThFUWGoJN6Q3CMsjfIx5cNi1PhLEQJ2615VVjYz1F10bA 6i1UUhm1C78tpv4+lJChdGmzx03VozldJCVkfN4FZRFFAZAvFX0il27qMTsx3AJhKOXr 4edkX/r8dkdJAr+rEPiyFwxxEcq2y0ywphwYj3xGBLD7+oEo2Edyv2KC0HmNlIqgKk7c 6g== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3marj0vsja-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 Dec 2022 23:38:28 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2B8NcRkr014483 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 8 Dec 2022 23:38:27 GMT Received: from [10.110.56.119] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 8 Dec 2022 15:38:25 -0800 Message-ID: <5aa16223-dbf6-996c-1985-794302dcce91@quicinc.com> Date: Thu, 8 Dec 2022 15:38:24 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v11 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property Content-Language: en-US To: Dmitry Baryshkov , , , , , , , , , , , , , , , CC: , , , , References: <1670539015-11808-1-git-send-email-quic_khsieh@quicinc.com> <1670539015-11808-3-git-send-email-quic_khsieh@quicinc.com> <5a3865ed-8847-db04-3d60-f35438250bef@linaro.org> From: Kuogee Hsieh In-Reply-To: <5a3865ed-8847-db04-3d60-f35438250bef@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: bPBU_QrodpkJA6crWCes3nfgZo0gx-FF X-Proofpoint-GUID: bPBU_QrodpkJA6crWCes3nfgZo0gx-FF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-08_12,2022-12-08_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 lowpriorityscore=0 mlxscore=0 clxscore=1015 bulkscore=0 impostorscore=0 priorityscore=1501 spamscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212080194 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/8/2022 3:33 PM, Dmitry Baryshkov wrote: > On 09/12/2022 00:36, Kuogee Hsieh wrote: >> Add both data-lanes and link-frequencies property into endpoint >> >> Changes in v7: >> -- split yaml out of dtsi patch >> -- link-frequencies from link rate to symbol rate >> -- deprecation of old data-lanes property >> >> Changes in v8: >> -- correct Bjorn mail address to kernel.org >> >> Changes in v10: >> -- add menu item to data-lanes and link-frequecnis >> >> Changes in v11: >> -- add endpoint property at port@1 >> >> Signed-off-by: Kuogee Hsieh ` > > Applying: dt-bindings: msm/dp: add data-lanes and link-frequencies > property > .git/rebase-apply/patch:47: trailing whitespace. > > .git/rebase-apply/patch:51: trailing whitespace. > > > Also the dt_binding_check fails with an error for this schema. And > after fixing the error in the schema I faced an example validation > error. Did you check that the schema is correct and that the example > validates against the schema? yes, but i run "make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/msm/dp-controller.yaml" at mu v5.15 branch since "make dt_binding_check" does not work at msm-next branch. But I did not check trainiling whitespace this time. > >> --- >>   .../bindings/display/msm/dp-controller.yaml        | 27 >> ++++++++++++++++++++++ >>   1 file changed, 27 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> index f2515af..2a7fdef8 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> @@ -81,6 +81,7 @@ properties: >>       data-lanes: >>       $ref: /schemas/types.yaml#/definitions/uint32-array >> +    deprecated: true >>       minItems: 1 >>       maxItems: 4 >>       items: >> @@ -96,6 +97,7 @@ properties: >>       ports: >>       $ref: /schemas/graph.yaml#/properties/ports >> + >>       properties: >>         port@0: >>           $ref: /schemas/graph.yaml#/properties/port >> @@ -105,6 +107,29 @@ properties: >>           $ref: /schemas/graph.yaml#/properties/port >>           description: Output endpoint of the controller >>   +        properties: >> +          endpoint: >> +            $ref: /schemas/media/video-interfaces.yaml# >> + >> +            properties: >> +              remote-endpoint: true > > PLease add empty lines between the property definitions > >> +              data-lanes: >> +                $ref: /schemas/types.yaml#/definitions/uint32-array > > This is already a part of video-interfaces, so you don't need $ref > >> +                minItems: 1 >> +                maxItems: 4 >> +                items: >> +                  maximum: 3 > > enum: [0, 1, 2, 3] > >> +              link-frequencies: >> +                $ref: /schemas/types.yaml#/definitions/uint64-array >> +                minItems: 1 >> +                maxItems: 4 >> +                items: >> +                  maximum: 8100000000 > > I think we can have enum here too. > >> + >> +  required: >> +    - port@0 >> +    - port@1 >> + >>   required: >>     - compatible >>     - reg >> @@ -193,6 +218,8 @@ examples: >>                   reg = <1>; >>                   endpoint { >>                       remote-endpoint = <&typec>; >> +                    data-lanes = <0 1>; >> +                    link-frequencies = /bits/ 64 <1620000000 >> 2700000000 5400000000 8100000000>; >>                   }; >>               }; >>           }; >