Re: [PATCH -mmotm] xpad: fix build error and warnings

[Mike Murphy <mamurph@cs.clemson.edu>]

On Thu, Mar 5, 2009 at 9:57 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Add a dummy xpad_send_led_command() for the case of
> CONFIG_JOYSTICK_XPAD_LEDS=n.  Fixes this build error:
>
> ERROR: "xpad_send_led_command" [drivers/input/joystick/xpad.ko] undefined!
>
> Remove 2 duplicate function prototypes in xpad.h.
>
> Fix these xpad.h warnings:
> drivers/input/joystick/xpad.h:231: warning: 'enum led_brightness' declared inside parameter list
> drivers/input/joystick/xpad.h:231: warning: its scope is only this definition or declaration, which is probably not what you want
> drivers/input/joystick/xpad.h:231: warning: 'struct led_classdev' declared inside parameter list
> drivers/input/joystick/xpad.h:231: warning: 'xpad_led_set' declared 'static' but never defined
>
...

Thanks Randy. I found the prototype for xpad_deinit_output to be
missing and will have a patch shortly. I will also be updating the
out-of-tree distribution of this driver version to match the current
-mm tree version:

http://cirg.cs.clemson.edu/~mamurph/pub/xpad/

Mike
-- 
Mike Murphy
Ph.D. Candidate and NSF Graduate Research Fellow
Clemson University School of Computing
120 McAdams Hall
Clemson, SC 29634-0974 USA
Tel: +1 864.656.2838   Fax: +1 864.656.0145
http://cirg.cs.clemson.edu/~mamurph