From: Jon Hunter <jonathanh@nvidia.com>
To: Prathamesh Shete <pshete@nvidia.com>,
linusw@kernel.org, thierry.reding@kernel.org
Cc: linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, u.kleine-koenig@baylibre.com,
dakr@kernel.org, bhelgaas@google.com
Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: tegra264: fix DAP2 DIN/DOUT pin names
Date: Fri, 17 Jul 2026 14:24:35 +0100 [thread overview]
Message-ID: <5aabe234-6c85-472a-8be4-f6cbea7172bd@nvidia.com> (raw)
In-Reply-To: <20260717113210.599463-1-pshete@nvidia.com>
On 17/07/2026 12:32, Prathamesh Shete wrote:
> The DAP2_DIN and DAP2_DOUT pins were listed with swapped ball suffixes:
> DAP2_DIN as PV7 and DAP2_DOUT as PW0. On silicon DAP2_DIN is on ball PW0
> and DAP2_DOUT is on ball PV7. Correct the pin and drive group names to
> dap2_din_pw0 and dap2_dout_pv7.
>
> Fixes: 30a9d5162f25 ("dt-bindings: pinctrl: Document Tegra264 pin controllers")
> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> ---
> .../bindings/pinctrl/nvidia,tegra264-pinmux-main.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra264-pinmux-main.yaml b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra264-pinmux-main.yaml
> index c40409d3263c..01db762e82bc 100644
> --- a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra264-pinmux-main.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra264-pinmux-main.yaml
> @@ -44,7 +44,7 @@ patternProperties:
> soc_gpio173_pu3, soc_gpio174_pu4, soc_gpio175_pu5,
> soc_gpio176_pu6, soc_gpio177_pu7, soc_gpio178_pv0,
> pwm10_pv1, uart4_tx_pv2, uart4_rx_pv3, uart4_rts_n_pv4,
> - uart4_cts_n_pv5, dap2_clk_pv6, dap2_din_pv7, dap2_dout_pw0,
> + uart4_cts_n_pv5, dap2_clk_pv6, dap2_din_pw0, dap2_dout_pv7,
> dap2_fs_pw1, gen1_i2c_scl_pw2, gen1_i2c_sda_pw3,
> gen0_i2c_scl_pw4, gen0_i2c_sda_pw5, pwr_i2c_scl_pw6,
> pwr_i2c_sda_pw7, soc_gpio138_pp0, soc_gpio139_pp1,
> @@ -111,8 +111,8 @@ patternProperties:
> drive_soc_gpio351_ps1, drive_gen0_i2c_scl_pw4,
> drive_gen0_i2c_sda_pw5, drive_gen1_i2c_scl_pw2,
> drive_gen1_i2c_sda_pw3, drive_dap2_fs_pw1,
> - drive_dap2_clk_pv6, drive_dap2_din_pv7,
> - drive_dap2_dout_pw0, drive_pwm10_pv1,
> + drive_dap2_clk_pv6, drive_dap2_din_pw0,
> + drive_dap2_dout_pv7, drive_pwm10_pv1,
> drive_soc_gpio170_pu0, drive_soc_gpio171_pu1,
> drive_soc_gpio172_pu2, drive_soc_gpio173_pu3,
> drive_soc_gpio174_pu4, drive_soc_gpio175_pu5,
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Thanks!
Jon
--
nvpublic
prev parent reply other threads:[~2026-07-17 13:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 11:32 Prathamesh Shete
2026-07-17 11:32 ` [PATCH v2 2/2] pinctrl: tegra264: fix DAP2 DIN/DOUT pin assignment Prathamesh Shete
2026-07-17 13:24 ` Jon Hunter
2026-07-17 13:24 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5aabe234-6c85-472a-8be4-f6cbea7172bd@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=bhelgaas@google.com \
--cc=dakr@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pshete@nvidia.com \
--cc=thierry.reding@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox