From: Neil Armstrong <neil.armstrong@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 5/5] arm64: dts: qcom: sm8450: add dp controller
Date: Thu, 23 Mar 2023 15:36:17 +0100 [thread overview]
Message-ID: <5ab0601c-5acd-ef49-419b-36f5a7679758@linaro.org> (raw)
In-Reply-To: <20230323143814.cdfbgzlnlbnocx5z@ripper>
Hi,
On 23/03/2023 15:38, Bjorn Andersson wrote:
> On Tue, Mar 21, 2023 at 09:51:34PM +0100, Konrad Dybcio wrote:
>> On 17.03.2023 16:06, Neil Armstrong wrote:
>>> @@ -2783,6 +2790,78 @@ opp-500000000 {
>>> };
>>> };
>>>
>>> + mdss_dp0: displayport-controller@ae90000 {
>>> + compatible = "qcom,sm8450-dp", "qcom,sm8350-dp";
>>> + reg = <0 0xae90000 0 0x200>,
>>> + <0 0xae90200 0 0x200>,
>>> + <0 0xae90400 0 0xc00>,
>>> + <0 0xae91000 0 0x400>,
>>> + <0 0xae91400 0 0x400>;
>>> + interrupt-parent = <&mdss>;
>>> + interrupts = <12>;
>>> + clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
>>> + <&dispcc DISP_CC_MDSS_DPTX0_AUX_CLK>,
>>> + <&dispcc DISP_CC_MDSS_DPTX0_LINK_CLK>,
>>> + <&dispcc DISP_CC_MDSS_DPTX0_LINK_INTF_CLK>,
>>> + <&dispcc DISP_CC_MDSS_DPTX0_PIXEL0_CLK>;
>>> + clock-names = "core_iface",
>>> + "core_aux",
>>> + "ctrl_link",
>>> + "ctrl_link_iface",
>> I applied this locally and noticed line has 2x 8 spaces.. Bjorn, could
>> you please take care of that when applying?
>>
>
> Thanks for pointing it out. I did correct it, and I had to do the same
> in sm8350.dtsi.
>
> @Neil, please run checkpatch --strict, it will highlight these errors.
Thx, sorry... usually I don't miss such errors, won't happen again.
Neil
>
> Thanks,
> Bjorn
next prev parent reply other threads:[~2023-03-23 14:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 15:06 [PATCH v6 0/5] arm64: dts: qcom: add DP Controller to SM8350 & SM8450 DTS Neil Armstrong
2023-03-17 15:06 ` [PATCH v6 1/5] dt-bindings: display: msm: dp-controller: document SM8450 compatible Neil Armstrong
2023-03-17 15:06 ` [PATCH v6 2/5] arm64: dts: qcom: sm8350: switch to combo usb3/dp phy Neil Armstrong
2023-03-17 15:06 ` [PATCH v6 3/5] arm64: dts: qcom: sm8350: add dp controller Neil Armstrong
2023-03-17 15:06 ` [PATCH v6 4/5] arm64: dts: qcom: sm8450: switch to usb3/dp combo phy Neil Armstrong
2023-03-17 15:06 ` [PATCH v6 5/5] arm64: dts: qcom: sm8450: add dp controller Neil Armstrong
2023-03-20 11:15 ` Konrad Dybcio
2023-03-21 20:51 ` Konrad Dybcio
2023-03-23 14:38 ` Bjorn Andersson
2023-03-23 14:36 ` Neil Armstrong [this message]
2023-03-24 18:34 ` (subset) [PATCH v6 0/5] arm64: dts: qcom: add DP Controller to SM8350 & SM8450 DTS Bjorn Andersson
2023-03-28 22:37 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ab0601c-5acd-ef49-419b-36f5a7679758@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=agross@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®