From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C7E5C4167B for ; Tue, 28 Nov 2023 06:23:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343648AbjK1GXH (ORCPT ); Tue, 28 Nov 2023 01:23:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343644AbjK1GWz (ORCPT ); Tue, 28 Nov 2023 01:22:55 -0500 Received: from out30-119.freemail.mail.aliyun.com (out30-119.freemail.mail.aliyun.com [115.124.30.119]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7B4E1AE for ; Mon, 27 Nov 2023 22:23:00 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=cruzzhao@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0VxJT9eY_1701152567; Received: from 30.222.33.26(mailfrom:cruzzhao@linux.alibaba.com fp:SMTPD_---0VxJT9eY_1701152567) by smtp.aliyun-inc.com; Tue, 28 Nov 2023 14:22:58 +0800 Message-ID: <5ab76c0c-6333-4452-ae51-9193926c802c@linux.alibaba.com> Date: Tue, 28 Nov 2023 14:22:47 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] perf: ignore exited thread when synthesize thread map To: Namhyung Kim Cc: mingo@redhat.com, peterz@infradead.org, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, kprateek.nayak@amd.com, linux-kernel@vger.kernel.org References: <20231122022154.12772-1-CruzZhao@linux.alibaba.com> From: cruzzhao Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2023/11/23 上午5:05, Namhyung Kim 写道: > Hello, > > On Tue, Nov 21, 2023 at 6:22 PM Cruz Zhao wrote: >> >> When synthesize thread map, some threads in thread map may have >> already exited, so that __event__synthesize_thread() returns -1 >> and the synthesis breaks. However, It will not have any effect >> if we just ignore the exited thread. So just ignore it and continue. > > Looks ok. But I guess you want to do the same for the leader > thread below as well. > > Thanks, > Namhyung > With my testcase, no error is returned even if we don't do the same for the leader thread blow. Well, I'll check whether the logic is still correct if we do so. Many thanks for reviewing. Best, Cruz Zhao