From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
<vkoul@kernel.org>, <yung-chuan.liao@linux.intel.com>,
<sanyog.r.kale@intel.com>
Cc: <patches@opensource.cirrus.com>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/5] soundwire: cadence: Fix lost ATTACHED interrupts when enumerating
Date: Wed, 14 Sep 2022 15:30:32 +0100 [thread overview]
Message-ID: <5ab8f14d-8fa0-ea37-a664-88a0cff9b92f@opensource.cirrus.com> (raw)
In-Reply-To: <1b506127-f992-b554-e984-589dc46aa110@linux.intel.com>
On 14/09/2022 14:48, Pierre-Louis Bossart wrote:
>
>> diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c
>> index 245191d22ccd..2f131604d884 100644
>> --- a/drivers/soundwire/cadence_master.c
>> +++ b/drivers/soundwire/cadence_master.c
>> @@ -954,9 +954,22 @@ static void cdns_update_slave_status_work(struct work_struct *work)
>> u32 device0_status;
>> int retry_count = 0;
>>
>> + /*
>> + * Clear main interrupt first so we don't lose any assertions
>> + * the happen during this function.
>
> typo: that happen?
>
I hate typos.
next prev parent reply other threads:[~2022-09-14 14:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 12:09 [PATCH v3 0/5] soundwire: Fixes for spurious and missing UNATTACH Richard Fitzgerald
2022-09-14 12:09 ` [PATCH v3 1/5] soundwire: cadence: fix updating slave status when a bus has multiple peripherals Richard Fitzgerald
2022-09-14 12:09 ` [PATCH v3 2/5] soundwire: bus: Don't lose unattach notifications Richard Fitzgerald
2022-09-14 12:09 ` [PATCH v3 3/5] soundwire: bus: Don't re-enumerate before status is UNATTACHED Richard Fitzgerald
2022-09-14 12:09 ` [PATCH v3 4/5] soundwire: cadence: Fix lost ATTACHED interrupts when enumerating Richard Fitzgerald
2022-09-14 13:48 ` Pierre-Louis Bossart
2022-09-14 14:30 ` Richard Fitzgerald [this message]
2022-09-14 12:09 ` [PATCH v3 5/5] soundwire: bus: Don't exit early if no device IDs were programmed Richard Fitzgerald
2022-09-14 13:58 ` Pierre-Louis Bossart
2022-09-14 14:00 ` [PATCH v3 0/5] soundwire: Fixes for spurious and missing UNATTACH Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ab8f14d-8fa0-ea37-a664-88a0cff9b92f@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®