From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C875AC43334 for ; Wed, 6 Jul 2022 12:03:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232618AbiGFMDx (ORCPT ); Wed, 6 Jul 2022 08:03:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231713AbiGFMDu (ORCPT ); Wed, 6 Jul 2022 08:03:50 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 473166584 for ; Wed, 6 Jul 2022 05:03:48 -0700 (PDT) Received: from fraeml701-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4LdJ673vf3z6H7lp; Wed, 6 Jul 2022 20:01:03 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml701-chm.china.huawei.com (10.206.15.50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.24; Wed, 6 Jul 2022 14:03:45 +0200 Received: from [10.126.171.66] (10.126.171.66) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 6 Jul 2022 13:03:44 +0100 Message-ID: <5ab934ff-0b16-0b55-e0f1-36366cd33e84@huawei.com> Date: Wed, 6 Jul 2022 13:03:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH RESEND v5 1/5] iommu: Refactor iommu_group_store_type() To: Will Deacon CC: , , , , , , , , , , References: <1649071634-188535-1-git-send-email-john.garry@huawei.com> <1649071634-188535-2-git-send-email-john.garry@huawei.com> <20220706120059.GE2403@willie-the-truck> From: John Garry In-Reply-To: <20220706120059.GE2403@willie-the-truck> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.171.66] X-ClientProxiedBy: lhreml732-chm.china.huawei.com (10.201.108.83) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/07/2022 13:00, Will Deacon wrote: > On Mon, Apr 04, 2022 at 07:27:10PM +0800, John Garry wrote: >> Function iommu_group_store_type() supports changing the default domain >> of an IOMMU group. >> >> Many conditions need to be satisfied and steps taken for this action to be >> successful. >> >> Satisfying these conditions and steps will be required for setting other >> IOMMU group attributes, so factor into a common part and a part specific >> to update the IOMMU group attribute. >> >> No functional change intended. >> >> Some code comments are tidied up also. >> >> Signed-off-by: John Garry >> --- >> drivers/iommu/iommu.c | 96 ++++++++++++++++++++++++++++--------------- >> 1 file changed, 62 insertions(+), 34 deletions(-) > Acked-by: Will Deacon > Thanks, but currently I have no plans to progress this series, in favour of this https://lore.kernel.org/linux-iommu/1656590892-42307-1-git-send-email-john.garry@huawei.com/T/#me0e806913050c95f6e6ba2c7f7d96d51ce191204 cheers