From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C72DC433EF for ; Sat, 18 Jun 2022 02:49:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383957AbiFRCts (ORCPT ); Fri, 17 Jun 2022 22:49:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231473AbiFRCtr (ORCPT ); Fri, 17 Jun 2022 22:49:47 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 216B259BB4 for ; Fri, 17 Jun 2022 19:49:47 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LQ0j12rG4zjXyX; Sat, 18 Jun 2022 10:48:37 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 18 Jun 2022 10:49:44 +0800 Subject: Re: [PATCH v4 1/4] mm: reduce the rcu lock duration To: Andrew Morton CC: "Eric W. Biederman" , Ying Huang , , , , , , , , , , , References: <20220530113016.16663-1-linmiaohe@huawei.com> <20220530113016.16663-2-linmiaohe@huawei.com> <87bkvdfzvm.fsf@email.froward.int.ebiederm.org> <87y1yga1r2.fsf@email.froward.int.ebiederm.org> <87ilph90dx.fsf@email.froward.int.ebiederm.org> <20220617172316.de2d41877e86be344052b9f5@linux-foundation.org> From: Miaohe Lin Message-ID: <5abc85bc-fec7-afbf-4ec4-90c1385195d2@huawei.com> Date: Sat, 18 Jun 2022 10:49:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220617172316.de2d41877e86be344052b9f5@linux-foundation.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/6/18 8:23, Andrew Morton wrote: > On Tue, 7 Jun 2022 17:19:53 +0800 Miaohe Lin wrote: > >>> >>> >>> If the checks are not made to guarantee they are all checking against >>> the same mm, the code needs a comment to say that there is a tiny race. >>> The comment should say we don't care about the tiny race because >>> the worst that can happen is that a page is migrated to a different >>> numa node. And so we don't care. >>> >>> >> >> I tend to do this one. To make sure, is the below code change what you suggest? > > Eric went quiet. > > As I understand it, any changes arising from this discussion can be > done as a followup patch. So I'm planning on moving this 4-patch > series into the non-rebasing mm-stable branch late next week. I will send a followup patch when discussion is done. Thanks. > > > . >