From: Paolo Bonzini <pbonzini@redhat.com>
To: Barret Rhoden <brho@google.com>,
Dan Williams <dan.j.williams@intel.com>,
David Hildenbrand <david@redhat.com>,
Dave Jiang <dave.jiang@intel.com>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>
Cc: linux-nvdimm@lists.01.org, x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, jason.zeng@intel.com
Subject: Re: [PATCH v4 2/2] kvm: Use huge pages for DAX-backed files
Date: Thu, 12 Dec 2019 01:21:57 +0100 [thread overview]
Message-ID: <5abef720-c329-13c3-ff93-b4b58a08721c@redhat.com> (raw)
In-Reply-To: <20191211213207.215936-3-brho@google.com>
On 11/12/19 22:32, Barret Rhoden wrote:
> + /*
> + * Our caller grabbed the KVM mmu_lock with a successful
> + * mmu_notifier_retry, so we're safe to walk the page table.
> + */
> + switch (dev_pagemap_mapping_shift(hva, current->mm)) {
> + case PMD_SHIFT:
> + case PUD_SIZE:
> + return true;
> + }
> + return false;
Should this simply be "> PAGE_SHIFT"?
Paolo
next prev parent reply other threads:[~2019-12-12 0:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 21:32 [PATCH v4 0/2] " Barret Rhoden
2019-12-11 21:32 ` [PATCH v4 1/2] mm: make dev_pagemap_mapping_shift() externally visible Barret Rhoden
2019-12-11 21:32 ` [PATCH v4 2/2] kvm: Use huge pages for DAX-backed files Barret Rhoden
2019-12-12 0:21 ` Paolo Bonzini [this message]
2019-12-12 12:22 ` David Hildenbrand
2019-12-12 16:31 ` Barret Rhoden
2019-12-12 12:33 ` Liran Alon
2019-12-12 16:54 ` Dan Williams
2019-12-12 17:39 ` Liran Alon
2019-12-12 17:59 ` Dan Williams
2019-12-12 18:32 ` Liran Alon
2019-12-12 17:03 ` Barret Rhoden
2019-12-12 17:34 ` Sean Christopherson
2019-12-12 17:37 ` Dan Williams
2019-12-12 19:16 ` Barret Rhoden
2019-12-12 19:48 ` Dan Williams
2019-12-12 20:08 ` Barret Rhoden
2019-12-12 17:45 ` Liran Alon
2019-12-12 0:22 ` [PATCH v4 0/2] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5abef720-c329-13c3-ff93-b4b58a08721c@redhat.com \
--to=pbonzini@redhat.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=brho@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=david@redhat.com \
--cc=jason.zeng@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®