From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39CF5C433F5 for ; Fri, 28 Jan 2022 11:33:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235979AbiA1LdB (ORCPT ); Fri, 28 Jan 2022 06:33:01 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:4544 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236647AbiA1Lc5 (ORCPT ); Fri, 28 Jan 2022 06:32:57 -0500 Received: from fraeml738-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4JlZvw5n9Sz67w0f; Fri, 28 Jan 2022 19:28:28 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml738-chm.china.huawei.com (10.206.15.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 28 Jan 2022 12:32:53 +0100 Received: from [10.47.26.192] (10.47.26.192) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 28 Jan 2022 11:32:52 +0000 Subject: Re: [PATCH] iommu/iova: Separate out rcache init To: Robin Murphy , "joro@8bytes.org" , "will@kernel.org" , "mst@redhat.com" , "jasowang@redhat.com" CC: "xieyongji@bytedance.com" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , Linuxarm References: <1643205319-51669-1-git-send-email-john.garry@huawei.com> From: John Garry Message-ID: <5ac3a678-3126-edd9-cb23-72c05f3dcd34@huawei.com> Date: Fri, 28 Jan 2022 11:32:16 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.26.192] X-ClientProxiedBy: lhreml713-chm.china.huawei.com (10.201.108.64) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/01/2022 17:00, Robin Murphy wrote: > As above, I vote for just forward-declaring the free routine in iova.c > and keeping it entirely private. BTW, speaking of forward declarations, it's possible to remove all the forward declarations in iova.c now that the FQ code is gone - but with a good bit of rearranging. However I am not sure how much people care about that or whether the code layout is sane...