From: Jens Axboe <axboe@kernel.dk>
To: Mauricio Faria de Oliveira <mfo@canonical.com>
Cc: phdm@macqel.be, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, daniel.axtens@canonical.com
Subject: Re: [PATCH 0/2] partitions/aix: fix problems due to disk corruption
Date: Fri, 27 Jul 2018 09:17:21 -0600 [thread overview]
Message-ID: <5ac51c6d-a7b5-9ae1-88dc-1536450d70fb@kernel.dk> (raw)
In-Reply-To: <20180726014629.30411-1-mfo@canonical.com>
On 7/25/18 7:46 PM, Mauricio Faria de Oliveira wrote:
> We've recently received a disk image from an AIX LUN that when
> attached on Linux displayed errors on console, then eventually
> hung the system.
>
> Apparently the LUN was originally installed with AIX and later
> exercised with some I/O stress/overwrites which caused certain
> bits to be wrong in just the right way for Linux to get a NULL
> pointer and invalid data.
>
> This is the test-case used ('--partscan' is the important bit).
> $ sudo losetup --show --find --partscan aix-lun.img
>
> Patch 1 resolves the particular problem the disk image has.
> Patch 2 improves the code a bit further (tested synthetically).
>
> Mauricio Faria de Oliveira (2):
> partitions/aix: fix usage of uninitialized lv_info and lvname
> structures
> partitions/aix: append null character to print data from disk
>
> block/partitions/aix.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
Looks good to me, I have applied for 4.19.
--
Jens Axboe
prev parent reply other threads:[~2018-07-27 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 1:46 Mauricio Faria de Oliveira
2018-07-26 1:46 ` [PATCH 1/2] partitions/aix: fix usage of uninitialized lv_info and lvname structures Mauricio Faria de Oliveira
2018-07-26 1:46 ` [PATCH 2/2] partitions/aix: append null character to print data from disk Mauricio Faria de Oliveira
2018-07-27 15:17 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ac51c6d-a7b5-9ae1-88dc-1536450d70fb@kernel.dk \
--to=axboe@kernel.dk \
--cc=daniel.axtens@canonical.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfo@canonical.com \
--cc=phdm@macqel.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®