From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 584922EF64F for ; Thu, 11 Jun 2026 08:50:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781167834; cv=none; b=pX+g/qtJURBcQBtM7VDz1HTuaWar7+tOIqRO1ixFkCkBYDa5vcD2auR9tVMJVd2u+MQxrkYKDyN6h5sT0GB/AavR5B3pdfKa0Lcjr5lHOC3Z7nB3sOT5tSpRv00OfTeQqX+jFPVR9jHDnuMlpe3C0/UCGsfPCYZdFnX1wqebr4w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781167834; c=relaxed/simple; bh=hScv+/Dg2XQbBeFR+q7U/xKDIGWAPmkZJFNTNr4VW+4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=K7NPjct6/0Q126SyRko2hUi+CL1BMVrvoJGRZ3UD/Rx3aFedJMbRIlrlDOqATthAeFVPrBu3+5RzlTFYsY7+k8/Yee727o8iENC9HNEiwyO4LE3iASOxraxPUSL6tYi6qFni0hrl4U52otT2OtWvQxVFFvbkp+5N1EN4grde8PA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=e2OBe6Ow; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=FFIMk94p; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e2OBe6Ow"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="FFIMk94p" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781167831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=05L3jrJVlFcQn4GVsQrHr7saBG8RDpkpSs796Rei0Dg=; b=e2OBe6OwVkNn1Ui8VH5KrJDerb5JbJKanSqJbjl35xU9fZGr1oemzuWNrPknDJ8B536Ou5 uFEwoktXDY4AxhNQGt3zBbQaHSoV+cy+SgWZmxTQhbkwhF0+2dKlihipjf7PrPXyoAMsqu rMeOs6s2dwu3vIqugVLgL/RY9Xnl+cE= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-511-5se_jb0AMMCu2tCqlxmgWA-1; Thu, 11 Jun 2026 04:50:29 -0400 X-MC-Unique: 5se_jb0AMMCu2tCqlxmgWA-1 X-Mimecast-MFC-AGG-ID: 5se_jb0AMMCu2tCqlxmgWA_1781167828 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-bf473656dcdso499940566b.1 for ; Thu, 11 Jun 2026 01:50:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781167828; x=1781772628; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=05L3jrJVlFcQn4GVsQrHr7saBG8RDpkpSs796Rei0Dg=; b=FFIMk94pLSTSTfUxl838B3U96kzj+OwqBrqVvZ724TKdLIXC1ll4aGSJlDFTyTK37+ 9A8JJTYZqfAcU8i8DIZfe5e+hADrmn1bdzJdvWiZtIY4pTSvr0FLJfluxDM/sdMtV/Bq 7xJbcKL3U1sIoUNYBdsh7U6+AH6dpoW6Sp2hP3S9YhbdlXiuMmLv/194ErkGjqacTcAP rIenwxu7EPJZf6ks3PhlVFF5HrLpu0LGNmOsxLmSzgg7G3y47f8uVIans5ejCn7DMeLH nuL6YOpWRCitfMvcPAcWBIJGeUzW4j7dEtwVbyC8pDNhf1NCWQi5a2Edj+JZpltJq9kA 6Z7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781167828; x=1781772628; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=05L3jrJVlFcQn4GVsQrHr7saBG8RDpkpSs796Rei0Dg=; b=Ch4x+D69cvIJ2b8MWddOOeOhVVQVTVd8ctPuXTWyh6oE3lm1tYVyARTVNG3a3HxfrO wXz2oFu0UXdt/VkP93Fx9g6VCUlWbUtj5SkUezVW0uzq37ikG3WalZW4fdGBY0DUkK2e XDsCHARD9mX4jr2+xFECs6YbWfHPYA2BllN1FpV+EK4S9mEDClsAQ17TgISGpGoXnngI ADlU/gLNzSpUrYNQozYaAOic+8dyjJxQt1uMzRPlmDMOjBIKNyNBF147lm98VYkj69O7 anKSeQ54jPgLU0CfwzTmKLfZFin5LhI04/RIRgaZzTYuTEbGW2pf2YiNlWAANmgKQ+Wg XYQQ== X-Gm-Message-State: AOJu0Yy9tVxBc/m7eADzS42pZ6U+YG0Q0K+9q5vXHZxtL+BkXXgKfUJp t619Y4m0LAqTc1r+cdszDz1mgvb8rc9fefFmCde4Qm50TZJ+JaA3QS7RTf1BjvMz7WgqJlDWpaC 8pM13TX//QpeTMzNSEBNHWBFmBwIsRi/iOrbf2MIjmxuCKoACfRM+YVliio6vT1KfGw== X-Gm-Gg: Acq92OEzgAp032jJfYzhN14ZnmvclKDFKJkSCDE6F5/i7e8EoT6DJkkBpkc5bk7ts+C aHdTwORC767QwzMNtBETiDJq6QahauXaORttTb+4FzmcrtrTyUhm6BjXGvBlqI7pi1Nc6Jrv/kE Y6io8XI4VP5MlsdyoJAurgFq4xZRsvWwG9Pb8CMsdsUJHbzugswVuSBTKBWba3SJijxi0an4CwM tiE5ZNyWOuD5pMgEwfawxtj5ApHrMHpwT7cfmzBki2sfhMrhDEOkWVnihIDqXbZ19pqWpUksJDe GlNHoLBE9EdGS6lGVuMBJ/mNxK1MVEXxhq33RG7SUtUD1/6qeITOMvYtF+MtPCC13cDi/wsZ2JT 7tLZ4WlS2Acz6i8jKFknxm06czuvboUP/AzBsmOjXiqIwKjmHnlV6qRFwvFHBixkiqg== X-Received: by 2002:a17:907:a04:b0:bf7:a616:cafa with SMTP id a640c23a62f3a-bfc880e7160mr73162066b.34.1781167828395; Thu, 11 Jun 2026 01:50:28 -0700 (PDT) X-Received: by 2002:a17:907:a04:b0:bf7:a616:cafa with SMTP id a640c23a62f3a-bfc880e7160mr73159566b.34.1781167827875; Thu, 11 Jun 2026 01:50:27 -0700 (PDT) Received: from [192.168.88.32] ([150.228.93.44]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfcb1607631sm34291566b.14.2026.06.11.01.50.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 01:50:27 -0700 (PDT) Message-ID: <5ad977af-9bbb-4376-b0a6-2b1867223145@redhat.com> Date: Thu, 11 Jun 2026 10:50:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 net-next 03/13] dpll: fix stale iteration in dpll_pin_on_pin_unregister() To: Grzegorz Nitka , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, poros@redhat.com, richardcochran@gmail.com, andrew+netdev@lunn.ch, przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com, Prathosh.Satish@microchip.com, ivecera@redhat.com, jiri@resnulli.us, arkadiusz.kubalewski@intel.com, vadim.fedorenko@linux.dev, donald.hunter@gmail.com, horms@kernel.org, kuba@kernel.org, davem@davemloft.net, edumazet@google.com References: <20260607183045.1213735-1-grzegorz.nitka@intel.com> <20260607183045.1213735-4-grzegorz.nitka@intel.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260607183045.1213735-4-grzegorz.nitka@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/7/26 8:30 PM, Grzegorz Nitka wrote: > Neither parent->dpll_refs nor pin->dpll_refs on its own is a correct > iteration target at unregister time: > > - pin->dpll_refs includes DPLLs the child was registered against > via a different parent or directly; blind unregister WARNs on > the cookie miss in dpll_xa_ref_pin_del(). > - parent->dpll_refs reflects the parent's current attachments, not > those at child-register time. Another driver may have (un)reg'd > the parent against additional DPLLs in the meantime, so we miss > registrations that exist and visit DPLLs that have none. > > Walk pin->dpll_refs and use dpll_pin_registration_find() to filter > to entries whose cookie is this parent. Symmetric with > dpll_pin_on_pin_register(), correct under any subsequent change to > parent->dpll_refs. > > Fixes: 9431063ad323 ("dpll: core: Add DPLL framework base functions") > Signed-off-by: Grzegorz Nitka The current guidance is to avoid the Fixes tag for net-next patches, when such tag refers to code already into Linus's tree. If it's a real user-visible issue, the patch should target net. Otherwise if the intended target is really net-next, no fixes tag please. Unrelated important node: sashiko (gemini) still has some comments, some of them looks new and relevant to me i.e. the possible divide by zero bug in patch 11, see: https://sashiko.dev/#/patchset/20260607183045.1213735-1-grzegorz.nitka%40intel.com /P