From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FA38625 for ; Fri, 15 May 2026 08:32:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778833955; cv=none; b=ZmzWOxRnV0gGeFeYPWJ0bY/uN5KjUXcekX0KWMD6spdFdZFFQ/yRHlos3rZsB4Y8dJ+Qo2mKnMwQB5XdNiSFZfLamQrlUsVluDGtH7od+TrxtngquUbP3r0U66Fhs7KybwnjtjE7zRPygpxHfPxwVrrEipfZ8BR/VoiaVxasSmY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778833955; c=relaxed/simple; bh=2KlkGNOF7+OvLv0cTbiSK1wSmJp3z+rBZspm5oF/ITE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SqUPSTIQGnmD7o28UXPLXOZhm22fN9lqIHHKQz9FC/1DoLjqdTz11ZynZXffHwosYSRplOH81Oux8qBr/ITLlH2rylohz/xvIdBv3x5Mlpu33IFzPtu1LmwWiVAA2Rgpqgyka2/TvJJn+HCln/97i7LX0JuP0ncOaZ0dkQplCqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DIdPpKcY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QhP7bcW+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DIdPpKcY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QhP7bcW+" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64F5QJCW3671020 for ; Fri, 15 May 2026 08:32:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ypc5cw+aeh2+Tg52m6j1/NuUMBslXu/qMIh12tt5Eiw=; b=DIdPpKcYHKUcSHCH HDORyNMxjlg9kkFh3FyJ42jpvMjAXeN57c2rE6lk6xD2GwgsgFK75UwbLARwJ7F2 lPw6D88hRbpn0ChQNQXYr9aTTEC5+w1Lw30V8fw5vIXlbGeW3YnulCisIEO/b7Wn LxxhIbbQ6aKdgUFL83Ef7PTdTQXp6FzS9rlm4k4yykEIfPX/kbWqBVY20EqtNk7X b1xDOTTdKo4qRdHTmdGJL7A7MzyTTwfR1tM4YUbfwL0CfOrBCS+I7cTNZjx/JDIp wgL2IhfXAEzpH1oVMWVtgQu0iU9VPVZZvLdVJ2Ty4I0kr5ChzUYEzH4Zfyl0jRWA CQRm8w== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e5m1s2epq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 15 May 2026 08:32:33 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-36603ad6709so9447085a91.2 for ; Fri, 15 May 2026 01:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778833952; x=1779438752; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ypc5cw+aeh2+Tg52m6j1/NuUMBslXu/qMIh12tt5Eiw=; b=QhP7bcW+zwwLND5tsK0SjtwQtSnGHx41Fp+45MFJCuzKY0ax0YBEacDZ8vZTqSH8xi 8kGE8+LKYLhvC0GrmcThjaXYeQl+AmuwalOYUhcG/E9q4qco+HGtvh1hR2be4gDQLnW4 /xt6J31YV/26A1nSSlPtXL7M+QxCTL9NdyR8Cmg63GG/bt3CgCMMPI8zV6BectUeLdxD E5sTtgm4nulfENb1a7C40+3RRlobH3antoP58oT7gRs83BsNOIQorb+97ADopXiuFEiK +fvk6Vj2VTz09jYdAbdoKJ42+ZtO39RjJyhfs1wJXgLRDwAe9h7cak9fSxrQF8Mh2j7h P14g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778833952; x=1779438752; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ypc5cw+aeh2+Tg52m6j1/NuUMBslXu/qMIh12tt5Eiw=; b=i0ABrrzQlsD7CN48C+/liJEUDry2NZFPdL0eEtGjtX4LU6X7pBf+UvO3Gn5wRDWCfH tD/PM9owgFE/3+WNtJ92E1xDVZNzoNp+2CgJbypJKzeSwchx/iI1h1Ge7BTK5ZVasmg9 z8eEK/vJVO9pyHRg2d8cOKLDX7Ha519V+X1YwIjn4e6M7p99ZX0Jt/LvE08pY1wt+57n ogrc3Ex5sq8l4uMY+btjXDzyiF7lx2/aRI/nsbglFDNkMDEAjwOig90vJV1xaslQMphM qlFD5JnqUwRHGQpibCBlkQS9AqFSUFo40jTR5tO8/g2cxfuAXbxsPNjA5feAudbuK9JR 4qaA== X-Forwarded-Encrypted: i=1; AFNElJ+IsNeD2dL2PRwuXFo0bOS2NMnq+2ByN0/ftmj+I0paEhgFG+AbFOqlEIa8xTpF5raehGZqUZpujrpkEiM=@vger.kernel.org X-Gm-Message-State: AOJu0YyXiK883xualXiax+AIFjOlMpCt2fbBLCeL+ikjSGAriDqra+6T OK9JkloSExObMf80t5V4hIH1ZvxxacHpEm7Ll8L2BTRc3NfvSbq8YbtrLSPFOCN2ZCkQn3cpQQN uNYkiXVP+g2fdq59WGOH9O9uoG5HObWgx8CCnOIPNk3QT0dWbBnjYJmqIiLbVbwR3iNvoHpLr6Y g= X-Gm-Gg: Acq92OEfKRYUnkA5PDJHSt73eJMIJYNPAIaOPurjTcaqg0p8dOH9FhFjQs2kQGepUrU R6EbxxRhxCcoU/mN0hiF+7IVxrDdCcz4LtQIzYJJAG0XCxkoq1puXqeK2MRsv5iNLynrTwiD0xs eZjvYVBZDrREEA/Dw1D5ffr7y8vk6bGBJ90967SVCFynYmOOX1ocgjFP993FyZSe3yhzXNcuIdr E+J2lIhYsCHoAdyXnxeDF1BHyG+3/Zj4ZlpM+FJ6WfrcHeUKbTsYEqtZyeTfcwCXN5jVC6G7UQ+ F9BbejkjLkjBe0f5Sfb5wD+J9AxH9AeVop8as8T5DkIFuGWtZMBSK3ZxC57ZkEtm7uxacy/J6QX Fsa/CP6okGzcWgC9YdcAxyocRSpBi0O4pwhmg58pydl2/ByYo2Mv9zPU/2VJN X-Received: by 2002:a17:90b:3d0a:b0:366:479e:63a5 with SMTP id 98e67ed59e1d1-369518b25cemr3166933a91.2.1778833952408; Fri, 15 May 2026 01:32:32 -0700 (PDT) X-Received: by 2002:a17:90b:3d0a:b0:366:479e:63a5 with SMTP id 98e67ed59e1d1-369518b25cemr3166888a91.2.1778833951854; Fri, 15 May 2026 01:32:31 -0700 (PDT) Received: from [10.92.212.183] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3695155b2c4sm2001418a91.3.2026.05.15.01.32.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2026 01:32:31 -0700 (PDT) Message-ID: <5ad97e7b-f39e-44cd-b4be-86711a090d01@oss.qualcomm.com> Date: Fri, 15 May 2026 14:02:08 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: cpufreq: qcom-hw: Document Shikra CPUFREQ Hardware To: Krzysztof Kozlowski Cc: "Rafael J. Wysocki" , Viresh Kumar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Ajit Pandey , Taniya Das , Jagadeesh Kona , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260501-shikra-cpufreq-scaling-v1-0-c78b95f53b91@oss.qualcomm.com> <20260501-shikra-cpufreq-scaling-v1-1-c78b95f53b91@oss.qualcomm.com> <20260504-fuzzy-wapiti-of-ampleness-d8bc13@quoll> <8101e2c8-0593-4325-a701-84f776dd4b0a@oss.qualcomm.com> <27cc44d7-b3d1-4610-8257-4aad4115cd36@kernel.org> Content-Language: en-US From: Imran Shaik In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE1MDA4NCBTYWx0ZWRfX7F6g9MxhkFNm 3/X763SJjSwJRsHwI96uv7LBzqeYL7UKV1RH5DZod6MJPOWb7L23XJKqZXcG1V82ZpJji2o4lam Q5FrsZiYbLn1iVkDzdK6jj/63x9A7FMzSXikS3HICPkuQeNAzm4Dqwu7VtE/fOdg6hiVABYd/Wk Ic7+JYwWeBwCrXjkKAbJI/B/tJLLzXF2oRo1Sm6WHKPaUUBmPYHOM/hIv8sFdrONANw8Ck9L9Hy X+/Uv+jefyQbYhjPLrnXIc51dVPmLDU/0PJlhfioPofCkYPEi8CI/oSdEElAs6aWi8O3/2z8b+r XbUsN15JrlsujWlTbMQCWMAvxLuJtPxKPj40AuMnuTKZnYNZe/Ls6jE+Mlfwr06CjAB+7b7KAyD rHQAI0uSlqq9vd0fYeldC1e4aKzm2I1z1PnTxu9QSma+n9sRC5BtpwsvIDMcknzgGkGXcwp5fpj DWVDIciZwgMwKixiFeg== X-Authority-Analysis: v=2.4 cv=Md5cfZ/f c=1 sm=1 tr=0 ts=6a06da21 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=nIfeAKEMkRZjI2vJ8KMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: Lo9DOPVAQfG2bG3tuWswm5lEgZS6vGQW X-Proofpoint-ORIG-GUID: Lo9DOPVAQfG2bG3tuWswm5lEgZS6vGQW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-15_02,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 adultscore=0 phishscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605150084 On 14-05-2026 08:13 pm, Krzysztof Kozlowski wrote: > On 14/05/2026 16:39, Krzysztof Kozlowski wrote: >> On 08/05/2026 18:03, Imran Shaik wrote: >>> >>> >>> On 05-05-2026 02:23 pm, Krzysztof Kozlowski wrote: >>>> On 05/05/2026 10:50, Imran Shaik wrote: >>>>> >>>>> >>>>> On 04-05-2026 03:53 pm, Krzysztof Kozlowski wrote: >>>>>> On Fri, May 01, 2026 at 12:45:44PM +0530, Imran Shaik wrote: >>>>>>> The Qualcomm Shikra cpufreq hardware is functionally identical to EPSS, >>>>>>> but supports only up to 12 frequency lookup table (LUT) entries. Introduce >>>>>>> qcom,cpufreq-epss-lite to represent this constrained EPSS variant. >>>>>> >>>>>> The entire point of having a generic compatible is that it MUST match >>>>>> all devices. If it does not, then it is pointless to push that generic >>>>>> compatible. >>>>>> >>>>>> I am speaking about qcom,cpufreq-epss. >>>>>> >>>>>> That's nothing new, I was arguing about it already, but now you have >>>>>> confirmation of the mess introduced by generic compatibles. Solution is >>>>>> not to add more generic compatibles, because what will be next? >>>>>> qcom,cpufreq-epss-lighter? >>>>>> qcom,cpufreq-epss-more-lite? >>>>>> qcom,cpufreq-epss-high? >>>>>> >>>>>> Same was here: >>>>>> https://lore.kernel.org/all/20240828203721.2751904-17-quic_nkela@quicinc.com/ >>>>>> >>>>>> So that's second time I object and do object for every new instance. No >>>>>> to generic compatibles, they are proven to be wrong at least for >>>>>> Qualcomm. >>>>>> >>>>>> Best regards, >>>>>> Krzysztof >>>>>> >>>>> >>>>> Hi Krzysztof, >>>>> >>>>> There is no functional change to the latest EPSS hardware >>>>> (qcom,cpufreq-epss) in this case. The Shikra platform uses the CPU >>>>> frequency scaling block, which is a predecessor of EPSS and is referred >>>>> to as EPSS‑lite. The only difference between EPSS‑lite and EPSS is the >>>>> maximum number of frequency look up table (LUT) entries. >>>>> >>>>> This constrained EPSS block is not specific to Shikra and can be reused >>>>> by other SoCs that implement the same hardware. Hence, we have added a >>>>> separate epss-lite compatible and reused the existing bindings, as all >>>>> other aspects of the hardware behavior and interface remain identical. >>>> >>>> I don't understand how any of this is relevant to my comment. I know >>>> what you did. >>>> >>> >>> Hi Krzysztof, >>> >>> The intent behind proposing an epss-lite compatible was to describe a >>> common hardware variant and avoid introducing SoC‑specific handling in >>> the cpufreq driver. >> >> And I already objected. Look: >> >> "So that's second time I object and do object for every new instance. No >> to generic compatibles" >> >> I provided arguments for that in the past. >> >> NAK >> >> Best regards, > > I already provided the arguments here: > > "The entire point of having a generic compatible is that it MUST match > all devices. If it does not, then it is pointless to push that generic > compatible." > > so if you have generic compatible, IT MUST be used. You cannot keep > adding more generic compatibles just because existing generic compatible > is not generic enough! > Hi Krzysztof, Sure, I will drop the generic compatible approach and introduce a Shikra specific bindings file (shikra-cpufreq-qcom-hw.yaml), similar to the existing EPSS binding, using the compatible string qcom,shikra-cpufreq-epss. Thanks, Imran > I gave you detailed reasoning and even example why this approach is > getting ridiculous, but you just have to keep pushing your solution to > maintainers and keep asking the same. > > You were given the answer and the argument. Now you are just wasting > maintainers time. > > Best regards, > Krzysztof