mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Eugen Hristev <eugen.hristev@collabora.com>,
	bin.liu@mediatek.com, matthias.bgg@gmail.com,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: media: mediatek-jpeg-encoder: change max ioomus count
Date: Tue, 2 Jan 2024 10:29:31 +0100	[thread overview]
Message-ID: <5ad9e27b-761f-47a9-8d7d-f182dac5d2cd@collabora.com> (raw)
In-Reply-To: <20231227130812.148914-1-eugen.hristev@collabora.com>

Il 27/12/23 14:08, Eugen Hristev ha scritto:
> MT8186 has 4 iommus in the list, to cope with this situation, adjust
> the maxItems to 4 (instead of previous 2).
> Add also minItems as 1 since iommus are mandatory, to avoid warning
> on the example.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
> ---
>   .../devicetree/bindings/media/mediatek-jpeg-encoder.yaml       | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml
> index 37800e1908cc..60c75b9312e8 100644
> --- a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml
> @@ -38,7 +38,8 @@ properties:
>       maxItems: 1
>   
>     iommus:
> -    maxItems: 2
> +    minItems: 1
> +    maxItems: 4
>       description: |
>         Points to the respective IOMMU block with master port as argument, see
>         Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml for details.

(commit title) `ioomus` is something I've never heard of before... :-P

Please fix the typo, after which:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>


  parent reply	other threads:[~2024-01-02  9:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-27 13:08 Eugen Hristev
2023-12-27 13:08 ` [PATCH 2/2] arm64: dts: mediatek: mt8186: Add jpgenc node Eugen Hristev
2024-01-02  9:28   ` AngeloGioacchino Del Regno
2024-01-02  9:29 ` AngeloGioacchino Del Regno [this message]
2024-01-09  3:27 ` [PATCH 1/2] dt-bindings: media: mediatek-jpeg-encoder: change max ioomus count Rob Herring
2024-01-15  3:57   ` Eugen Hristev
2024-01-22  7:54     ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ad9e27b-761f-47a9-8d7d-f182dac5d2cd@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=bin.liu@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eugen.hristev@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®