mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com>
To: "arm@kernel.org" <arm@kernel.org>
Cc: Sekhar Nori <nsekhar@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Tero Kristo <t-kristo@ti.com>,
	Murali Karicheri <m-karicheri2@ti.com>
Subject: Re: [PATCH] ARM: dts: keystone-k2l: fix broken Ethernet due to disabled OSR
Date: Wed, 29 Mar 2017 11:13:39 -0500	[thread overview]
Message-ID: <5adb4f5d-78c4-453d-898d-60c588eb1d14@oracle.com> (raw)
In-Reply-To: <59ba5ef37f17ff1c10d9d52ca06ef341b2d476eb.1490782833.git.nsekhar@ti.com>

Hi Arnd, Olof,

On 3/29/17 5:32 AM, Sekhar Nori wrote:
> From: Murali Karicheri <m-karicheri2@ti.com>
>
> Ethernet networking on K2L has been broken since v4.11-rc1. This was
> caused by commit 32a34441a9bd ("ARM: keystone: dts: fix netcp clocks
> and add names"). This commit inadvertently moves on-chip static RAM
> clock to the end of list of clocks provided for netcp. Since keystone
> PM domain support does not have a list of recognized con_ids, only the
> first clock in the list comes under runtime PM management. This means
> the OSR (On-chip Static RAM) clock remains disabled and that broke
> networking on K2L.
>
> The OSR is used by QMSS on K2L as an external linking RAM. However this
> is a standalone RAM that can be used for non-QMSS usage (as well as from
> DSP side). So add a SRAM device node for the same and add the OSR clock
> to the node.
>
> Remove the now redundant OSR clock node from netcp.
>
> To manage all clocks defined for netCP's use by runtime PM needs keystone
> generic power domain (genpd) driver support which is under works.
> Meanwhile, this patch restores K2L networking and is correct irrespective
> of any future genpd work since OSR is an independent module and not part
> of NetCP anyway.
>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> Acked-by: Tero Kristo <t-kristo@ti.com>
> [nsekhar@ti.com: commit message updates, port to latest mainline]
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> ---
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>

Can you please pick this up for rcx fixes ?

Regards,
Santosh

  reply	other threads:[~2017-03-29 16:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-29 10:32 Sekhar Nori
2017-03-29 16:13 ` santosh.shilimkar [this message]
2017-03-31 10:13   ` Arnd Bergmann
2017-05-26  7:44     ` Sekhar Nori
2017-05-26  8:12       ` Arnd Bergmann
2017-05-26  8:16         ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5adb4f5d-78c4-453d-898d-60c588eb1d14@oracle.com \
    --to=santosh.shilimkar@oracle.com \
    --cc=arm@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=m-karicheri2@ti.com \
    --cc=mark.rutland@arm.com \
    --cc=nsekhar@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=ssantosh@kernel.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®