mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Corey Minyard <minyard@acm.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Chris Chiu <chiu@endlessm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Upstreaming Team <linux@endlessm.com>,
	openipmi-developer@lists.sourceforge.net,
	Corey Minyard <cminyard@mvista.com>
Subject: Re: [PATCH] ipmi:pci: Blacklist a Realtek "IPMI" device
Date: Mon, 26 Feb 2018 08:48:07 -0600	[thread overview]
Message-ID: <5ae019f4-a997-fe96-4f16-c12893b816cf@acm.org> (raw)
In-Reply-To: <CAHp75Vd8mEZRTVYiR5Nz4X8HM8VUHArc5C1SyfN4K8c-Y9+taw@mail.gmail.com>

On 02/26/2018 08:34 AM, Andy Shevchenko wrote:
> On Mon, Feb 26, 2018 at 4:50 AM,  <minyard@acm.org> wrote:
>
>> Realtek has some sort of "Virtual" IPMI device on the PCI bus as a
>> KCS controller, but whatever it is, it's not one.  Ignore it if seen.
>> +static struct pci_device_id ipmi_pci_blacklist[] = {
>> +       /*
>> +        * This is a "Virtual IPMI device", whatever that is.  It appears
>> +        * as a KCS device by the class, but it is not one.
>> +        */
>> +       { PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x816c) },
>> +       { 0, }
> { PCI_VDEVICE(REALTEK, 0x816c) },
> { }
>
> ?

That's better, thanks.

-corey

>
>> +};
>> +       if (pci_match_id(ipmi_pci_blacklist, pdev))
>> +               return -ENODEV;
>

  reply	other threads:[~2018-02-26 14:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-08  3:01 ipmi_si fails to get BMC ID Chris Chiu
2018-02-08 15:53 ` Corey Minyard
2018-02-09  3:09   ` Chris Chiu
2018-02-09 13:34     ` Corey Minyard
2018-02-14  2:44       ` Chris Chiu
2018-02-14 17:17         ` Corey Minyard
2018-02-20 17:52           ` Chris Chiu
2018-02-26  2:50             ` [PATCH] ipmi:pci: Blacklist a Realtek "IPMI" device minyard
2018-02-26 14:34               ` Andy Shevchenko
2018-02-26 14:48                 ` Corey Minyard [this message]
2018-03-13  7:27               ` Daniel Drake
2018-03-13 11:59                 ` Corey Minyard
2019-01-22 16:17 ipmi_si: 90 s delay in system start with 4.14.94, but not 4.18.6 Paul Menzel
2019-01-22 20:58 ` Corey Minyard
2019-01-23 16:25   ` Paul Menzel
2019-01-23 16:27     ` [PATCH] ipmi:pci: Blacklist a Realtek "IPMI" device Paul Menzel
2019-01-23 16:32       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ae019f4-a997-fe96-4f16-c12893b816cf@acm.org \
    --to=minyard@acm.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=chiu@endlessm.com \
    --cc=cminyard@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@endlessm.com \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®