From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7422CC7EE2D for ; Mon, 22 May 2023 10:18:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232504AbjEVKSH (ORCPT ); Mon, 22 May 2023 06:18:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbjEVKSE (ORCPT ); Mon, 22 May 2023 06:18:04 -0400 Received: from 189.cn (ptr.189.cn [183.61.185.102]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 586A8D2; Mon, 22 May 2023 03:18:02 -0700 (PDT) HMM_SOURCE_IP: 10.64.8.41:35068.1997184214 HMM_ATTACHE_NUM: 0000 HMM_SOURCE_TYPE: SMTP Received: from clientip-114.242.206.180 (unknown [10.64.8.41]) by 189.cn (HERMES) with SMTP id 9D59E1002F0; Mon, 22 May 2023 18:17:59 +0800 (CST) Received: from ([114.242.206.180]) by gateway-151646-dep-75648544bd-xwndj with ESMTP id 386118d5a73a46768adbda9158d7dc68 for kernel@xen0n.name; Mon, 22 May 2023 18:18:01 CST X-Transaction-ID: 386118d5a73a46768adbda9158d7dc68 X-Real-From: 15330273260@189.cn X-Receive-IP: 114.242.206.180 X-MEDUSA-Status: 0 Sender: 15330273260@189.cn Message-ID: <5ae49b7a-b8d2-a822-65bc-6a894d2b1b4e@189.cn> Date: Mon, 22 May 2023 18:17:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v14 1/2] drm: add kms driver for loongson display controller Content-Language: en-US To: WANG Xuerui , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Li Yi , Sumit Semwal , Christian Koenig , Emil Velikov Cc: linaro-mm-sig@lists.linaro.org, loongson-kernel@lists.loongnix.cn, Geert Uytterhoeven , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Javier Martinez Canillas , Nathan Chancellor , Liu Peibao , linux-media@vger.kernel.org References: <20230520105718.325819-1-15330273260@189.cn> <20230520105718.325819-2-15330273260@189.cn> <26fd78b9-c074-8341-c99c-4e3b38cd861a@xen0n.name> <331e7baa-a83b-b0c9-37f7-0e8e39187df4@xen0n.name> From: Sui Jingfeng <15330273260@189.cn> In-Reply-To: <331e7baa-a83b-b0c9-37f7-0e8e39187df4@xen0n.name> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2023/5/22 18:05, WANG Xuerui wrote: > On 2023/5/22 17:49, Sui Jingfeng wrote: >> Hi, >> >> On 2023/5/22 17:28, WANG Xuerui wrote: >>> On 2023/5/22 17:25, Sui Jingfeng wrote: >>>> Hi, >>>> >>>> On 2023/5/21 20:21, WANG Xuerui wrote: >>>>>> + * LS3A4000/LS3A5000/LS3A6000 CPU, they are equipped with >>>>>> on-board video RAM >>>>>> + * typically. While LS2K0500/LS2K1000/LS2K2000 are low cost SoCs >>>>>> which share >>>>>> + * the system RAM as video RAM, they don't has a dediacated VRAM. >>>>> >>>>> CPU models are not typically prefixed with "LS", so "Loongson >>>>> 3A4000/3A5000/3A6000". >>>>> >>>> Here is because when you do programming, variable name should >>>> prefix with letters. >>> >>> Commit messages, comments, and log messages etc. are natural >>> language, so it's better to treat them differently. No problem to >>> keep code as-is IMO. >>> >> Then you get two name for a single chip,  take  LS7A1000 as an example. >> >> You name it as Loongson 7A1000 in commit message,  and then you have >> to define another name in the code,  say LS7A1000. >> >> "Loongson 7A1000" is too long,  not as compact as LS7A1000. >> >> This also avoid bind the company name to a specific product, because >> a company can produce many product. > > Nah, the existing convention is "LS7Xxxxx" for bridges and "Loongson > 3Axxxx" for CPUs (SoCs like 2K fall under this category too). It's > better to stick with existing practice so it would be familiar to > long-time Loongson/LoongArch developers, but I personally don't think > it will hamper understanding if you feel like doing otherwise. > Can you explain why it is better? is it that the already existing is better ?