From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71415439F92 for ; Thu, 20 Aug 2026 11:50:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787226605; cv=none; b=qLe1BoLu7TLPvXdAG9Spcze9lPdvwkcDbKAwq8v95cA5FrmTDHaEgrSV33FqTPrMNx3ajmhFDRCvK0sD9AW91Kw8u+YEvaYsCPpfDK8U1h4/+TtXwYG5mqfwDOsQJTM1+sNLPIvi+iPShaJzmbRGAz/yg84rBg3XSW7yO9nFlK0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787226605; c=relaxed/simple; bh=bl0WggYJHQcRBL/Oj0BryfftEHgfrnVqyO54aAETY/E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WL/Cc2U1U08D+9qYTo4WIEA0UZNTymk4SQbh6Tl8tSBjn6YoXAVLlSdhgkuIcFWmjtHgoHq16UCp7aJf4OyGY2BJ80zoHpXHG8vYEjmryPjkZFZR1a+XRGyvJtAjX9i67EGnpYErSEz1kVmmlKiwClm2PnMgwq0DimKZVe1HJzA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ip4MJoKd; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=cBoQFDjs; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ip4MJoKd"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="cBoQFDjs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787226601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4InsbEuz38UlO6o4la7QKLe0Bq1AWg3NL4Zc06nTVR0=; b=ip4MJoKdRmeO02SUT/JWBzVZcvTYzrAAEDT9+I3xpJFi4b1r6PkCXTQTtRLsLaR9eu0pU4 8murv8ZHzbQnLdCJykyaPyFOPwNkK7ug7sIwL0o5/v8kM4JbXIhKk7vIMbf41IHFISbHNA ZQAsl1Novsa0Tk6DHjj4NdRs7rksG04= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-601-EUtHxHJ5P0SsTYLHIadfgA-1; Thu, 20 Aug 2026 07:49:39 -0400 X-MC-Unique: EUtHxHJ5P0SsTYLHIadfgA-1 X-Mimecast-MFC-AGG-ID: EUtHxHJ5P0SsTYLHIadfgA_1787226578 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-c11f2b9f62fso160594966b.2 for ; Thu, 20 Aug 2026 04:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787226578; x=1787831378; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4InsbEuz38UlO6o4la7QKLe0Bq1AWg3NL4Zc06nTVR0=; b=cBoQFDjsdaMqzKFPuoHD/b4MpnHvyHlhgYBwvyhV70WHAiyT0D2TIAw1VUDHU1oLxY UInHHK3uKx+9ZlMoWH0vR/KngsrM8i5t60xSmGHALrDZr6uf5TsjQJIdKFVxMjypIY1K L5mHqwLYXEYXFnl7gA1C34ScD5Ii6Ar9AAZcfbnQZWHEPvSyBRWbUKK+oK1ijcv5oKFA ZxrziD4PGL7JSbhQgqbAqxXd1X4YkwyAS4VXLyKClBUv/+TRFtLdQXEciPpDJQVKcD6r zh3gAmca4e+lqKtXeSX+Yrh3BHjShsdscD6FTF/DTpcowNkX0JqShQSMdMwrjDPh6lFY u6Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787226578; x=1787831378; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4InsbEuz38UlO6o4la7QKLe0Bq1AWg3NL4Zc06nTVR0=; b=PksSQTWnu/LKL0+TBEl+Z+CH28HG+2OaFJQ+e6RT0TBBBAxJ9p21vN5xCJaOi+G1t0 9e5ruL3gTMZMCfwE+yv1mTat75sEWg0ue5GVO7/faq+U53Wx+R+XLvFDmMR268cISrLz pcfnZfp0q4akEDb81e6fD4YdoUwFcUAwWMBx4B+Wz1ffcYD51/2A96xuidWbTgpjOZM4 Aqzv3ir3ZOupJ4fSESEwSD4vAhe8SZh/JY1jQKjdxPePdX0CT6OYbR24YEXK2gQu1Naq /YQGuL+7VVk2IxDjMLLCXvRrvTTk8pqMNgIvBhZIn+co5gvDt7OgsvWDtBfrFK9a4xU1 4OFQ== X-Forwarded-Encrypted: i=1; AHgh+RqI6ugLVURXgPP4CWV3QHMb9uTL6F6N93BZHnG/fAFZ5QQyeSt29Xrgm8lgZkCnUeDDrPQehvCPnCGwR0U=@vger.kernel.org X-Gm-Message-State: AOJu0YxggOQQiefXXG962bJZyFSfWZWMxL44/zhV+IVbsODsY9wBmXDS Oj18+I3p3pKT+g8lj7dug2tVjE587GjNVsdUD6L2cCSITUI3Y1xJ1YF7XT9Gb7qooARykYiGf6W 5VsYmAwtqHXHtqEAlySsgXmpeb9cc56whxW7kSEQK+9ssr+p5TpAbKJnXpRS/mQqfew== X-Gm-Gg: AR+sD1155HeAcuYBr8PbV3haawGlRo+d/HlMM5eAbjezPlPQt56MnHPQXEUkh/fIN4+ PBWgihuJ3s3J07Y7HXTYT5JNhgxBcIBXwnIiO8REocxOqvpx2wgbSQ+776Kwi76te4mEnDhMQX7 EEXKZBb/y2PaTsXkNIf2EABPk6ozciwllvoopCJ0JDJOH3/9ma1YdHYT/Fy5swSZNxVTrP7wY02 EM//UdD5nmy2KByKMo7Lx83/2E0gyYDaT5SV690zK71MEbunay0e4Bf0TD7EailtUHEKhZfC2ny HIiFZYvcjVwIM8ntt/Wz7AI/QHtAh7JLm4kjMpkmBfzhTy0i+NwhvlfjsUWM/YGdArlJpe9/FVJ E72GFWBLJHKiwaO8kB2hdUH4bVsQrVSndMEUKerHp+fqGrlPsrbS+lIr61RsuXR8pQw9JE9ASnd M= X-Received: by 2002:a17:907:d48c:b0:c20:83b1:396c with SMTP id a640c23a62f3a-c242e1d0eacmr931170666b.17.1787226577849; Thu, 20 Aug 2026 04:49:37 -0700 (PDT) X-Received: by 2002:a17:907:d48c:b0:c20:83b1:396c with SMTP id a640c23a62f3a-c242e1d0eacmr931166166b.17.1787226577395; Thu, 20 Aug 2026 04:49:37 -0700 (PDT) Received: from [192.168.188.103] (ip239-44-231-195.pool-bba.aruba.it. [195.231.44.239]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c24591df739sm57323266b.49.2026.08.20.04.49.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2026 04:49:36 -0700 (PDT) Message-ID: <5ae54784-8076-4b3a-a2fe-14fe64485571@redhat.com> Date: Thu, 20 Aug 2026 13:49:35 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2] net: dsa: mv88e6xxx: Avoid uninitialized value on MDIO read error To: Ruoyu Wang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260815151713.3757248-1-ruoyuw560@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260815151713.3757248-1-ruoyuw560@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/15/26 5:17 PM, Ruoyu Wang wrote: > mv88e6xxx_mdio_read() applies the internal PHY model-number workaround > before returning a Clause 22 read error. Since the PHY read may leave > val untouched on failure, the workaround can consume an uninitialized > value. > > Return the PHY read error immediately after dropping the register lock. > Successful reads continue through the workaround and return val as > before. > > This issue was found by a static analysis checker and confirmed by > manual source review. > > Assisted-by: unnamed:deepseek-v4-pro typestate > Signed-off-by: Ruoyu Wang ## Form letter - net-next-closed We have already submitted our pull request with net-next material for v7.3, and therefore net-next is closed for new drivers, features, code refactoring and optimizations. We are currently accepting bug fixes only. Please repost when net-next reopens after Aug 31st. RFC patches sent for review only are obviously welcome at any time. See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle