From: "Arnd Bergmann" <arnd@arndb.de>
To: "André Almeida" <andrealmeid@igalia.com>
Cc: "Christian Brauner" <brauner@kernel.org>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
kernel-dev@igalia.com, "Masami Hiramatsu" <mhiramat@kernel.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
linux-alpha@vger.kernel.org, linux-s390@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, soc@lists.linux.dev,
linux-mips@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v6 00/13] syscalls: Add a shared table for all archs
Date: Thu, 17 Sep 2026 07:55:56 +0200 [thread overview]
Message-ID: <5aedf90f-d30d-4f55-b066-dd8fdf3ff8f9@app.fastmail.com> (raw)
In-Reply-To: <6fa4e1e3-c023-465c-9490-ce2f18ffaa91@igalia.com>
On Thu, Sep 17, 2026, at 00:19, André Almeida wrote:
> Em 15/09/2026 04:45, Arnd Bergmann escreveu:
>> On Sat, Aug 29, 2026, at 01:19, André Almeida wrote:
>
> Thanks for testing! I believe I found a simple solution for this. I
> modified syscall_o32.tbl and can confirm it triggers a rebuild now:
>
> diff --git a/arch/mips/kernel/syscalls/Makefile
> b/arch/mips/kernel/syscalls/Makefile
> index aaa5443ea906..9e31d1ce5015 100644
> --- a/arch/mips/kernel/syscalls/Makefile
> +++ b/arch/mips/kernel/syscalls/Makefile
> @@ -40,10 +40,10 @@ src_n32 := $(src)/syscall_n.tbl
> src_n64 := $(src)/syscall_n.tbl
> src_o32 := $(src)/syscall_o32.tbl
>
> -$(kapi)/unistd_nr_%.h: $(systbl_common) $(sysnr) FORCE
> +$(kapi)/unistd_nr_%.h: $(systbl_common) $(src_%) $(sysnr) FORCE
> $(call if_changed,sysnr)
>
> -$(kapi)/syscall_table_%.h: $(systbl) $(systbl_common) FORCE
> +$(kapi)/syscall_table_%.h: $(systbl) $(systbl_common) $(src_%) FORCE
> $(call if_changed,systbl)
I had tried the same thing already, but in my testing, it did
not rebuild after changing the syscall_n.tbl file, only the
syscall_o32.tbl file. Can you verify that your change rebuilds
all nine files in the correct cases?
>> The rt_sigtimedwait and ustat entries had a typo that caused a link
>> error, but I did not check if there were any additional mistakes that
>> caused incorrect output data without causing a link failure.
>>
>
> Ops, my bad. I had another round comparing the tables, and I found
> another case that needed a fix:
>
> diff --git a/arch/mips/kernel/syscalls/syscall_n.tbl
> b/arch/mips/kernel/syscalls/syscall_n.tbl
> index e3d278f715b7..1882527053af 100644
> --- a/arch/mips/kernel/syscalls/syscall_n.tbl
> +++ b/arch/mips/kernel/syscalls/syscall_n.tbl
> @@ -43,7 +43,7 @@
> 33 common pause sys_pause
> 34 common nanosleep sys_nanosleep
> sys_nanosleep_time32
> 35 common getitimer sys_getitimer
> compat_sys_getitimer
> -36 common setitimer sys_setitimer
> compat_setitimer
> +36 common setitimer sys_setitimer
> compat_sys_setitimer
> 37 common alarm sys_alarm
> 38 common getpid sys_getpid
> 39 common sendfile sys_sendfile64
> compat_sys_sendfile
Looks good, thanks for checking this one.
Arnd
next prev parent reply other threads:[~2026-09-17 5:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 23:19 André Almeida
2026-08-28 23:19 ` [PATCH v6 01/13] syscalls: Make --abis parsing more robust André Almeida
2026-08-28 23:19 ` [PATCH v6 02/13] syscalls: Create unified partial table for all archs André Almeida
2026-08-28 23:19 ` [PATCH v6 03/13] scripts/syscall.tbl: Use the common table André Almeida
2026-08-28 23:19 ` [PATCH v6 04/13] arm: Use the common syscall table André Almeida
2026-08-28 23:19 ` [PATCH v6 05/13] s390: " André Almeida
2026-08-28 23:19 ` [PATCH v6 06/13] sparc: " André Almeida
2026-08-28 23:19 ` [PATCH v6 07/13] mips: Remove duplicated syscallnr.sh André Almeida
2026-08-28 23:19 ` [PATCH v6 08/13] mips: Get rid of custom mips ABIs for syscall tables André Almeida
2026-08-28 23:19 ` [PATCH v6 09/13] mips: Use the common syscall table André Almeida
2026-08-28 23:19 ` [PATCH v6 10/13] syscalls: Add an option for offsetting the common table André Almeida
2026-08-28 23:19 ` [PATCH v6 11/13] alpha: Define entry point for set_mempolicy_home_node syscall André Almeida
2026-08-28 23:19 ` [PATCH v6 12/13] alpha: Remove alpha_ prefix from custom syscall entries André Almeida
2026-08-28 23:19 ` [PATCH v6 13/13] alpha: Use the common syscall table André Almeida
2026-09-15 7:45 ` [PATCH v6 00/13] syscalls: Add a shared table for all archs Arnd Bergmann
2026-09-16 22:19 ` André Almeida
2026-09-17 5:55 ` Arnd Bergmann [this message]
2026-09-17 21:24 ` André Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5aedf90f-d30d-4f55-b066-dd8fdf3ff8f9@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andrealmeid@igalia.com \
--cc=brauner@kernel.org \
--cc=kernel-dev@igalia.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=soc@lists.linux.dev \
--cc=sparclinux@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®