From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11020112.outbound.protection.outlook.com [52.101.193.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38F7B21D5B0 for ; Fri, 28 Nov 2025 06:30:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764311430; cv=fail; b=EzasrhtM7e7I81faajM0PG5nZDbWjavkKFb+DL5oezPdJ/AUIgJgPq8yLtdavUcYX91z566c+Z4d2SqoLYijkmAGBKEVswoOdjNlvuRMUEsc+u79HYAMotlTZ5Rl+OzRjsid0J24krngjTO6KkfI17lyfVW9GQiPJd5B2sO7j4Q= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764311430; c=relaxed/simple; bh=Q/73uVbfKySFE7/I+9zjLWQ6d3DWa2dNWRE54vUjNXI=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=GsXQhD8pCk438rm/+IruLkS4r+gs/uXQdWLqXmwJZO0ShBe0f7DNkLVnc++d3gEll5vdtnE9Bhc3MEpZ0F1uk1Gyawoj03GjNsMQbUcegcizi5KCafLtLebXSeUNqVLfrYq6y8wDXvwvmdMa6K+7S0j2pHonPAu2Us29VUxXFx0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=amperemail.onmicrosoft.com; spf=pass smtp.mailfrom=os.amperecomputing.com; dkim=fail (0-bit key) header.d=amperemail.onmicrosoft.com header.i=@amperemail.onmicrosoft.com header.b=dA9AL8pr reason="key not found in DNS"; arc=fail smtp.client-ip=52.101.193.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=amperemail.onmicrosoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=amperemail.onmicrosoft.com header.i=@amperemail.onmicrosoft.com header.b="dA9AL8pr" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=y29XixbDUBaLHXSpDzNhppLN4baHiXfXqhzp1yZnAQHXwKAk6kQdQgeZI3IdXoyg5Wz0LlGlTJOU6/KUMC9El1v7nk7dISAPQd25AwzfQxWu248pIezPFrvA3abT7lFwQrQUPH+jU74bARKKfDLxwZoJdtSye4s+I9TJ0PU8BROakn81EfAuRGcUuei1aoio5azYV5b6R2hVH41mlKf384zodh8w5e3/4RuxMKBrYNt5Nhr4BcGQX5w7YJ23YNuZ/VYu0RneocxleThJtYCFn/xWGmUva1xv55jniy+aQh8CcI0VVCg0bZ+FwLGJ7snwydDtNNh7LsG8MDjvRiDlwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q/73uVbfKySFE7/I+9zjLWQ6d3DWa2dNWRE54vUjNXI=; b=Z7dKnQHLhFx4WNuLtpX0BdMfR2D8Vb4nqEKk8zjXDS7A9t4/yanH0OivYd9kdexJLIpfw2fFW2mmMZSdwljPK+8fyNYz1nzL35hoD1MBgS0I64yFMGm1EfHVAwjtN0ToiKoMWbv7sgkhR59wmgowpIqq0dYNfAbHWRfq57KT3U9IWFueQGMNnf6Jeisz8ThsQ6URDFy8nP65YCHE8sN/BA7R0H+BLcWeMMQEu5iQYhuc0BCtyYEI5A5YzaTpx+qfjUJtKeX0SdQpujKt61PMHWF0bEUnkda9ASbxWdJ+Sm4fui65fik9GeI12ztrSUd+G5Kkt/kq+sWKeNyX5rjuUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q/73uVbfKySFE7/I+9zjLWQ6d3DWa2dNWRE54vUjNXI=; b=dA9AL8prfEK88sZQkESctHIqyJ49EvZcBxw08cf0LG6VyIJkan/yILeggISywRmoFtRM3owpiEvcCtYlFlN6UuUDIlu7AdexhpoKi3HWZFkT8JBBF88avbjY7hCZiloBhYMlvDRaGa09Ri4uVsA2BFI0QNFRRnWa43RSuDpdWGo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from PH0PR01MB7975.prod.exchangelabs.com (2603:10b6:510:26d::15) by SJ0PR01MB6256.prod.exchangelabs.com (2603:10b6:a03:2a2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.11; Fri, 28 Nov 2025 06:30:24 +0000 Received: from PH0PR01MB7975.prod.exchangelabs.com ([fe80::6926:a627:118e:8050]) by PH0PR01MB7975.prod.exchangelabs.com ([fe80::6926:a627:118e:8050%4]) with mapi id 15.20.9366.012; Fri, 28 Nov 2025 06:30:24 +0000 Message-ID: <5aef850b-86b5-45f7-81ef-d1d08fd2a673@amperemail.onmicrosoft.com> Date: Fri, 28 Nov 2025 14:30:03 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] sched: update the rq->avg_idle when a task is moved to an idle CPU Content-Language: en-GB To: K Prateek Nayak , Huang Shijie , mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org Cc: patches@amperecomputing.com, cl@linux.com, Shubhang@os.amperecomputing.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, linux-kernel@vger.kernel.org, vschneid@redhat.com, vineethr@linux.ibm.com References: <20251127091450.250797-1-shijie@os.amperecomputing.com> <20251127091450.250797-3-shijie@os.amperecomputing.com> <14d4ab40-aa3e-48de-99f5-4f1d799b5f7b@amd.com> From: Shijie Huang In-Reply-To: <14d4ab40-aa3e-48de-99f5-4f1d799b5f7b@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: KL1P15301CA0037.APCP153.PROD.OUTLOOK.COM (2603:1096:820:6::25) To PH0PR01MB7975.prod.exchangelabs.com (2603:10b6:510:26d::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7975:EE_|SJ0PR01MB6256:EE_ X-MS-Office365-Filtering-Correlation-Id: 29fa603a-458d-4517-b780-08de2e479cc9 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YmtBaURmVy9TcDNMbloyWXpZZEZsRlNRdXJmMWVSa1J4dXJVV1AwL2pEdXV3?= =?utf-8?B?NitYRi9vSzhCRVEybnIzUDFRbXpxZFBTS2tpdHJZMHpoeXBxMFNqM3NNQ0Zp?= =?utf-8?B?UWpmUWM4d0lLYk1DMkQvV0poWGVxN3J2S24xa3NGL0FNOFIxU2R0Z1JQSDcx?= =?utf-8?B?bHQvYXdoamFIQmxuOFo1SXJXbVpBT1FCaXFhai9zNXF3NWxOMzdia0pLbXVv?= =?utf-8?B?ZDlhNlcxRlJKRFVIcWdDOTlBbjV4cDNsSDRBWkd3MGoxMmhQYWlZWTgxTTZn?= =?utf-8?B?SUlrV0Znd2IyYkFyWDNEUlVhcmJ5d3l5aWExMnk0RW9wVmlaUDI4dDBuZFlm?= =?utf-8?B?VVNCZ1hrQ2llMytMZytmRmdzSU9qa0FPNmJjWXg2K3lpTDNBK1F0RXIyYmp2?= =?utf-8?B?WGpEWWFwYkFtYTdBYnV6M3hJWGhrK3A1Tk5KWndRTFV2VlZFOEJTazRZQjRS?= =?utf-8?B?UTViUU1ieXBBOG5qbXdwZTA2ak1iQ05ZUkR4L0xKaklaRlRLQXNweldyTzhO?= =?utf-8?B?S3RxWjIybTRxdU5Uc29MUzNwVUJOSDdhT3JaZEVyT3JtaTRYektaeUtFL3ZL?= =?utf-8?B?TTY3MUJDQlRKcWM4UFYySkp5Zzl1Y0w0eGxwUGFCcWY5MlZFa0tWd0hucTdV?= =?utf-8?B?UGtCZnZ1c1ZNSEJ1Rm8wbjFzRnNtZ2hsTjFEWjZiSFdwNGxiTWhLQjN0OWVE?= =?utf-8?B?UU01UUp3cUhVRWlEZm9PdmdRdDJhZjZJOG5XOU96T2FTMGh4cFdMMHdhMCtk?= =?utf-8?B?K3BsV3RlNlFWOHFKdG5GbGJPTXRsbjJ4eHJKVENYUklXYU1wV1l0QzJVQWJM?= =?utf-8?B?LytKQzY3RWduL01sclBUbU5JdFNKK25oSkRna1ViNVN6ekJ2YXZoV2JzT0dO?= =?utf-8?B?ZHlMSHBkTWxsNXkvRy80NWEweHU2eFZxTFAwd1pkOUZ4ZTF5Q2VNd2pabTJ5?= =?utf-8?B?UlMvRytwMmRpZlIwNk95aE12RWxRb1oxWHZkeTIzQSs1b0xoR1R4UnA4YmtR?= =?utf-8?B?aS9jNzczNUx2NU1sYUJiMmxPMnRGWVBQTXBDSVYzbWNDbU1QeU9VM0w4d052?= =?utf-8?B?RktRMDBUanIxUU5VQmZoUnpWcjdQNnBSUStMd1h2emZ2R2E5dnp5SXYzQ1Fx?= =?utf-8?B?YzZrejRoZ1BZdzVFNG04MURkT01GQzkzdW9JNGpIc1JiTWFQb0txcm1QajF6?= =?utf-8?B?LzVJREZJT2lTL1NTSVpuYWpnMDBDd0FVU1EyNExiQ3ZVdUs3c3IwZkVxditH?= =?utf-8?B?a0h5WWJKTXZ2OFhGV0FZdXBIckpaWEpuWXcvMlU0TGZidWRqZEJyTDdlZTF4?= =?utf-8?B?Qnc5OG5aSjM0NnoxWmRHN3pROTRkdTJlOHI2T1BLMC84ZHprVDlRSktGTS9x?= =?utf-8?B?bUpYWG5ZMW1NV2NEcUUvTFFvWlJRZVVEOXk4V2VOREYrV2xOSVJrVUN1NFo4?= =?utf-8?B?cHVVTmI4QVg5b1VQci84L0pOV2I4Z2g2c016YWZnbVdEclBsUzlhV1RnL2lo?= =?utf-8?B?VDc0b1ZYbkVhb051WVZydDVvM29hMzZwSFhPTDF0NllBR0dGak9NM3p5VXcw?= =?utf-8?B?amw4b3BRakk1YXlOc01Rc29NUGd5WklmR2lzais1VnBCSFJNemM0ZkxOcGpp?= =?utf-8?B?UkhiY29EbWtGeUc0M1pTMlBlYWZHY1B6WE5FZk1KMXhzcVA4N0tPWEpYS0Rp?= =?utf-8?B?eks0dmhhZHJVRi9uSjJvTTM3eTRna2FSTEtUR1JFOEk2NEdwYXd3ZksvN09p?= =?utf-8?B?Z1ppWUlGWmFZLy9teHNzMGpTY0lGK01yWkJmOVFneVV1ZmpJNkpUOEYyOFVu?= =?utf-8?B?UkE3TCtPSWZpVG1lRTQ2aEhSM0JPQm80ajFJUjAyMmd6WER4NHEwWDVicnJD?= =?utf-8?B?Q3dhcUZmVnBRNGNvdjJnVjlBRXlXSDAxYW5Qd3JteitBQmJPM1N6TGR2STVv?= =?utf-8?Q?FgwLFymiX6B3gkyrXSMUVZqFzWRKCaVG?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB7975.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R21HSGtJWDYxNkJHSUY1ZWhpdGNoUTdhYWMxMG81WVM4bHdpWEQrYU5BZXh6?= =?utf-8?B?UGZCUVhvS0M5Zjd6OUpybEJIWnJSeTQrcUZ6OEhsWGQwaUsvYkEwZEY5QkRh?= =?utf-8?B?eXVxODZ4alVaUVcwMzBLU04vR3d5L1NWSmhmMFV2UXZVbTF3L0hZbStXbjQ4?= =?utf-8?B?bm56ZTU1M0pTV25UUkdUMU5sUGpDQk1UdTI4M1dqZzhNQm1SU2o3SGpEWUVa?= =?utf-8?B?R1loazRUUXYzT0U5eWdSS2QzYWdiVmovcmk4dFNlMmdIZzIzUit0MFdyVGxt?= =?utf-8?B?VVpTcmlpWnJrVno1OGhyWE1GNDdJd0ZwY205RGpaN05BSVJYdVlreHdVbEtK?= =?utf-8?B?VTJyNWtza3JGbFV0cHFkMlh4VnYzMThJeEV4MVE1cjJRUDZaUS9hM0J5Z0ZR?= =?utf-8?B?ZHdiVHpNWlFROHNaMHhtZHdsd2hxTUNYUjUxWDV2VDdrc0ZDbHpqZ011VzlN?= =?utf-8?B?dFJlL0xFeE4ydlMyQ0VIR1lsT2dyc1hOdVJwVWtJZ0NBalNmajZPZ0lKUzRw?= =?utf-8?B?RE0rWUtFZDBnOWV6bC9qVVJaK3BNengwamc1TXZYYi9hM3c5M3ZMR25SOEdC?= =?utf-8?B?UDlmTSt1NmxDa1VuOG5CekszSlcrUTNnWXhOY2lUc2Jud0VVdWh3c3RORjBB?= =?utf-8?B?ZjNlbFNPK2JDT2ppYU11S2JncGRpYktwdit2WnUva1ZPR3ZrUW9uUkpkeVlk?= =?utf-8?B?L3NOV0s1K0pBM3hPVzRQNHJzNWhmZjZ5SEx5a3VQeXRuTGs5R01Cc0hjeWtt?= =?utf-8?B?TVo3UEIvYmVlS09YQThtMEFVdTRndXZXVEVrTll2NVZlNGEyQzJUOVJPUFdr?= =?utf-8?B?L1lIV25FK0ZTQWlqelZSaVpDeDBsank3UHJZeDJOMkprbDNWQ0FBQUxXTVdE?= =?utf-8?B?Q09Wc0tmMWFGR2YxQnRLSHR3ZlFpVXJ1a1p6b0FpejNjTGQ4WWh0Y1JtK2Fv?= =?utf-8?B?VWxGdGtqYjdKL1hEMjhabUFZbHBJZ1hISm15dWVHSjgwbWwvQzNuR0U5MFpj?= =?utf-8?B?eDdublJER1JickMzTG1vQzlhRnhQZ3ptRTV5NkxyYWZQeTZJWXc5dXYvTGJy?= =?utf-8?B?V3FNa0Q2R3E0UmxJQ2NuRWVzL2lJajdwSGsxQndPRUZnQjFWTHBXM0N5VzRY?= =?utf-8?B?bjkyN1E3QU81WWRMbUVsdjR1blYzMVBmSXFDTnM1YXVMTWZYa0xBMFZmZDRq?= =?utf-8?B?YUkvbU9BbGxHUVhvVS9UTXRMRHZjNHBNS1FPUURBNjdyNVJwQkRsM1p4TGl5?= =?utf-8?B?YXFUVFJuTldSc2NWWENVRlhkMHYwN1VLT0MzS3pKQUxNUlR5VHlTM25Kdmkx?= =?utf-8?B?SFh5TG81Rm1Ha2VLS0M1ZUEvY0tQMUtJS2tLemtTUXdNcjMvYmdYZUN0V21x?= =?utf-8?B?OXZuWktqL091NnJTY0xvYkdVYUtvUndjc3NsZWpUL1VmRFZrc2FkRjZCMDR4?= =?utf-8?B?OTk5TzFLMVlMVEx2TTRGTmNQRTZIcks2UUM3YVVRaEV6amcxQnJnUlFEMzdL?= =?utf-8?B?OGt5RWVmakFyY3NxU0hjbUVoV09ST3ZJSm9VV1hzZ3kzM2dueFVZSDFVWHIr?= =?utf-8?B?YnhBdEZPWUZjZzJ3RkZxay81RHFiMEwzczRWbEZMMnluTTZYVTFnY1RPMmFB?= =?utf-8?B?RmNnZXpUamJEQlNWYnZpUVhONzdnMnFRQlVRZVhJZVVoaTFPZHpFTXRVdlNT?= =?utf-8?B?Zkt2b2szU1JQNDh0ZVlhZlN6ZDZQN2g5dWl0ZWM0aDlxRVM5QklPZldGeXBI?= =?utf-8?B?NGZJRWtLNjZrZ2hFcTEySWNwcXZuSzFIYnlqRDlXcFM1UjBuWGgwSVBlcFRS?= =?utf-8?B?YXBrM2FOQVZqM3g0M3AzeVJrSVV5dE5BWnVISVFzSGJPWHppZlZSWHBOb0Fv?= =?utf-8?B?TlkwaHRMbGpRbWw5ZUlia1VQdUg2TWFnaFJhT1BUdG8vUFhHT3RyMm1tRVMx?= =?utf-8?B?QVl6UzB0YjBlWXB5VmREOERtMkYvZTNPa2VHRmhkYmx4SnlNWC9idFFIamNL?= =?utf-8?B?N3JPTmo0ZDBMbUsvSkZLbURJaEdLOHp6WFV2NGxad0ppMTBFSkF5b2dBekdP?= =?utf-8?B?UmJsKzFjSDUvT1FWeEMrZ0dvTlhIV1NyYnpxMHVwT2V1dVJRODJvYkNPbHpy?= =?utf-8?B?SGVKck1iQ0l1aVhqTFZQSHZYMm9VcVh0aUsrMTFveXErNHBmL0I1WVRvYnBV?= =?utf-8?Q?8BKMt63O3d/pZ48B1icitlw=3D?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29fa603a-458d-4517-b780-08de2e479cc9 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7975.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2025 06:30:24.4879 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hLaNtLVr4HhkXxUW0q+7riYuJeoghXPUCe+tj6B7vLrag+HMUIaGCm+EunEF3oZRI78cK0YOlT7IHFbJHaPmGCIAZskfjGWZRXF12Q6jAX43KOtY/LzeMFD7FaiwgX2L X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR01MB6256 On 27/11/2025 18:12, K Prateek Nayak wrote: > Also if we've done newidle balance and the rq->idle_stamp is > set, we cannot have delayed tasks since pick_next_task() would > have dequeued all delayed tasks before reaching newidle > balance. Yes, you are right. > Just doing a update_rq_avg_idle() unconditionally should be > fine. okay. Thanks Huang Shijie