mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ravi Bangoria <ravi.bangoria@amd.com>
To: Huang Shijie <huangsj@hygon.cn>
Cc: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
	<namhyung@kernel.org>, <zhongyuan@hygon.cn>,
	<fangbaoshun@hygon.cn>, <yingzhiwei@hygon.cn>,
	<mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
	<jolsa@kernel.org>, <irogers@google.com>,
	<adrian.hunter@intel.com>, <james.clark@linaro.org>,
	<tglx@kernel.org>, <bp@alien8.de>, <dave.hansen@linux.intel.com>,
	<x86@kernel.org>, <hpa@zytor.com>,
	<linux-perf-users@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <liuqi@hygon.cn>,
	<lijing@hygon.cn>, <wangfengyu@hygon.cn>, <wujiangyong@hygon.cn>,
	<shijie8@gmail.com>, "Ravi Bangoria" <ravi.bangoria@amd.com>
Subject: Re: [PATCH] perf/amd/ibs: add phy_addr_only software filter for ibs_op
Date: Tue, 27 Oct 2026 14:44:53 +0530	[thread overview]
Message-ID: <5af2d381-408f-442e-bba3-5bfeca01161f@amd.com> (raw)
In-Reply-To: <20260902085251.4046240-1-huangsj@hygon.cn>

> We use the following command to track a process's memory footprint:
>   #perf record -e ibs_fetch// -e ibs_op// -p xxx --phys-addr -- sleep 10
> 
> In the mysql tests, I catched over 1,804,973 records for ibs_op event.
> I found that over 53% records(970,554) are like this:
>         ibs_op//:  ffffffffb6017739               0
> 
> The physical address is 0 for these records. These records are not needed
> by us, and they wasted the CPU cycles.
> 
> This patch adds an ibs_op/phy_addr_only term that discards samples
> without a valid physical address (dc_phy_addr_valid == 0) in the interrupt
> handler. And it avoids the phys_addr=0 noise when used with --phys-data.

Why not simply use the BPF filter?

  $ perf record -e ibs_op// --phys-data --filter 'phys_addr != 0' ...

Thanks,
Ravi

      reply	other threads:[~2026-10-27  9:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02  8:52 Huang Shijie
2026-10-27  9:14 ` Ravi Bangoria [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5af2d381-408f-442e-bba3-5bfeca01161f@amd.com \
    --to=ravi.bangoria@amd.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=fangbaoshun@hygon.cn \
    --cc=hpa@zytor.com \
    --cc=huangsj@hygon.cn \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=lijing@hygon.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=liuqi@hygon.cn \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=shijie8@gmail.com \
    --cc=tglx@kernel.org \
    --cc=wangfengyu@hygon.cn \
    --cc=wujiangyong@hygon.cn \
    --cc=x86@kernel.org \
    --cc=yingzhiwei@hygon.cn \
    --cc=zhongyuan@hygon.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®