From: Matthieu Baerts <matttbe@kernel.org>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
"Mat Martineau" <martineau@kernel.org>
Cc: Geliang Tang <geliang@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Donald Hunter <donald.hunter@gmail.com>,
Davide Caratti <dcaratti@redhat.com>,
netdev@vger.kernel.org, mptcp@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] netlink: specs: mptcp: fix port endianness
Date: Wed, 11 Sep 2024 17:07:35 +0200 [thread overview]
Message-ID: <5b013e5c-7598-4b84-a60f-a3f58f70afaa@kernel.org> (raw)
In-Reply-To: <20240911091003.1112179-1-ast@fiberby.net>
Hi Asbjørn,
On 11/09/2024 11:10, Asbjørn Sloth Tønnesen wrote:
> The MPTCP port attribute is in host endianness, but was documented
> as big-endian in the ynl specification.
>
> Below are two examples from net/mptcp/pm_netlink.c showing that the
> attribute is converted to/from host endianness for use with netlink.
>
> Import from netlink:
> addr->port = htons(nla_get_u16(tb[MPTCP_PM_ADDR_ATTR_PORT]))
>
> Export to netlink:
> nla_put_u16(skb, MPTCP_PM_ADDR_ATTR_PORT, ntohs(addr->port))
>
> Where addr->port is defined as __be16.
>
> No functional change intended.
Good catch. Indeed, this port attribute is supposed to be in host
endianness.
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
This patch can be applied in netdev directly.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-09-11 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 9:10 Asbjørn Sloth Tønnesen
2024-09-11 12:42 ` Davide Caratti
2024-09-11 15:07 ` Matthieu Baerts [this message]
2024-09-12 3:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b013e5c-7598-4b84-a60f-a3f58f70afaa@kernel.org \
--to=matttbe@kernel.org \
--cc=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®