From: Jens Axboe <axboe@kernel.dk>
To: Colin King <colin.king@canonical.com>,
Matias Bjorling <mb@lightnvm.io>,
linux-block@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] lightnvm: pblk: fix resource leak of invalid_bitmap
Date: Tue, 5 Jun 2018 09:20:14 -0600 [thread overview]
Message-ID: <5b0a3b83-5e7d-679e-f2a4-a9305da7c472@kernel.dk> (raw)
In-Reply-To: <20180605151456.20359-1-colin.king@canonical.com>
On 6/5/18 9:14 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the error exit path when the emeta could not be
> interpreted is via fail_free_ws and this fails to free
> invalid_bitmap. Fix this by adding another exit label and
> exiting via this to kfree invalid_bitmap.
>
> Detected by CoverityScan, CID#1469659 ("Resource leak")
Looks good, applied.
--
Jens Axboe
prev parent reply other threads:[~2018-06-05 15:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 15:14 Colin King
2018-06-05 15:20 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b0a3b83-5e7d-679e-f2a4-a9305da7c472@kernel.dk \
--to=axboe@kernel.dk \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@lightnvm.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®