From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9912EC433FE for ; Tue, 21 Dec 2021 09:05:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236023AbhLUJF1 (ORCPT ); Tue, 21 Dec 2021 04:05:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:35583 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233775AbhLUJFX (ORCPT ); Tue, 21 Dec 2021 04:05:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640077523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rgPifuu1RB0k0LUOxT2X3VnLk1g+LzCMRjZsLuLn63g=; b=SvEAsypBMur7gpsEp+uWKbVp+vEI3c7+wNH7n8S9ZYUC0FCxYvjUL13USumW/sO2V5L8EJ jh/KlgOzGZZi7mWn8JhzswHmOFjSw1AJUYytbWCuZl7YXJ1Fg9I+rBQVvfNMPE83yZKmsN sFDa/VQfbRsJ0F6Mn5Gk5kaMdbCuzoA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-331-l7QwlxDANCCO-YFeN1w7FA-1; Tue, 21 Dec 2021 04:05:21 -0500 X-MC-Unique: l7QwlxDANCCO-YFeN1w7FA-1 Received: by mail-wm1-f72.google.com with SMTP id v190-20020a1cacc7000000b003456d598510so966554wme.6 for ; Tue, 21 Dec 2021 01:05:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=rgPifuu1RB0k0LUOxT2X3VnLk1g+LzCMRjZsLuLn63g=; b=5NASolUkvsgo+7Q2e4r05HBIRqpi8NlGA6qmBVmM9qEBSBw2tNhUE0qjPeg+22ORuu G6xj1PrBWe1W52OG+xV6HNCf2H7Uk0MsQfZ4ccKZLN9XVCE3j6KGRsB4vftmwEJGsX/T aunPszsx3Jz9T8VBWwZBFOpNGoQzfy5l5T5aLETpr/JSuK589AUcFyQciLIu6hoCLCy9 ua5eeA3hLwo/PAOmHFeBWIAji6tiF9jNWeXkVmD6JZpAo5cIVosM6CQSJmlVpgtDikW5 foNNJNXAslwCLJsFS+M2l3pKp+Vki0xlMqIt4doXN3+MNDKxgMgqb6Wtmy09b2VoO8cZ 5sOA== X-Gm-Message-State: AOAM5338BoRBDzU4x4iPZZMQ1dcO119HUJxfCPby4bTKcujhuzKYhA/y KS3iUmsplWcMH5RojHVGa4FuFwYlAoGHiU+nvFkedt0kmqVCYwh1F8mXN7nPZr/SbMLwFqjhi00 FGY9Gh1peCZdhbUNmmdPOr8bf X-Received: by 2002:adf:8165:: with SMTP id 92mr1808681wrm.199.1640077520325; Tue, 21 Dec 2021 01:05:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJwz9dD/lyXn12XSkfz7PrwHF1Fi8hcgYYgOHY1FWx8GoepwZnjYExiR9qO3tS5VayQk7j0WEA== X-Received: by 2002:adf:8165:: with SMTP id 92mr1808655wrm.199.1640077520096; Tue, 21 Dec 2021 01:05:20 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.googlemail.com with ESMTPSA id c11sm1920328wmq.48.2021.12.21.01.05.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Dec 2021 01:05:19 -0800 (PST) Message-ID: <5b0e2e4c-a7bc-b0a5-1af7-df937618b2e4@redhat.com> Date: Tue, 21 Dec 2021 10:05:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2 23/23] kvm: x86: Disable RDMSR interception of IA32_XFD_ERR Content-Language: en-US To: "Liu, Jing2" , "x86@kernel.org" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" Cc: "Christopherson,, Sean" , "Nakajima, Jun" , "Tian, Kevin" , "jing2.liu@linux.intel.com" , "Zeng, Guang" , "Wang, Wei W" , "Zhong, Yang" References: <20211217153003.1719189-1-jing2.liu@intel.com> <20211217153003.1719189-24-jing2.liu@intel.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/21/21 10:00, Liu, Jing2 wrote: > Thanks Paolo. > > BTW do we want to put this together into patch 13 or 14, I guess you were saying patch 14 😊 > [PATCH v2 13/23] kvm: x86: Intercept #NM for saving IA32_XFD_ERR > [PATCH v2 14/23] kvm: x86: Emulate IA32_XFD_ERR for guest No, I meant patch 13 because it is where xfd_err is added to struct kvm_vcpu and the wrmsr is added on vmentry. But really it is not a big deal. You might as well keep it a separate patch ("patch 14.5") so we don't have to argue. Paolo