From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx07-00376f01.pphosted.com (mx07-00376f01.pphosted.com [185.132.180.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F13073F65E4 for ; Thu, 12 Mar 2026 16:29:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=185.132.180.163 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773332989; cv=fail; b=NuQjUCqJPpW+7FNYvKkWGbahquEtX0ltk0JB8hzq7ULV80DmnRxRAJJ2zUa0ahS45RkpauTY8jpqTjcbRZD8catgWrp3uP17FIsA8IRzuwMs40vIbWTHEFIFQZwO1c1e/QdQz88NCNb5zmRIOv0xLe+dB9fa9LHKl/wvm+mB4+U= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773332989; c=relaxed/simple; bh=+YjswI/+8ADEaDxSvhjQ5udCQx3c4GIaLr3dkbWVJBA=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=ol9mHmGBTFaQ9k1EqkNaq/nGLd6TZrgi7fFg+uSKzUjfppptlZS4OBYKpkfj5zCZ96tTfHv76lEL9tTKj/BfwV/+cnhDnc6QmWE2RYLo6CFEc+AEwnifDQEMVQj9QY4PsBMMO4iEKzQG9wegcT9eJWXAVwx3HdfGTUpeKo0IhC0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com; spf=pass smtp.mailfrom=imgtec.com; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b=OcQOOwjL; dkim=pass (1024-bit key) header.d=IMGTecCRM.onmicrosoft.com header.i=@IMGTecCRM.onmicrosoft.com header.b=gh9iQif9; arc=fail smtp.client-ip=185.132.180.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=imgtec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b="OcQOOwjL"; dkim=pass (1024-bit key) header.d=IMGTecCRM.onmicrosoft.com header.i=@IMGTecCRM.onmicrosoft.com header.b="gh9iQif9" Received: from pps.filterd (m0168889.ppops.net [127.0.0.1]) by mx07-00376f01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C6crcU4032919; Thu, 12 Mar 2026 16:29:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=dk201812; bh=HIq3GLRIWTZrD9zUMyEgJEZ9P v91nqKe18E+FjvnYEo=; b=OcQOOwjLb2e+R+qcKuE0914+IHnkAyaGfpQdPu0Ll OjAgOe5dTtYe4nbFJe3SzYsvO66/1tRu9yNQ943HHmQ6uvc9DmUl0EOvaAiVkd2q ScMm8e90UlQ9HK+IeDfvirgIOiaOOtMylrnWzUefmndHqtLA1PBQxW948X7xqgiy 6sL9h3J20dZ7tigMl1NXBMQqNe1qf/Wgp+d4KkmouCPwvzK1A/yEJ71c+1thvwpl FQ+uibTXwrKdbpTAU21uT4esPyPxrZkb61FpJNGfLm1Y6rAOpG5di9z7i4sLOELe P0gT1n8bkliI8jby+w7mnKUkRpObeGYJkjRYInJx7gFMw== Received: from lo2p265cu024.outbound.protection.outlook.com (mail-uksouthazon11021081.outbound.protection.outlook.com [52.101.95.81]) by mx07-00376f01.pphosted.com (PPS) with ESMTPS id 4ctxyghqtq-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 12 Mar 2026 16:29:29 +0000 (GMT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=L1L/ppiAd+kE7mVsCmNGMsIQ70lOmtqkKZSV2naqsvWcwwi+wvIXA6hDTqxVvxP1BpRUxdKdIriuLEOThcDX1Z07wSXfU35sLx9vtoP+M3K01hNcIsWsq1AioAs2sYzm2S0p6pPCcyfYyUvskZEHtqJKT0vhXZaPa+/zq9sUk0miAR0CmEkLHE9x8tMuy3Lof/5FiPcPx7H24dyFzGpPhKm42aoXNIar4QEdWeQXq67GskiR6vuuK6J0VXBmNrf8qIL4f1J32NYxhpnWspOAFnHCyaSWzqvCl50z6XuTQbaNzK50/nBb7VpR1Quge0ENVdNhma4Tm0Y/wUsccEv7DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HIq3GLRIWTZrD9zUMyEgJEZ9Pv91nqKe18E+FjvnYEo=; b=sYq6xJMF4o0eRryhXlHnaaE0o0gC0blVWZ4HCKD4Cl0gU2HTTc60W90C19fQrgaQNMJaa0ct3KnuReo3UOPDif/j/uppxT0H+t0dWbSpsgj5aR/suEhEzCdflYlau6SWOos56btXRhzbgi0/bPVPit+A61rArVVpAO9AvY1OoFbUn+vcdJr/PkgnyRMRBKC4F22xEfnQfyadxVzHChQvnjhifV3HhTVSnNSPBqBdGcu486dB2x+zFVPCQtnSxJrV2hFc0ObuDc1UU66NmmnNo2I4Ywj0zAcmTWDcwiI5SqhRHPz6BNq6XkfJpfbePWAXRiuqGQAHM2KTY00+y8D+zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=imgtec.com; dmarc=pass action=none header.from=imgtec.com; dkim=pass header.d=imgtec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=IMGTecCRM.onmicrosoft.com; s=selector2-IMGTecCRM-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HIq3GLRIWTZrD9zUMyEgJEZ9Pv91nqKe18E+FjvnYEo=; b=gh9iQif9skX/PYves5IL8lPRVhKmrwqMx2jEbes1nVRaaniIb/GPX6ho0amp9Qq+5yqfIfu1lZaKVNutsSuzfZxxRmq61+fpowjMBmzigWlI0bSCbE+WiUnaE4BTrzgyvj9j9ISRmCDClYdPIxsrgMfkQMYDt564hJMAkdIWChU= Received: from CWLP265MB3393.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:e2::14) by LOCP265MB8627.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:4b6::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.15; Thu, 12 Mar 2026 16:29:27 +0000 Received: from CWLP265MB3393.GBRP265.PROD.OUTLOOK.COM ([fe80::f32f:ed34:4f98:6cd6]) by CWLP265MB3393.GBRP265.PROD.OUTLOOK.COM ([fe80::f32f:ed34:4f98:6cd6%6]) with mapi id 15.20.9700.013; Thu, 12 Mar 2026 16:29:26 +0000 From: Matt Coster To: Rosen Penev CC: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Binns , Brajesh Gupta , Alessio Belle , Alexandru Dadu , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" Subject: Re: [PATCH] drm/imagination: simplify pvr_fw_trace_seq_data Thread-Topic: [PATCH] drm/imagination: simplify pvr_fw_trace_seq_data Thread-Index: AQHcsj1kW68NqIfO70WPA9Qm3ECykA== Date: Thu, 12 Mar 2026 16:29:26 +0000 Message-ID: <5b127a2a-0497-465f-bb56-a3e013e8b0bb@imgtec.com> References: <20260311004014.32240-1-rosenp@gmail.com> In-Reply-To: <20260311004014.32240-1-rosenp@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CWLP265MB3393:EE_|LOCP265MB8627:EE_ x-ms-office365-filtering-correlation-id: 3f4821bb-953d-4213-c1a6-08de805486fd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|1800799024|366016|6049299003|4053099003|38070700021|56012099003|18002099003|22082099003; x-microsoft-antispam-message-info: 1RONRlDdEOJjtDuznih33QG3whtGZlS14b9EZ2W1+qLwoOP9qusS90ojiJhOIvp65XhkuOjt+TtTuMk+76gu1RdutwvniibDdVbHkt4mqBP7Yqdmq335S5Guae/rUte8b72EeAxoJeZBMgdMZnziZEHv4lcOjIpr+zjqCEqNM9FLtIVZPwqpGnX9PYYvTuJLFVJfmN47wJe5OclfJzYo+UBiAB0wo1r8PVr2tUB0Icw28UI2BEbQ8ZOABPGsYB/GiyiGCtCDONCed3n9vEdJ/0rIfhGAIqmTOGGaENZtPQqtPWRRWxaIglPNKTOM+qHGepH6BazVGMo1EZ7QC3W1oQyAcFLTJqwcGczWp+Pvpep9Htd4rsGEMSyZ42vtFcNUCEwVU9ho/qt4xlGLA714U0xIMvLtUR17WcQOVJHBit9EcaN4JUapHhKG7i7DO+AT4frKxSngAT9o9fo/ZDCUbw+7i1VBTVOLpZ8AGAK4QIj9N6H0mYiTYeDiRIMVO3PU2fB6Z8Ooq2amwStoNDcSqJIeprxoyi38CE64sHawEiy2JXYI63+eOvxoq2m9imiJdIPrrpbtIerLcduXTQN6jpwAKOPT+8poiw+p86fFyRywhXe8GPqwKvSBuc93tY/DC42FNKf7McDYyVOCagRkCTGHfHpOVrNPxhRWYQACeSKZtynIcraWAX6/l9XNMHsoN7a8oyzF349qdq8Av/OBa68c1KZc0OYAr5UYrPG3L2/CtdaPaJwlfuP7i0F2q2XUUART7BdoKaZz+6dJes2rUou58mBWB4/UK7+1QXeKNc8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CWLP265MB3393.GBRP265.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(6049299003)(4053099003)(38070700021)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TlN6T2d6VEpqZnA3WUwzQ0R2U3pPU2xvclNudGhCTUNkb2xQOXgrSHNaaTlL?= =?utf-8?B?TjNTaTBNZjJoUjZhcXRhRXNpM0RhRk1NVUZmRzhqd1BHdklZWnFhRlgydUNY?= =?utf-8?B?S3ltd3Z3Z1c5eE1Dc2FNSkVOQUhsd0RRRk5ST3BGeHBvSks1a3pTY0pIdEM2?= =?utf-8?B?NjJYYmtRQ2JqbzFpQXJ5aEpYSjVzSjhEeS9LRDRScUZlS25zM0lOdFpwd0JJ?= =?utf-8?B?aTgrOWdwbURpeFhvTmt5UGJEMTZSbUovMlkvaFI4cEhyWXlvNmdubG80Q1NH?= =?utf-8?B?NXlIVHN2UVhRNnFFZFRpN28rWStXZGc3aU9idG05UEJJZ3Q4dW4rSEVadkc4?= =?utf-8?B?MXZQTFR2NG1weDhaajZsc3FrbHpMcStIVmU3b04vRkwxOERDTjNwcTBlL0di?= =?utf-8?B?RzUzT2J4NGpwUkgxZ0R3NmFuRS9QckFNRWhzTVZ1a1JvdUVzVTcrUWpqb1Fs?= =?utf-8?B?RlR5bVBJa0xuVDZhamJPU3REMmMrck5kWkVLZXVGSVhYbEx4VVMrWmhvSzg3?= =?utf-8?B?cTJaeGxBL2dnWG5yRzNuN0dKblBpWFc4MFpLWHNIM1p3QUFkWUZDZnRpRTFH?= =?utf-8?B?bms2NVo5VlpTQ3p3RFRsOHF3NkNndXdrVDBLZjlreW4zT0Noc1hBTHlzSFVn?= =?utf-8?B?eUVUdGJZd21SdHhtWGdRL1dLMUF1bkFxYXpkOUk2TitUYXU5U0FxUFZHRWdB?= =?utf-8?B?c0lIcHRpQlVsdEJkS01FRDYwQi9UN3kzMG91YytTeWRzWDErYm00VzhVYzQ1?= =?utf-8?B?WlJ3RGcxUlBabEJ1U1Y1dlJSaW1iNWlESFpFM3habmoyTmZoRndWSHh3SjBz?= =?utf-8?B?YS9ZbXhiSTZkV2ZneFJpRWtnQVh1enFQRHdmUHB2QlVmUVh0eVlHN2V3ZzJ1?= =?utf-8?B?Y3Qwc3V6V1UzZWdjYWh6WXY3dVNuTGpNcVlROFpJeFhab1NUMHM5NWVRUTI1?= =?utf-8?B?RFVuT1BVR2pzZ2ZIWlI2aU9nMWd5em9SeTRud0dnM2Z1MU9KczdHS3VqdGIw?= =?utf-8?B?dkFIYjFPTmlKU205VldkOGpMdHZBTWVUM09GUVVnSXN0SmlBb2VIbTA5Ympn?= =?utf-8?B?S0lrWFJZMWxzajJDemxNaHFxV3ViMHAzQXB4M2RiK1dtSG9WakV1ZGx5TS8x?= =?utf-8?B?TFZQSU1SQVBqby81NzdUWGREc2Y3c0d0QmRPMzUzQjlBTlV4Z2YvOUtKSkU1?= =?utf-8?B?TzRubXRmZ3VEU2xncWl2OXQ5WVRuQzZxVm1ydGZ6TklOVFZHMm9OZ1daS1R4?= =?utf-8?B?L2paZzFPbWgvK0pDUXJtRVBVcTZZUjQvdy9JdktnV0pvUC9LZlBXS2ZPV3d4?= =?utf-8?B?eGg3Zkg4ZG83UCtSYnI5emtzYmlhYWNyZWVpTVdLN2NOeFJsdG5sREV3WS94?= =?utf-8?B?MTVDTTZTZUU3TW5DZDJqQXZSclJ6NnYwOFR5VGFsOEZ4L1lyQkczQmRvcmYy?= =?utf-8?B?aDhTZ3NlbnlhNFhrWE9NYVozWHVqdjdRZWdVa25MbWhlRzJpTkl4TUpSMEEr?= =?utf-8?B?K0g3YWUwalJEb0pxdGlWY3BpU3B4anVVWklUVkVGcjF2cEQrZS9yL3kxUmow?= =?utf-8?B?cURKVXJ6bENXQm1IbXdRdk1XZkFOaWhRUElFdFhqbm1HQ0ZrYnQwbk04ckNT?= =?utf-8?B?THhVOWhpTWtudVhLeHNOZUw2VFdKajBOUnVxdkJRYjd6VjNaUXRyd2dsd1My?= =?utf-8?B?bWxjOEEzQ0RyR1pYeExXdi96Q2tiSmRxL2V1cEhnQzZzSnNUNkcxQ1JHWE9i?= =?utf-8?B?cXRhekpXMGhIckhpYXNUUHR3NUhBWE5RQkhlcXN2Qnp4WHhvc1JFL2tzc25Y?= =?utf-8?B?YnVqRU5yTmF5eTZFQW8xclZ3MzkyNFFLcGRYVmZKWXhyTmk5WGxVSHhBN1pY?= =?utf-8?B?TlNRTVo4alJZeWtQUXpVL1prQ3pDb1pjTEZIbU1vYmRvbXRlQlIzVXdiQ2VM?= =?utf-8?B?WmNvSlJMT2VOM3owWWdoK05iTmFxdmc0MXArd05nWlRMYnI0TXVMS0h1TlY5?= =?utf-8?B?bEpuaGx3YUtiMm83bW5LdmZHUTBLZEhoVlVFVzZjN3BQU0xtNmVmNjZheGVh?= =?utf-8?B?MnV1ZXdtY0U2blIwS2QwZTRYYkNyZGV6SkFzVlBiZGR0RFd3ZGIvTHdNOXhn?= =?utf-8?B?ZHBaSUVVRlJUWXRhTEMvdXg2WEZNQWkyMVMwSTNtdzAwYVJlVTRBclJwandK?= =?utf-8?B?T2lDYkRLb0pLQWhYQWtnd0ozd2xDUVBlVFBzL25CYkxJVjRsck5NaGpoMWVT?= =?utf-8?B?dmtmYUFjcUdYV3FNMUtESjlRbGhKUkd6UHFjdGRVVC8rbUNXaGx5NjJnbTQz?= =?utf-8?B?YmZiMzFWQlFtVUNRWXNLWmxac3VXOFpGSCtwWmxYUHdDRXVJQmJ2T0w0UHVK?= =?utf-8?Q?l+9eSrYo69E5aCGw=3D?= Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------hgjBLpHQ8A3tmC6qX1750wzq" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: r4Urh1xQtnuKUkIZrRmKBtBD+n3zJAwkLIj5lG8aA8j+1CThaO7xQWCjO5CINXAs72G5yByKKicutvlmv8G9G2YZ63hBNewIu43qDv2YrL3tIK9K3ji2v5bNTrtlBeDTGr+AGqFAAi6iuko4hLDjMRpDT+64GczFCWzEfMJY3+Bv8c3LsRCeIT+PIaWiZy36kwhCVJWgeyxRdEOzwNdep9THZz75TxEM8OFa5yfMB9khzlCmZ4Z3BVnx81pAylREbZHw+0hDRGD2GX4Fpw/P8KOdXfGd7tyUt1UlpE8D5PsZVF9lE5LnRt8/lC8YugbQltbW//m1vb4/fzlSCnNCZw== X-OriginatorOrg: imgtec.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CWLP265MB3393.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 3f4821bb-953d-4213-c1a6-08de805486fd X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2026 16:29:26.2977 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0d5fd8bb-e8c2-4e0a-8dd5-2c264f7140fe X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: J0EXf2ZFxl625mf1JXNoLZ77AsFQvfhSKmvSdK3ehndedQRfN8teTWBhKDcUxMILCcOuvJw9UhUNc5eZR0Ch0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LOCP265MB8627 X-Proofpoint-ORIG-GUID: -Cr1dKEEStbKYzdVD2VvdH_my8w0_mNu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEzMyBTYWx0ZWRfXxqavUy3RQ+hq flOWqD4+jo+Ji7aGA496VML6rHU7QAHKQGPHhpw89AB1aK4dSglJdUl9xQjWRMxyq9GQDJHedXN 4VvBPwFp3jH8HG5l/YvZJuSuPrCE87EB3ZsBvwROcEf+oIzDN3mvoU1okZl4JuLAwSzqCfNcD42 +evfr8jjyfwP7TOwmX9yPsGGuL/yjgJP1MwjZRUX7GV7/QVW/6tF1xFDre0CyncBsDLGUSpHChK WlmxuPNpNFBLnHeRPPH29xwRZgSs8BbFbfLO5cEC7qzE2wyNhrbGdXh2aeuXnXJvdHg8F3xw1I8 Hnu6PaE1xqkDiw7nkh0LlA8j9f8Fj7uiNpYg6F4Aos9qPJvue4lCv6YgulBPqeJzYuGaXl0pDSn HssubsvY9La1QCHnpjS1T3nfkyr/jbkPgzyVtRJ6hdkk9pSTZYjCqHhDic5Hz+AberCaLD8yWkR XLiSGyDofBXL6gQwJaw== X-Proofpoint-GUID: -Cr1dKEEStbKYzdVD2VvdH_my8w0_mNu X-Authority-Analysis: v=2.4 cv=NevrFmD4 c=1 sm=1 tr=0 ts=69b2e9e9 cx=c_pps a=ksNEH+yqkqlep0rpFJ2ecA==:117 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=NgoYpvdbvlAA:10 a=VkNPw1HP01LnGYTKEx00:22 a=kQ-hrUj2-E3RCbRHssb7:22 a=7RYWX5rxfSByPNLylY2M:22 a=pGLkceISAAAA:8 a=r_1tXGB3AAAA:8 a=02j7tN-7dy9T4BxsCakA:9 a=QEXdDO2ut3YA:10 a=6w0Z9m_S3I5YdX8hwdMA:9 a=FfaGCDsud1wA:10 a=t8nPyN_e6usw4ciXM-Pk:22 --------------hgjBLpHQ8A3tmC6qX1750wzq Content-Type: multipart/mixed; boundary="------------mUGYFQNUQwABMzmC0Ci3RoBU"; protected-headers="v1" Message-ID: <5b127a2a-0497-465f-bb56-a3e013e8b0bb@imgtec.com> Date: Thu, 12 Mar 2026 16:29:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/imagination: simplify pvr_fw_trace_seq_data To: Rosen Penev Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Binns , Brajesh Gupta , Alessio Belle , Alexandru Dadu , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20260311004014.32240-1-rosenp@gmail.com> Content-Language: en-GB From: Matt Coster Autocrypt: addr=matt.coster@imgtec.com; keydata= xjMEYl2lchYJKwYBBAHaRw8BAQdAOYlooFfHTXzAQ9aGoSnT9JS9wq8xprG+KVLbkxJDF5DN JE1hdHQgQ29zdGVyIDxtYXR0LmNvc3RlckBpbWd0ZWMuY29tPsKWBBMWCAA+AhsDBQsJCAcC BhUKCQgLAgQWAgMBAh4BAheAFiEEBaQM/OcmnWHZcQChdH8KkDb5DfoFAmgHpowFCQlsaBoA CgkQdH8KkDb5DfqxDgEA81pbVLJDmpFyFZLRhAGig9rgoDY6l774yhTzRVm/SvkBAJLzpSlm wyQaQuB668TKOX9XvRLKFGjSq5kkdQcxqjkCzjgEYl2lchIKKwYBBAGXVQEFAQEHQCaVC8X5 7NOv2jNbeXqjP9ekY7rzy7auiEZ5PxaDWUQVAwEIB8J+BBgWCAAmAhsMFiEEBaQM/OcmnWHZ cQChdH8KkDb5DfoFAmgHpowFCQlsaBoACgkQdH8KkDb5DfoK+AD/Q4aN/zUvP72RRE4cNWpM MXeRXg+LTN+OJ24U10LltxIA/2w3kDqMC/0t1oqO8TM+c2LMWO/x2IBkG7oRZ/hVw1QI In-Reply-To: <20260311004014.32240-1-rosenp@gmail.com> --------------mUGYFQNUQwABMzmC0Ci3RoBU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/03/2026 00:40, Rosen Penev wrote: > A flexible array member allows one allocation instead of two. Which > means one less kfree to worry about. Hi Rosen, Thanks for the patch! I agree, doing this as two kzalloc()s makes zero sense (no pun intended). >=20 > Signed-off-by: Rosen Penev > --- > drivers/gpu/drm/imagination/pvr_fw_trace.c | 21 +++++---------------- > 1 file changed, 5 insertions(+), 16 deletions(-) >=20 > diff --git a/drivers/gpu/drm/imagination/pvr_fw_trace.c b/drivers/gpu/d= rm/imagination/pvr_fw_trace.c > index e154cb35f604..caf504f2bf85 100644 > --- a/drivers/gpu/drm/imagination/pvr_fw_trace.c > +++ b/drivers/gpu/drm/imagination/pvr_fw_trace.c > @@ -241,9 +241,6 @@ update_logtype(struct pvr_device *pvr_dev, u32 grou= p_mask) > } > =20 > struct pvr_fw_trace_seq_data { > - /** @buffer: Pointer to copy of trace data. */ > - u32 *buffer; > - > /** @start_offset: Starting offset in trace data, as reported by FW. = */ > u32 start_offset; > =20 > @@ -252,6 +249,9 @@ struct pvr_fw_trace_seq_data { > =20 > /** @assert_buf: Trace assert buffer, as reported by FW. */ > struct rogue_fwif_file_info_buf assert_buf; > + > + /** @buffer: Pointer to copy of trace data. */ Can you update this comment? > + u32 buffer[]; > }; > =20 > static u32 find_sfid(u32 id) > @@ -455,17 +455,10 @@ static int fw_trace_open(struct inode *inode, str= uct file *file) > struct pvr_fw_trace_seq_data *trace_seq_data; > int err; > =20 > - trace_seq_data =3D kzalloc_obj(*trace_seq_data); > + trace_seq_data =3D kzalloc_flex(*trace_seq_data, buffer, ROGUE_FW_TRA= CE_BUF_DEFAULT_SIZE_IN_DWORDS); Given the buffer is 48KB, I think it's safe to say kcalloc() was the wrong choice in the first place. The choice of 12,000 for the DEFAULT_SIZE define appears arbitrary, and although other sizes haven't been tested I wonder if a more "efficient" replacement here would be to make it a power-of-2 size and use folio_alloc()/folio_address()/folio_put() for the buffer instead of making it a flexible array member. Or maybe I'm overthinking it and we should just stick with a simple vzalloc(struct_size(...))/vfree(). I'll leave it up to you. Cheers, Matt > if (!trace_seq_data) > return -ENOMEM; > =20 > - trace_seq_data->buffer =3D kcalloc(ROGUE_FW_TRACE_BUF_DEFAULT_SIZE_IN= _DWORDS, > - sizeof(*trace_seq_data->buffer), GFP_KERNEL); > - if (!trace_seq_data->buffer) { > - err =3D -ENOMEM; > - goto err_free_data; > - } > - > /* > * Take a local copy of the trace buffer, as firmware may still be > * writing to it. This will exist as long as this file is open. > @@ -478,15 +471,12 @@ static int fw_trace_open(struct inode *inode, str= uct file *file) > =20 > err =3D seq_open(file, &pvr_fw_trace_seq_ops); > if (err) > - goto err_free_buffer; > + goto err_free_data; > =20 > ((struct seq_file *)file->private_data)->private =3D trace_seq_data; > =20 > return 0; > =20 > -err_free_buffer: > - kfree(trace_seq_data->buffer); > - > err_free_data: > kfree(trace_seq_data); > =20 > @@ -499,7 +489,6 @@ static int fw_trace_release(struct inode *inode, st= ruct file *file) > ((struct seq_file *)file->private_data)->private; > =20 > seq_release(inode, file); > - kfree(trace_seq_data->buffer); > kfree(trace_seq_data); > =20 > return 0; --=20 Matt Coster E: matt.coster@imgtec.com --------------mUGYFQNUQwABMzmC0Ci3RoBU-- --------------hgjBLpHQ8A3tmC6qX1750wzq Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQS4qDmoJvwmKhjY+nN5vBnz2d5qsAUCabLp5QUDAAAAAAAKCRB5vBnz2d5qsG1Y AQD7z2595uShHzS6KyCrG8TNB5pkyHNoVpkMCjbsIIlyKgEAxVwXp8kxbuFNBRpMPf3zVhSHfp2f rvt8t5MDyp+lgAg= =Fjv8 -----END PGP SIGNATURE----- --------------hgjBLpHQ8A3tmC6qX1750wzq--