From: Dexuan Cui <decui@microsoft.com>
To: Tejun Heo <tj@kernel.org>, Chris Mason <clm@fb.com>,
"Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: ext4: performance regression introduced by the cgroup writeback support
Date: Thu, 24 Sep 2015 07:26:20 +0000 [thread overview]
Message-ID: <5b1f9f0d50f94eea922dd0c7405428be@SIXPR30MB031.064d.mgd.msft.net> (raw)
In-Reply-To: <20150923185337.GK26647@mtj.duckdns.org>
> From: Dexuan Cui
> Sent: Thursday, September 24, 2015 8:16
> To: 'Tejun Heo' <tj@kernel.org>; Chris Mason <clm@fb.com>; Theodore Ts'o
> <tytso@mit.edu>; Andreas Dilger <adilger.kernel@dilger.ca>; linux-
> ext4@vger.kernel.org; linux-fsdevel@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: RE: ext4: performance regression introduced by the cgroup writeback
> support
>
> > -----Original Message-----
> > From: Tejun Heo [mailto:htejun@gmail.com] On Behalf Of Tejun Heo
> > Sent: Thursday, September 24, 2015 2:54
> > To: Chris Mason <clm@fb.com>; Dexuan Cui <decui@microsoft.com>;
> > Theodore Ts'o <tytso@mit.edu>; Andreas Dilger <adilger.kernel@dilger.ca>;
> > linux-ext4@vger.kernel.org; linux-fsdevel@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Subject: Re: ext4: performance regression introduced by the cgroup writeback
> > support
> >
> > On Wed, Sep 23, 2015 at 12:13:59PM -0400, Chris Mason wrote:
> > > > The issue is: under high CPU and disk I/O pressure, *some* processes can
> > suffer from a very slow write speed (e.g., <1MB/s or even only 20KB/s), while
> > the normal write speed should be at least dozens of MB/s.
> >
> > So, I think I know what caused this regression. Separate wb domains
> > shouldn't have been enabled on traditional hierarchies. It doesn't
> > work there and leads to multiple wb domains competing on the same
> > blkcg and the bw estimation would go completely haywire. Will update
> > soon.
> >
> > Thanks.
> >
> > --
> > tejun
>
> Thanks a lot for the quick fix, Tejun!
>
> I'll test the fix.
> I'll report back in case it can't fix the issue --I think this is unlikely. :-)
>
> -- Dexuan
Hi Tejun,
Thank you!
I believe your patch fixes my issue, according to my test.
-- Dexuan
next prev parent reply other threads:[~2015-09-24 7:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 13:49 Dexuan Cui
2015-09-23 16:13 ` Chris Mason
2015-09-23 18:53 ` Tejun Heo
2015-09-24 0:15 ` Dexuan Cui
2015-09-24 7:26 ` Dexuan Cui [this message]
2015-09-24 0:12 ` Dexuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b1f9f0d50f94eea922dd0c7405428be@SIXPR30MB031.064d.mgd.msft.net \
--to=decui@microsoft.com \
--cc=adilger.kernel@dilger.ca \
--cc=clm@fb.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®