From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Albert Esteve <aesteve@redhat.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Sarannya S <sarannya.s@oss.qualcomm.com>,
Pranav Mahesh Phansalkar <pranav.phansalkar@oss.qualcomm.com>,
Sudeepgoud Patil <sudeep.patil@oss.qualcomm.com>
Subject: Re: [PATCH v4 3/4] soc: qcom: smem: validate private item payloads
Date: Tue, 27 Oct 2026 13:58:09 +0100 [thread overview]
Message-ID: <5b229052-ebe5-496b-a21b-974d7bf3c5f1@oss.qualcomm.com> (raw)
In-Reply-To: <20261022-port-smem-v4-3-b0baf39c6e01@redhat.com>
On 10/22/26 11:47 AM, Albert Esteve wrote:
> From: Sarannya S <sarannya.s@oss.qualcomm.com>
>
> Validate a matching entry's size and padding even when the caller does
> not request the length, and check that the payload stays inside the
> same region as the header.
>
> Signed-off-by: Sarannya S <sarannya.s@oss.qualcomm.com>
> Signed-off-by: Pranav Mahesh Phansalkar <pranav.phansalkar@oss.qualcomm.com>
> Signed-off-by: Sudeepgoud Patil <sudeep.patil@oss.qualcomm.com>
> Signed-off-by: Albert Esteve <aesteve@redhat.com>
> ---
The commit message should probably mention that zero-length
payloads are now considered invalid (but I think there aren't
any valid ZLPs). I think we can also keep the WARN_ON() for the
bad padding_data
Konrad
next prev parent reply other threads:[~2026-10-27 12:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 9:47 [PATCH v4 0/4] Add automotive SMEM hardening for Qualcomm platforms Albert Esteve
2026-10-22 9:47 ` [PATCH v4 1/4] soc: qcom: smem: add IN_PARTITION_RANGE helper Albert Esteve
2026-10-27 12:18 ` Konrad Dybcio
2026-10-22 9:47 ` [PATCH v4 2/4] soc: qcom: smem: validate private entry list walks Albert Esteve
2026-10-27 12:45 ` Konrad Dybcio
2026-10-22 9:47 ` [PATCH v4 3/4] soc: qcom: smem: validate private item payloads Albert Esteve
2026-10-27 12:58 ` Konrad Dybcio [this message]
2026-10-22 9:47 ` [PATCH v4 4/4] soc: qcom: smem: ignore multi remote host partitions Albert Esteve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b229052-ebe5-496b-a21b-974d7bf3c5f1@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=aesteve@redhat.com \
--cc=andersson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pranav.phansalkar@oss.qualcomm.com \
--cc=sarannya.s@oss.qualcomm.com \
--cc=sudeep.patil@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®