From: Joe Perches <joe@perches.com>
To: zhong jiang <zhongjiang@huawei.com>,
clm@fb.com, jbacik@fb.com, dsterba@suse.com
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] fs/btrfs/disk-io: Remove unneeded variable "err"
Date: Sun, 05 Aug 2018 08:27:49 -0700 [thread overview]
Message-ID: <5b2806ada98cfca4346e48f1943aca6da0cda4a6.camel@perches.com> (raw)
In-Reply-To: <1533481371-21349-2-git-send-email-zhongjiang@huawei.com>
On Sun, 2018-08-05 at 23:02 +0800, zhong jiang wrote:
> The err is not used after initalization, So remove it and make
> the function to be void function.
[]
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
[]
> @@ -4193,7 +4192,6 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,
> if (atomic_read(&delayed_refs->num_entries) == 0) {
> spin_unlock(&delayed_refs->lock);
> btrfs_info(fs_info, "delayed_refs has NO entry");
> - return ret;
Think a little more about this please.
This is not a sensible removal.
> }
>
> while ((node = rb_first(&delayed_refs->href_root)) != NULL) {
next prev parent reply other threads:[~2018-08-05 15:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-05 15:02 [PATCH 0/3] Remove uneeded " zhong jiang
2018-08-05 15:02 ` [PATCH 1/3] fs/btrfs/disk-io: Remove unneeded " zhong jiang
2018-08-05 15:27 ` Joe Perches [this message]
2018-08-06 2:39 ` zhong jiang
2018-08-05 19:13 ` Nikolay Borisov
2018-08-06 2:42 ` zhong jiang
2018-08-05 15:02 ` [PATCH 2/3] fs/btrfs/extent-tree: remove redudant " zhong jiang
2018-08-05 15:02 ` [PATCH 3/3] fs/btrfs/tree-log: remove the unneeded " zhong jiang
2018-08-05 19:14 ` [PATCH 0/3] Remove uneeded " Nikolay Borisov
2018-08-06 2:37 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b2806ada98cfca4346e48f1943aca6da0cda4a6.camel@perches.com \
--to=joe@perches.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®