From: Alex Elder <elder@riscstar.com>
To: Luca Weiss <luca.weiss@fairphone.com>,
Alex Elder <elder@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] net: ipa: Fix QSB data for v4.7
Date: Tue, 4 Mar 2025 10:50:10 -0600 [thread overview]
Message-ID: <5b2c08d1-47fc-43f2-abcb-f5f54fad84e1@riscstar.com> (raw)
In-Reply-To: <20250227-ipa-v4-7-fixes-v1-2-a88dd8249d8a@fairphone.com>
On 2/27/25 4:33 AM, Luca Weiss wrote:
> As per downstream reference, max_writes should be 12 and max_reads
> should be 13.
>
> Fixes: b310de784bac ("net: ipa: add IPA v4.7 support")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Looks good.
Reviewed-by: Alex Elder <elder@riscstar.com>
> ---
> drivers/net/ipa/data/ipa_data-v4.7.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ipa/data/ipa_data-v4.7.c b/drivers/net/ipa/data/ipa_data-v4.7.c
> index 7e315779e66480c2a3f2473a068278ab5e513a3d..e63dcf8d45567b0851393c2cea7a0d630afa20cd 100644
> --- a/drivers/net/ipa/data/ipa_data-v4.7.c
> +++ b/drivers/net/ipa/data/ipa_data-v4.7.c
> @@ -38,8 +38,8 @@ enum ipa_rsrc_group_id {
> /* QSB configuration data for an SoC having IPA v4.7 */
> static const struct ipa_qsb_data ipa_qsb_data[] = {
> [IPA_QSB_MASTER_DDR] = {
> - .max_writes = 8,
> - .max_reads = 0, /* no limit (hardware max) */
> + .max_writes = 12,
> + .max_reads = 13,
> .max_reads_beats = 120,
> },
> };
>
next prev parent reply other threads:[~2025-03-04 16:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 10:33 [PATCH 0/3] Fixes for IPA v4.7 Luca Weiss
2025-02-27 10:33 ` [PATCH 1/3] net: ipa: Fix v4.7 resource group names Luca Weiss
2025-03-04 16:50 ` Alex Elder
2025-02-27 10:33 ` [PATCH 2/3] net: ipa: Fix QSB data for v4.7 Luca Weiss
2025-03-04 16:50 ` Alex Elder [this message]
2025-02-27 10:33 ` [PATCH 3/3] net: ipa: Enable checksum for IPA_ENDPOINT_AP_MODEM_{RX,TX} " Luca Weiss
2025-03-04 16:50 ` Alex Elder
2025-02-28 22:52 ` [PATCH 0/3] Fixes for IPA v4.7 Jakub Kicinski
2025-03-02 18:52 ` Alex Elder
2025-03-05 0:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b2c08d1-47fc-43f2-abcb-f5f54fad84e1@riscstar.com \
--to=elder@riscstar.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phone-devel@vger.kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®