From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8555841B361 for ; Tue, 7 Jul 2026 13:31:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783431120; cv=none; b=WDg2v3X6KlTqEJ3E98gQari7j6ZL2Kc7+GzqRrwm6V0Z5JdTXTgat9ffrjPWoN2zZ08u1165mfpEUcYLI0rlETQkNQyflWArnvoMh5IPcjx71rFXPy5sbn+cTNmADIwg5rkhl5dHAskj0mLRyW9h2pXQ5aV57ylemrJ774ARkO0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783431120; c=relaxed/simple; bh=eRiu6xlRGCigoYlAt5WHX9RcoVVKkVTEbzs0xA2TxdA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oIb4pSySRoH9dc558nvNV0OWXuAI5PTyMcsGLjtZcJc0eHkWzpY9WiYp9/E+PZ3rIeVh6mx6yN8IIhAKBVTxH1Zd5uL0WFzJwjezql1+hOhv5dWKOLXSo/viwLGZJBfZg5GZeIAGe6U6hSRHiqa62CK+lvtoQg/rPSGu35tnOUw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Bi4KvWky; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Jd0749Qj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Bi4KvWky"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Jd0749Qj" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 667C8eji3606093 for ; Tue, 7 Jul 2026 13:31:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vRuiy7dJLlykvulsIPzgvFs7mUvpBg3IQJtjypRN/Ic=; b=Bi4KvWkyjCYIWkkD zEbw6r4o4v85TAY5VHjqFOHkxPhVerGEX4bFosd6vbZklh8bu2AhZ+uF3rWaRuOD oYEsje6B2bP3xwAaBYyD4IzuirNL+NmuI/euaFFIcX4qSymRaXoqYcRjhQQl4eEC NiJy/M/Yp5viz3o7Q1C8HcuEL1MqCaFWd5ri5ihesyxWNh0hjh2IShWqwExbNI/V w1JhIHWO/kW0dua2epZqTnGiVfEx9l0NWzXFwPBCifSVoq+bghQeOyuKAyCHNZYs xMKS7+bFyM4jfXFhMp7/ul+n4EAc5J0ZajFmei7x+uMs7Q9jymxtjRvMjwM+vytr xEBE/Q== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8sm8j6wr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Jul 2026 13:31:57 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2cc8bde6318so44184005ad.3 for ; Tue, 07 Jul 2026 06:31:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783431117; x=1784035917; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vRuiy7dJLlykvulsIPzgvFs7mUvpBg3IQJtjypRN/Ic=; b=Jd0749Qjn3t9m5UZpf3y8imJYpAui7Vsau2EmXLKqWl0cJu6IMITP7bbqRBICC0lZY FU5zsm+rSl3f80jeiSTEgVdyeS/vCMZh0Pm9xb7bJ4066PzHVNcNFhVz0Y1uvZxgtjEw 7aGO3zSnJKgntNB3fUmA/zO4Tq9etxehbB4mwttQeCBki60iRmCN2Eh/UhcEth1BTfXx 38fIBR8QPk7got7suSiBTRTQDB02MmTQfEfIfg7Nn1tMAdzr9xxypQzRL9/Xd2OWGp3n frsYkJuU8ibrM5ZJZj+xg1bdxjac01XXzfXYYm11kSDluWHO2tcwDSuAXSAo1krVCEWs GeDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783431117; x=1784035917; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vRuiy7dJLlykvulsIPzgvFs7mUvpBg3IQJtjypRN/Ic=; b=ZhzzJF0WMT6o2AGpLMjdl1GzXa1bVnPJKV399A5iviGTCKV0KgdIvVEFYCuNT0jyoW +p8jaLO1ZGoWqVe4vmVTiXs+O1PgwVDh4ToJpPe8JnFXJpmPu0+sHlDPiV+VCR7mn+py DpjXegEum3N+avzOtpv6ka4sSOkouAB8Xd0HhIyecRjiiJRx4ZHnTPuti86hfbLoWwsW fzGBe2V9DHbR3rVv3gkjRfZ9GUPiVvmodKx+2DUHqKA66YeHu81y2vdG2bSbycBnXcQF vbsyBoDgcGp4uEG2OaxgiZ1TXPvD1TnfxCHxYz7Z/tks5ZoZmzKV4RW7g+L+tpIvrgyc Lq9A== X-Forwarded-Encrypted: i=1; AHgh+RpRfxRJoPPV1w3qfG4q+7ZQQu10nP8fhAC9FTQV/I6Tu6P3pkTmeIEUJLflBPcxCbVHJS9QVNhljIodQbQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwnVQ4kicv6P0GLy1tFZhmz6wAqY1pXhNZ3VlpZ7CWkDYYw13ox XBk8fuBxwEa39Lt1RLp14NTDIklyACMpeadZpeAC98c9YiCeT4ivxTFzXZONrB6hwhtxNTj1vyh RdfUJcqu0QBL8vPRJZGHViQil72Dae2f8BIDCPEkSt4bvhs9JeOiloD9hYMxaU7eDWwk= X-Gm-Gg: AfdE7cl3d9rTjOruMLtMZmvvlKBlhgQUKmDYTA8jPZ5YuVkrrRi0/38XcFRyQ29+ezR kpYBBNDnoxQNsKPC7TB10w0qX6Wh/gkDFD9nkTqx3znWoxUymaaakKl8n4ZYHJ1u9TVfBn0E7Du BsRe6sUsRImiZKOda6sr1tIJLzwXAksnVXT6wNdHkqttTbkMfdnxO8ZBoWNOx90s6QzEVoW+aA8 CPquzpBt0+CTxLNEpvdzu375+kSqPd50XYFGOru04nnWariypAJ2JbFyWF1UfuE/1Jz65HzvnWd YeIw/ybI8hxQyli+jQ5cFQVssW4y9cfaKJFPAzlUidbbA5OiyoWnvcwThMzLSfQRZXXlN7FdCPd D1J0DtTx5IvB07QmbV0cnz7kGqowBSbuxu/cjzmuHXVU= X-Received: by 2002:a17:903:fae:b0:2ca:de3:15e1 with SMTP id d9443c01a7336-2ccbf0105d7mr53194355ad.31.1783431117202; Tue, 07 Jul 2026 06:31:57 -0700 (PDT) X-Received: by 2002:a17:903:fae:b0:2ca:de3:15e1 with SMTP id d9443c01a7336-2ccbf0105d7mr53194075ad.31.1783431116723; Tue, 07 Jul 2026 06:31:56 -0700 (PDT) Received: from [10.217.217.28] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d5fc81sm12180185ad.83.2026.07.07.06.31.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2026 06:31:56 -0700 (PDT) Message-ID: <5b30d4c5-ce21-492a-97a5-2a64f0ceb65f@oss.qualcomm.com> Date: Tue, 7 Jul 2026 19:01:52 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: hamoa-pmics: Add ADC support To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ayyagari Ushasreevalli , Kamal Wadhwa References: <20260614-adc5_gen3_dt-v2-0-32ec576c5865@oss.qualcomm.com> <20260614-adc5_gen3_dt-v2-4-32ec576c5865@oss.qualcomm.com> Content-Language: en-US From: Jishnu Prakash In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA3MDEzMiBTYWx0ZWRfXx/PJTLGg/Vkj a3ShyqI9cY2fR454+4V2aT8mwPo+Mt2i+uHLtxmrIfCcH5eqsZ9fR6kRSJng0UIrRPyNYXMqxNQ gctUkRYLYVzeReY9gLJ1F8fSREiLfcQphrydE5Ms/6fQRdLYfkodNm+5GvzPlbgwVBeCf+27Bai 5LuUtY6UOoVCC/RNd+mMB2/zxM0CfH3NBWbAGnnvmB7doF+BhXV5fuoFRSmWW27jcGudBb3icS0 E9eatDjMQjTeJUtWR1cg70SmMUUzjkBPjOzOig3nCd/Df6Q6La/Z6Qb0fXvwNRLBAIHQl/T5gEQ Y8pvNJrseZpnZ0Zc64Ug6tOrZiPRpKouumYXans64jRdayHLNfaeucNMN5jWTAPeMT15AHR+J9c N3xF4CGPdfWTr3kAWxBysLLmAOVl5x88OKeUOdevKQ1snIHnv90d7K0QybAykof4nyWAoLikerB B8bioOkNC51VZXpdkjw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA3MDEzMiBTYWx0ZWRfX+8vI0ovkwaQh ibwPtRX4j2akp1CKkoT/SCkmuID/0bIQlbCRkuVHZLE0dXXa3D9bIV8Pcv7gSqltBterXMXojTD BW2NHncJ5Fq+pl1zI42sQl34q1yYCh0= X-Proofpoint-GUID: p9f_JVaRZZoriwWmEVYPZhQRXSNY6GHR X-Authority-Analysis: v=2.4 cv=UvdT8ewB c=1 sm=1 tr=0 ts=6a4cffcd cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=PgX6_706HHJfHgd0ez4A:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: p9f_JVaRZZoriwWmEVYPZhQRXSNY6GHR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_03,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607070132 Hi Konrad, On 6/30/2026 5:31 PM, Konrad Dybcio wrote: > On 6/14/26 10:05 AM, Jishnu Prakash wrote: >> From: Ayyagari Ushasreevalli >> >> Add ADC node and define channels for: >> - Die temperature for PMK8550, PM8550VE* and PMC8380* PMICs. >> - PM8550: Die temperature, VPH power, and system thermistors. >> >> Define thermal zones 'sys-0-thermal' through 'sys-6-thermal' which >> correspond to the off-PMIC system thermistors connected via >> PM8550 AMUX/GPIO lines. >> >> Also,add io-channels and io-channel-names properties to the >> temp_alarm nodes so that they can get temperature reading >> from the ADC die_temp channels. >> >> Signed-off-by: Ayyagari Ushasreevalli >> Signed-off-by: Jishnu Prakash >> --- > > [...] > >> + sys-0-thermal { >> + polling-delay-passive = <0>; > > Drop, this is zero by default > >> + thermal-sensors = <&pmk8550_vadc ADC5_GEN3_AMUX1_GPIO_100K_PU(1)>; >> + trips { > > Please add a \n between the last property and the following subnode > > >> pmc8380_6_gpios: gpio@8800 { >> @@ -451,6 +697,8 @@ pm8550ve_8_temp_alarm: temp-alarm@a00 { >> reg = <0xa00>; >> interrupts = <0x8 0xa 0x0 IRQ_TYPE_EDGE_BOTH>; >> #thermal-sensor-cells = <0>; >> + io-channels = <&pmk8550_vadc ADC5_GEN3_DIE_TEMP(8)>; >> + io-channel-names = "thermal"; >> }; > > pmc8380_6 isn't mounted on purwa boards - do we need to override the > channel definitions in the vadc? Thanks for catching that, I now see that pmc8380_6-related nodes are disabled for Purwa. I think the pmc8380_6 ADC channel definition can also be deleted using /delete-node/ for Purwa. If this is fine, I'll make this change in the next patch series. I'll also address your other comments there. Thanks, Jishnu > > Konrad