From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753914AbdFMUkY (ORCPT ); Tue, 13 Jun 2017 16:40:24 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:39594 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752109AbdFMUkW (ORCPT ); Tue, 13 Jun 2017 16:40:22 -0400 Subject: Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static To: Andy Shevchenko , David Miller , Christoph Hellwig References: <20170613130321.7797-1-colin.king@canonical.com> <20170613.135619.350474759117231721.davem@davemloft.net> Cc: Yisen Zhuang , salil.mehta@huawei.com, huangdaode , yankejian , Andy Shevchenko , oulijun@huawei.com, netdev , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" From: Colin Ian King Message-ID: <5b3235bb-5058-82a6-d8be-76d805594cea@canonical.com> Date: Tue, 13 Jun 2017 21:40:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/06/17 20:24, Andy Shevchenko wrote: > On Tue, Jun 13, 2017 at 8:56 PM, David Miller wrote: >> From: Colin King >> Date: Tue, 13 Jun 2017 14:03:21 +0100 >> >>> From: Colin Ian King >>> >>> The guid hns_dsaf_acpi_dsm_guid does not need to be in global >>> scope, so make it static. >>> >>> Cleans up sparse warning: >>> "symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be static?" >>> >>> Signed-off-by: Colin Ian King >> >> That symbol doesn't even exist in th net-next tree. > > It looks like the patch is done against UUID tree. > Cc'ed Christoph. > Sorry, I messed up on determining the original tree it came from in linux-next when I looked at the output from get_maintainer.pl Colin