From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFC00C433FE for ; Thu, 23 Sep 2021 18:44:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85EE961214 for ; Thu, 23 Sep 2021 18:44:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242785AbhIWSpz (ORCPT ); Thu, 23 Sep 2021 14:45:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42495 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242708AbhIWSpx (ORCPT ); Thu, 23 Sep 2021 14:45:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632422661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x46eN9ZPpLusYWrqgbutzxSh8ecH9uBw9nNtjHfLCXU=; b=h4ZEuaEtpuF/qXCpAC/phsc/9MvmQQJQvfX6NfmedhFQ4YZsT79mN7fUKCMY+j5vKPThv/ hlJQGbg2mSE7IRXmkBCLfyX2nMadHTXFGTXqYtHWEO0DiyK6AihdycLoWymQ8dbQzUI1WS NbH2WkM5trQQbiB7cUn7RG8fxgcPAXc= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-99-rJ-GNhNuMVS905qwnLGxsQ-1; Thu, 23 Sep 2021 14:44:20 -0400 X-MC-Unique: rJ-GNhNuMVS905qwnLGxsQ-1 Received: by mail-ed1-f72.google.com with SMTP id r23-20020a50d697000000b003d824845066so7607833edi.8 for ; Thu, 23 Sep 2021 11:44:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=x46eN9ZPpLusYWrqgbutzxSh8ecH9uBw9nNtjHfLCXU=; b=EG4oH5LaxBxUKekmQ8GDPz98zZasjJgt5vyKuVmXBZmYOF/A4ZVjoBg2mGSFiyaxkE yzxHzkwWLyQQNpChSONR+1gKDFr4/dDB/S6WuculcAa+8hT9DOx3G/tGWjptVaozS4Az sMCABJ5t1hekGZGGlQmuuhHVVFpPnla2dfyHGRt0eCaWaVkHB1eUbDs1vwEOy6bqTlnP d6yP00NWjvlmAJ08OiVDeI3fR+oPnHce+137N3+JYu3108XJ/ll/Thi7FefnuaJgaHH7 jZoTpN5IZCxD4xAdze+wos/kSpe2cfeRNFJbl6s0UC8Ok1xednfcIlMH+eaza8TlQbWz dXNA== X-Gm-Message-State: AOAM531z5cKoM9/2qBF1b3/d2tLmcknHXAzsecMn2iVdf0sWRb79LxG3 Up2uIayBboGayBe0K9KmoUMo8JpuyKCQ9TCb0/qKssIEh24uMpggB2uqp9ZycgixL6xtnqyTqwR bG1M3OC4t+D9s6gbsEux5WGCf X-Received: by 2002:a17:906:318b:: with SMTP id 11mr7023128ejy.493.1632422659085; Thu, 23 Sep 2021 11:44:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTdMDL6/n0aYA0fgWnBgCS+Q0RVDKeac5WzIl4FyXndcJbeT1l9fh0WjKxt9aUl05CJr3cZQ== X-Received: by 2002:a17:906:318b:: with SMTP id 11mr7023096ejy.493.1632422658785; Thu, 23 Sep 2021 11:44:18 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id ku7sm3608060ejc.90.2021.09.23.11.44.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Sep 2021 11:44:18 -0700 (PDT) Subject: Re: [GIT PULL] KVM/rseq changes for Linux 5.15-rc3 To: Linus Torvalds , Thomas Gleixner , Oleg Nesterov , "Eric W. Biederman" , Al Viro Cc: Linux Kernel Mailing List , KVM list References: <20210923181252.44385-1-pbonzini@redhat.com> From: Paolo Bonzini Message-ID: <5b351abc-3bb7-abce-7a5c-2d16f6fe9b34@redhat.com> Date: Thu, 23 Sep 2021 20:44:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/09/21 20:35, Linus Torvalds wrote: > But I'm adding a few people to the cc for a completely different > reason: the cleanup to move all the notify_resume stuff to > tracehook_notify_resume() is good, but it does make me go - once again > - "Hmm, that naming is really really bad". Absolutely, it's even in the commit message: --- Note, tracehook_notify_resume() is horribly named and arguably does not belong in tracehook.h as literally every line of code in it has nothing to do with tracing. But, that's been true since commit a42c6ded827d ("move key_repace_session_keyring() into tracehook_notify_resume()") first usurped tracehook_notify_resume() back in 2012. Punt cleaning that mess up to future patches. --- As you point out, it's really all of the header and not just that one function. Paolo > The code was literally meant for tracing. It's > where the name comes from, and it's the original intent: having a > place that you can hook into for tracing that doesn't depend on how > the core kernel code ends up changing. > > But that's not how it actually acts right now. That header file is now > some very core functionality, and little of it is actually related to > tracing any more. It's more core process state handling for the user > space return path. > > So I don't object to the patches, and they are merged, but I'm cc'ing people to > > (a) let them know about this (see commit a68de80f61f6: "entry: rseq: > Call rseq_handle_notify_resume() in tracehook_notify_resume()" in the > current -git tree) > > (b) possibly prod some people into perhaps moving/renaming some of > that code to actual core kernel C files, instead of a misnamed header > file.. > > Hmm? > > Linus >