From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AB6323919E for ; Wed, 4 Dec 2024 19:06:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733339167; cv=none; b=DdX1bP8HYHwEh2eezcgS+I5Yo2vpJjnegSwGhNYgqQq/W6RYbraDgUUha/j2AKTtcDjU5pdp4C34n7knCDuiWVNDNbaebLwvkcc8V8Vp72LULKukCOFPsj8RASajSbxSPD0CPAo8IJciGqgQY5mcOX8xTUlv6SqepgSJ97O9q6U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733339167; c=relaxed/simple; bh=65fxsdph7FrFvZX6a2W4aEbZiEgacsW3UUoh/EurRa0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n6q7N7F39fxknuJ+PiAl1QXUDNHxLNXrMGxdKf5v4mkgmQ1SPr+3mqcad00NF43WgAT3a0Eqh9siKmHuQ1ZvPo1R6XdsK1bpRElwu708XnVBdT4LdnQOQGFcC/I++HqthO0c+b5Y8vTKjK/jVa7VGyy6uM6NlkHE1bNlng2Bejo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=e+HTR7Y4; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="e+HTR7Y4" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-7b676152a86so134403385a.1 for ; Wed, 04 Dec 2024 11:06:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1733339165; x=1733943965; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=rwAMqF5C2/XSwGsn6tg9idQ+gKok1OrDZ/TQYQQC3ME=; b=e+HTR7Y4brFOEn+P1MjdI0U2YLGGW/MjqhUWA4PRZjUQoDrYnL7TzQZBODnxKDui8A 0DPv/2SW0ObETQh7aBmz27o3YfeEBxCT2t9g6d7ZHAgu8yvrL3U28ElCxA+0rpPnQe1N 2GXeUAqNt24Ptx5e/BJ2YnTYiiI19XTFJJSm4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733339165; x=1733943965; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rwAMqF5C2/XSwGsn6tg9idQ+gKok1OrDZ/TQYQQC3ME=; b=KDCRmqfN/P6cudqJMf6oe1ro2Iim5LJd44KOSLlYuBKojCOQ26ve/DtQ2G12S0y3RI 07hjt+oA7uS6eSGG9oQerV7VLgZhbhVisouo/FaEtGE+p/FqFRP3lyuQqP4Tx5hwZS1N sJrUCLnMZSu/U72NyZ/MB6dzRNQsioFpduflqAo2hWAtYenu2QARR+l+1IMgoE7mYlKV LsUpFEpSvjfvsQa64maxzihYZD9rL3/Iumvpjps2oyuGDidjQUBSCTOGSgpeUR98Eqvp 0oiOqVtLMrfkGFXKcXaElXkeDVpPkbjfNMUOpDGZIRkNJCDEbDIPN7rHJlf0QV6y6uJk BYPA== X-Forwarded-Encrypted: i=1; AJvYcCWH2A8YmHmXgXleq56d3YHibfs6+x/PFi2WN5QAZu2Aw7elz22qnVAJpLIQ//SREVdYsYNuUgHR6/TGFXY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5ZwllZaxRcoNYBhdcNazqL4EuPvaO04imN4w3b8dRf2y7J7BJ NEeHxBsLAgoKcyNOBjVGpMbjAWd7ij1H01IdZsZ/+29WwN8dLahfNbBxSkiUw9gqzDa1rLciLX8 ETg== X-Gm-Gg: ASbGnctmzbOAG/LK3t+qqlbYB07nMZNAyC/D9CMGbZJeFPzx9WrBJQ2Vorp0UgTwB/1 rAMmNhyYv6pv3XX154WpqAcJ61yGwhQ00pt44Ik9fLIujZRdBVFumEfSsfIWycKaYB17pxVqpH6 g7aaxBYU1V22uMrqRDOONRlopooEmDnvAZ3Qd/hAd2iVj02NV6A1LwtZI9eLudQuyDFjann5zdM HjGvHkHDSYauy2o74XGfYzz+wPrwih+G+8XnFvG2gwYAgowJAGEfUV4JNmR1hD/zlfvZ4WMbh56 nuky34HqaQV6mw== X-Google-Smtp-Source: AGHT+IET8ru0K2M3tO3OOrXNHAiQ22hdOskTrfOZXT2O7Z5zjNnzqqS/g1Ime/BQv4SnXZ/y8604qA== X-Received: by 2002:a05:620a:6005:b0:7b1:48d1:574d with SMTP id af79cd13be357-7b6b4185bdfmr97267185a.8.1733339164891; Wed, 04 Dec 2024 11:06:04 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b6849aac82sm635574085a.94.2024.12.04.11.06.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Dec 2024 11:06:04 -0800 (PST) Message-ID: <5b36a3c7-f691-49e5-a4c6-803ddccdd5ea@broadcom.com> Date: Wed, 4 Dec 2024 11:05:58 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/7] arm64: dts: broadcom: Fix device tree warnings for BCM2712 display pipeline To: Krzysztof Kozlowski , Dave Stevenson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Broadcom internal kernel review list , Eric Anholt , =?UTF-8?Q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Ray Jui , Scott Branden , Doug Berger , Linus Walleij , Bartosz Golaszewski Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Florian Fainelli , linux-gpio@vger.kernel.org References: <20241202-dt-bcm2712-fixes-v1-0-fac67cc2f98a@raspberrypi.com> <20241202-dt-bcm2712-fixes-v1-4-fac67cc2f98a@raspberrypi.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/2/24 07:20, Krzysztof Kozlowski wrote: > On 02/12/2024 15:31, Dave Stevenson wrote: >> Fixes up errors on HDMI and interrupt controllers that weren't > > What errors? I can't find anything in the commit. Describe the error. > >> noticed before merging. >> >> Fixes: de9bc2dba3db ("arm64: dts: broadcom: Add display pipeline support to BCM2712") >> Signed-off-by: Dave Stevenson >> --- >> arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi >> index 39305e0869ec..f42fad2d8b37 100644 >> --- a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi >> +++ b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi >> @@ -336,7 +336,7 @@ ddc1: i2c@7d508280 { >> #size-cells = <0>; >> }; >> >> - bsc_irq: intc@7d508380 { >> + bsc_irq: interrupt-controller@7d508380 { > > > Do not mix cleanups with bugfixes. > > BTW, do not mix DTS to DRM. DRM has its own development style. DTS > *cannot* be merged there, so combining these series is not welcomed and > leads to issues (like DRM applying DTS!). That is not what was done, I took the DTS patches via the Broadcom ARM SoC tree, as I usually do, unless someone tells me otherwise. We got a number of DTS warnings after I took Dave's patches so I asked for those to be fixed, as it turns out there are binding and DTS fixes. I intend to squash these fixes with their original commit, so all of those commit messages will be discarded, they are only meant to be transitional. -- Florian