From: Kuldeep Singh <quic_kuldsing@quicinc.com>
To: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] qcom_tzmem: Enhance Error Handling for shmbridge
Date: Tue, 8 Oct 2024 01:05:52 +0530 [thread overview]
Message-ID: <5b4510dc-bc41-4fd4-b06b-75a3f0c25309@quicinc.com> (raw)
In-Reply-To: <CACMJSesUCVXu8qdFgp88KL9KZxL80ki0UE09f5ciEbe23NvamA@mail.gmail.com>
On 10/7/2024 7:55 PM, Bartosz Golaszewski wrote:
> On Sat, 5 Oct 2024 at 16:02, Kuldeep Singh <quic_kuldsing@quicinc.com> wrote:
>>
>> This patchset addresses the tzmem driver probe failure caused by
>> incorrect error handling. The qcom_scm_shm_bridge_enable() SCM call
>> captures SCM success/failure in a0 and E_NOT_SUPPORTED in a1.
>>
>> Previously, qcom_scm returned values based solely on a0, without
>> capturing not_supported scenario. This patchset corrects that behavior.
>>
>
> Ah, I guess this may be the reason for the SHM bridge enablement to
> seemingly work on certain platforms and then lead to crashes when we
> actually try to use it?
This patchset corrects the behavior for handling unsupported SHM bridge scenarios.
If the SHM bridge is supported and enabled for a target, any subsequent failures
should be investigated to understand what went wrong.
I am willing to put effort in that case.
--
Regards
Kuldeep
prev parent reply other threads:[~2024-10-07 19:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-05 14:01 Kuldeep Singh
2024-10-05 14:01 ` [PATCH 1/2] firmware: qcom: scm: Return -EOPNOTSUPP for unsupported SHM bridge enabling Kuldeep Singh
2024-10-06 17:35 ` Dmitry Baryshkov
2024-10-06 22:01 ` Kuldeep Singh
2024-10-07 18:11 ` Mukesh Ojha
2024-10-07 1:40 ` Bjorn Andersson
2024-10-07 20:40 ` Kuldeep Singh
2024-10-07 21:45 ` Bjorn Andersson
2024-10-05 14:01 ` [PATCH 2/2] firmware: qcom: qcom_tzmem: Implement sanity checks Kuldeep Singh
2024-10-06 19:30 ` Dmitry Baryshkov
2024-10-07 19:17 ` Kuldeep Singh
2024-10-07 20:13 ` Dmitry Baryshkov
2024-10-07 20:44 ` Kuldeep Singh
2024-10-07 20:56 ` Bartosz Golaszewski
2024-10-07 1:18 ` Bjorn Andersson
2024-10-07 14:23 ` Bartosz Golaszewski
2024-10-07 19:23 ` Kuldeep Singh
2024-10-07 14:25 ` [PATCH 0/2] qcom_tzmem: Enhance Error Handling for shmbridge Bartosz Golaszewski
2024-10-07 19:35 ` Kuldeep Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b4510dc-bc41-4fd4-b06b-75a3f0c25309@quicinc.com \
--to=quic_kuldsing@quicinc.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®