From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>,
Denis Plotnikov <dplotnikov@virtuozzo.com>
Cc: rkrcmar@redhat.com, kvm@vger.kernel.org, john.stultz@linaro.org,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
linux-kernel@vger.kernel.org, x86@kernel.org,
rkagan@virtuozzo.com, den@virtuozzo.com
Subject: Re: [PATCH v4 07/10] KVM: x86: remove not used pvclock_gtod_copy
Date: Thu, 3 Aug 2017 14:35:19 +0200 [thread overview]
Message-ID: <5b46dad3-a81f-e908-70e5-e7a0f29318d1@redhat.com> (raw)
In-Reply-To: <20170802232131.GA20388@amt.cnet>
On 03/08/2017 01:21, Marcelo Tosatti wrote:
>> - if (ka->use_master_clock ||
>> - (gtod->clock.vclock_mode == VCLOCK_TSC && vcpus_matched))
>> + if (ka->use_master_clock || vcpus_matched)
>> kvm_make_request(KVM_REQ_MASTERCLOCK_UPDATE, vcpu);
> Don't drop this. The masterclock scheme requires TSC for proper functioning
> (or an analysis why its supposed with different HPET+TSC, for example).
I think testing gtod->clock.vclock_mode is just an optimization?
kvm_get_time_and_clockread would return false anyway and masterclock
would not be enabled.
Paolo
next prev parent reply other threads:[~2017-08-03 12:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 14:38 [PATCH v4 00/10] make L2's kvm-clock stable, get rid of pvclock_gtod_copy in KVM Denis Plotnikov
2017-08-02 14:38 ` [PATCH v4 01/10] timekeeper: introduce extended clocksource reading callback Denis Plotnikov
2017-08-02 17:08 ` John Stultz
2017-08-02 17:21 ` Paolo Bonzini
2017-08-02 14:38 ` [PATCH v4 02/10] timekeeper: introduce boot field in system_time_snapshot Denis Plotnikov
2017-08-02 14:38 ` [PATCH v4 03/10] timekeeper: use the extended reading function on snapshot acquiring Denis Plotnikov
2017-08-02 14:38 ` [PATCH v4 04/10] tsc: implement the extended tsc reading function Denis Plotnikov
2017-08-02 14:38 ` [PATCH v4 05/10] KVM: x86: switch to masterclock update using timekeeper functionality Denis Plotnikov
2017-08-02 14:38 ` [PATCH v4 06/10] timekeeper: add clocksource change notifier Denis Plotnikov
2017-08-02 14:38 ` [PATCH v4 07/10] KVM: x86: remove not used pvclock_gtod_copy Denis Plotnikov
2017-08-02 23:21 ` Marcelo Tosatti
2017-08-03 12:35 ` Paolo Bonzini [this message]
2017-08-11 22:59 ` Marcelo Tosatti
2017-08-02 14:38 ` [PATCH v4 08/10] pvclock: add parameters to store stamp data in pvclock reading function Denis Plotnikov
2017-08-02 14:38 ` [PATCH v4 09/10] pvclock: add clocksource change notification on changing of tsc stable bit Denis Plotnikov
2017-08-02 23:36 ` Marcelo Tosatti
2017-08-02 14:38 ` [PATCH v4 10/10] kvmclock: implement the extended reading function Denis Plotnikov
2017-08-02 16:10 ` [PATCH v4 00/10] make L2's kvm-clock stable, get rid of pvclock_gtod_copy in KVM Paolo Bonzini
2017-08-02 16:49 ` John Stultz
2017-08-02 17:11 ` Paolo Bonzini
2017-08-21 8:40 ` Denis Plotnikov
2017-08-22 19:50 ` John Stultz
2017-08-22 21:00 ` Paolo Bonzini
2017-08-23 12:45 ` Thomas Gleixner
2017-08-23 16:02 ` Paolo Bonzini
2017-08-24 8:00 ` Paolo Bonzini
2017-08-28 7:28 ` Denis Plotnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b46dad3-a81f-e908-70e5-e7a0f29318d1@redhat.com \
--to=pbonzini@redhat.com \
--cc=den@virtuozzo.com \
--cc=dplotnikov@virtuozzo.com \
--cc=hpa@zytor.com \
--cc=john.stultz@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=rkagan@virtuozzo.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome