From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F03B32E041D for ; Thu, 15 Jan 2026 09:30:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768469456; cv=none; b=b0/3KiYeHLa007Sudho5b7FkmhMcY6n1E8W4tClsaq9t3T1xNNpqpE8sGp8xAkTCCNqSVYHHnY7YMX48ZyF20UatUpNzWZNJQACOG+EVAZddP5z5OQnAGdmNmsoqPSNLI/xqnlr99MKcK3PgU9yCURRncxgujL+f+xk6//3iMyg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768469456; c=relaxed/simple; bh=DauQk9p5pIosUBhPuxMl4TQB9wnU7vTST03SGF1cKT8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uswFdYS+nb8CJD2H569zQeoDlov3q3oqAZ+SbpBNr06ItYZeQyofckvFUc/VgmweTlYJyvuKhXfuqrArWmle7EDwq/TLtkclcHaQRsii9qHGkCJ6UqLT/spdB2cgfYS2ubMx+ddyD539nfQI3NWOSQXIHGYK64z1WdgZpeknfM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XwRmoqbs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QIFILosX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XwRmoqbs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QIFILosX" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60F6fxT81171463 for ; Thu, 15 Jan 2026 09:30:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6UFfVn4U9hhL7GUJ/TzKS7TheZ9cYLz0xB+kdpbIWKA=; b=XwRmoqbs/d+v5A/t JklcSpWok4LGHzCBTmDNS1eA5Y/xK7NQmGNfdxzyTkDDsM8Yn0SBmar9vQX04GhP CwZ0uLlKHBpPj3dAKZGq8fYjZUxXa1aN7roM8ebZWk0tTyXJbL8WbM9Yj8ZdhJdp rnKWNMefi9FZZnR1sxNJCHGTbD/a0lToh2ikzH6KgrrvY7A2r/Tt+hM1NxT1B8yU gKhTFenDzFV/ffLKlPIzw2CAh1Blqh5s1ptLfNEGQbmREOUHhRDo9h/OOi8XOeVD nzqwXClqqn/fHaFkQoo/dZavxuQKN6Nf3GYM6hZTi2kZKjPjKP4hvgC1XKhoaLL5 +1i5Fg== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bpg84acfw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 15 Jan 2026 09:30:54 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-88887682068so1870036d6.0 for ; Thu, 15 Jan 2026 01:30:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768469453; x=1769074253; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6UFfVn4U9hhL7GUJ/TzKS7TheZ9cYLz0xB+kdpbIWKA=; b=QIFILosXRByNAwIwXJGW6CuYKFbtFxpGucnwRRONnIhRVA0CsCPzj8LjUCQJLnZ2ML covnnqvrh0woVC/njyng87QOfWr7y3UCKMFMtvXkG516VXgdzsjUHkOELlhsnzgboq/7 EvUvKXwEfhiVqIijaRlAL4TmGeDgi226n30bmlShV25V0tQhPRH/5IK7n5iu4ifEyExK pP58F3Tov7wPGJgzSjItGBGiE3H5t/dYzoBfjtinJ8oPbTQ6jQYlQqsiaJCR0T8LgEPj 5rdN7jL+xhK6d6Nlg4RuW7ykljIJbDCp8IJYbgtW7jeAfLEgXczuISqZy8JVoSlQByg5 LpiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768469453; x=1769074253; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6UFfVn4U9hhL7GUJ/TzKS7TheZ9cYLz0xB+kdpbIWKA=; b=af/LAqyw67yQVfuO3mAE30ltPFMc/XlhNXhLfVMMm8mfdQAhAgY6L2Nw5oD412b9Ry sLK5YBwHEEF/IpToZCsREmivcKFqPxfpPkHhenKoueAAC4bN4W3vIC+jiuPS1O8vZ2c6 E6sWFq+gGgCikXw67cNZ+K4mWhVEUb4UJCzxXkRXf53mXoosnkkJDLUlwdo4wzQFG6RU sxpJcpf6G4qSbOSnjLiiTKWOn9dCix+dW7BSsNMuGNBajXOZW6OZUjNpi487ZHVXyXXN SqJiB6vEBPeYPuSgA0fCIdrY8dNFhbP8EigACFrdcuGYyeVo1vVBzuMp7B2ubJPC1tXl lNtA== X-Forwarded-Encrypted: i=1; AJvYcCX6WWwAToY0NvIO2bp7HKM5AXxTrdE1Hg9PD3YCyrWsYK5ukMSeRcGU0LAjNgRj6voqsDWsirgPwke70VI=@vger.kernel.org X-Gm-Message-State: AOJu0YzSarzceRfnbe2njLda4RkfF2r2HreEfL6Enz06O7lB2lLpnVyu rwiiMU27yJ7hkX7iegE6t7iox5ph5lkCLQtCh0Sj7SpYU95NNATnJg8M9GRQHYD/5DgN+7gf58B IsoDs+MHktNCIkSy+K+71vgN597H5hBB7aLaXnh4sglpXr/Dedaz6gyA01Lh0Efx2IZ0= X-Gm-Gg: AY/fxX7ek6BXtNza8C43XwidTQpUclj1fxjZSf+WWJDKaVLr1pXqs6GJu35C6O3EPyV mK3Q9MB+B8kAMzPYHJMkr1gCMoH9g0I/JgboT4m6iyyi0ERWoh03txQtT11Z21dyHDC/hD/08d6 qBvY2Yd0zP3qOQXfWidc2MUM4z73m7/HTiEAaqdjGW0Yl3zE2iGyFCut9Pocj02IeUIVMlAZWzl j6THkUKNdIpRuuab6qPwrb2sbBNpLZ+NIFZhQ4Tbx4boXL0472Pxx28Y+2dJBLsyoJ/1rloRLAr B3i0f685x6G0PRSuT5crVGTHBUTwjsmTr9Jm9OnrZK97kkbHFwXmuAH/uvF6W1Ebg2nRN92PQI8 J9pMkysb8uPAJX4M16ahIHsUsW5S94lS8qe3gLO+dNm+cZS6sX5Zt+jGpDdKNLqrTqTE= X-Received: by 2002:ac8:5a0e:0:b0:4ff:b757:1210 with SMTP id d75a77b69052e-5014811e52amr57935611cf.0.1768469452983; Thu, 15 Jan 2026 01:30:52 -0800 (PST) X-Received: by 2002:ac8:5a0e:0:b0:4ff:b757:1210 with SMTP id d75a77b69052e-5014811e52amr57935311cf.0.1768469452547; Thu, 15 Jan 2026 01:30:52 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65411877707sm1934109a12.1.2026.01.15.01.30.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jan 2026 01:30:52 -0800 (PST) Message-ID: <5b4870fc-911d-4574-a0ce-59428cbdf103@oss.qualcomm.com> Date: Thu, 15 Jan 2026 10:30:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/8] drm/msm/dp: Move link training to atomic_enable() To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Kuogee Hsieh Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jessica Zhang References: <20260115-hpd-refactor-v3-0-08e2f3bcd2e0@oss.qualcomm.com> <20260115-hpd-refactor-v3-4-08e2f3bcd2e0@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260115-hpd-refactor-v3-4-08e2f3bcd2e0@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE1MDA2NSBTYWx0ZWRfX0iZvMDQvVcdu ms+dpXvj9F9iDa/wJT2ejj2/6i8EceTbswV6T1v9A53J6XwFNY6Ubn+kty69Z8eyaN6B4LEWTI5 7pGd4CT+y6zMe1gII3uI1xJk6JXsr/ytoB3jYJNwa/M45FKTRCqWfC3eTvX61nOOG9gfdkNFVMs 72xS3xAR21H0RITRPfe6oe2bpoLZ9mXfKHTvfi6BHcaPOspPsPYnnI7ecpoCSBQdLiVxIiIwQ9F bV87axFcYYwdOyhRNpKtRzY8bISkEdv+vhcBx1oyLyeCdUxtNuPGeF036dQxE5zSUVisFAh8Yeo bt9XjLlM/f9zYNnKyHDlN+/gFIf188XZxrl7gAUKu8SJcn+/aJ4tqii9OssZBg3PU0BsqkJjfDO XQcHtER6K5ShUYruTgwEcgWKZMYMyxDkKj8O2KlvJGUSuJO+C2gc3rAKAV/tpJ5rYvHpIf3FuCM rf3kbl71PLN1OsqfUOg== X-Authority-Analysis: v=2.4 cv=IO8PywvG c=1 sm=1 tr=0 ts=6968b3ce cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=tir8h9pnGiVj9xZly-MA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-GUID: IUqjTnLzDxayz28v7-0QLgXN4SikMn01 X-Proofpoint-ORIG-GUID: IUqjTnLzDxayz28v7-0QLgXN4SikMn01 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-15_02,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 priorityscore=1501 impostorscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601150065 On 1/15/26 8:29 AM, Dmitry Baryshkov wrote: > From: Jessica Zhang > > Currently, the DP link training is being done during HPD. Move > link training to atomic_enable() in accordance with the atomic_enable() > documentation. > > Link disabling is already done in atomic_post_disable() (as part of the > dp_ctrl_off_link_stream() helper). > > Finally, call the plug/unplug handlers directly in hpd_notify() instead > of queueing them in the event thread so that they aren't preempted by > other events. I think this part of the commit message no longer applies > > Signed-off-by: Jessica Zhang > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dp/dp_display.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index a05144de3b93..3184066adb15 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -436,11 +436,6 @@ static int msm_dp_display_process_hpd_high(struct msm_dp_display_private *dp) > msm_dp_link_psm_config(dp->link, &dp->panel->link_info, false); > > msm_dp_link_reset_phy_params_vx_px(dp->link); > - rc = msm_dp_ctrl_on_link(dp->ctrl); > - if (rc) { > - DRM_ERROR("failed to complete DP link training\n"); > - goto end; > - } > > msm_dp_add_event(dp, EV_USER_NOTIFICATION, true, 0); > > @@ -1695,6 +1690,12 @@ void msm_dp_bridge_atomic_enable(struct drm_bridge *drm_bridge, > force_link_train = true; > } > > + rc = msm_dp_ctrl_on_link(msm_dp_display->ctrl); > + if (rc) { > + DRM_ERROR("Failed link training (rc=%d)\n", rc); > + drm_connector_set_link_status_property(dp->connector, DRM_LINK_STATUS_BAD); > + } Previously failure in this call would have propagated an error msm_dp_ctrl_on_link() enables mainlink clocks, so > + > msm_dp_display_enable(msm_dp_display, force_link_train); IIUC this will crash the machine if the above fails Konrad